Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12448

TestTextCommand: use mkdirs rather than mkdir to create test directory

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      TestTextCommand should use mkdirs rather than mkdir to create the test directory.

      1. HADOOP-12448.002.patch
        2 kB
        Chris Nauroth
      2. HADOOP-12448.001.patch
        2 kB
        Colin P. McCabe

        Activity

        Hide
        hudson Hudson added a comment -

        ABORTED: Integrated in Hadoop-Hdfs-trunk #2378 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2378/)
        HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        Show
        hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk #2378 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2378/ ) HADOOP-12448 . TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #438 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/438/)
        HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #438 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/438/ ) HADOOP-12448 . TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2406 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2406/)
        HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2406 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2406/ ) HADOOP-12448 . TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #471 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/471/)
        HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #471 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/471/ ) HADOOP-12448 . TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #463 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/463/)
        HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #463 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/463/ ) HADOOP-12448 . TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #1202 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1202/)
        HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1202 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1202/ ) HADOOP-12448 . TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        Hide
        cnauroth Chris Nauroth added a comment -

        Yi Liu and Colin P. McCabe, thank you!

        Show
        cnauroth Chris Nauroth added a comment - Yi Liu and Colin P. McCabe , thank you!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8546 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8546/)
        HADOOP-12448. TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8546 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8546/ ) HADOOP-12448 . TestTextCommand: use mkdirs rather than mkdir to create test directory. (Contributed by Colin Patrick McCabe and Chris Nauroth) (yliu: rev 06abc57a90bb2ac86121cc803a60dab82609da88) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/shell/TestTextCommand.java
        Hide
        hitliuyi Yi Liu added a comment -

        Committed to trunk and branch-2.

        Show
        hitliuyi Yi Liu added a comment - Committed to trunk and branch-2.
        Hide
        hitliuyi Yi Liu added a comment -

        +1, thanks Colin P. McCabe and Chris Nauroth, will commit it shortly.

        Show
        hitliuyi Yi Liu added a comment - +1, thanks Colin P. McCabe and Chris Nauroth , will commit it shortly.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 7m 27s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 58s There were no new javac warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 7s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        -1 common tests 6m 10s Tests failed in hadoop-common.
            27m 2s  



        Reason Tests
        Failed unit tests hadoop.metrics2.sink.TestFileSink



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12764281/HADOOP-12448.002.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / 80d33b5
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 7m 27s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 58s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 7s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 6m 10s Tests failed in hadoop-common.     27m 2s   Reason Tests Failed unit tests hadoop.metrics2.sink.TestFileSink Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764281/HADOOP-12448.002.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 80d33b5 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7737/console This message was automatically generated.
        Hide
        cnauroth Chris Nauroth added a comment -

        This is a good idea. It's probably helpful for stable parallel test execution. (HADOOP-11984).

        However, -1 for patch v001. This would fail on Windows. The path strings constructed for the files would not be valid URI syntax due to the drive spec. There is a point in the tests where the path strings are converted back to a URI, and this causes an exception to be thrown.

        I took the liberty of making a small tweak and verifying that it passes on Mac and Windows. I'm attaching it as v002.

        Thanks, Colin P. McCabe! Maybe another committer can review and +1, since I have sullied myself by touching the patch?

        Show
        cnauroth Chris Nauroth added a comment - This is a good idea. It's probably helpful for stable parallel test execution. ( HADOOP-11984 ). However, -1 for patch v001. This would fail on Windows. The path strings constructed for the files would not be valid URI syntax due to the drive spec. There is a point in the tests where the path strings are converted back to a URI , and this causes an exception to be thrown. I took the liberty of making a small tweak and verifying that it passes on Mac and Windows. I'm attaching it as v002. Thanks, Colin P. McCabe ! Maybe another committer can review and +1, since I have sullied myself by touching the patch?
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        -1 pre-patch 7m 9s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 47s There were no new javac warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 8s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 28s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 6m 45s Tests passed in hadoop-common.
            27m 6s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12764264/HADOOP-12448.001.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / a2efb94
        Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/testReport/
        Java 1.7.0_55
        uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 7m 9s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 47s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 8s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 28s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 6m 45s Tests passed in hadoop-common.     27m 6s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764264/HADOOP-12448.001.patch Optional Tests javac unit findbugs checkstyle git revision trunk / a2efb94 Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7734/console This message was automatically generated.

          People

          • Assignee:
            cmccabe Colin P. McCabe
            Reporter:
            cmccabe Colin P. McCabe
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development