Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12374

Description of hdfs expunge command is confusing

    Details

    • Target Version/s:

      Description

      Usage: hadoop fs -expunge

      Empty the Trash. Refer to the HDFS Architecture Guide for more information on the Trash feature.

      this description is confusing. It gives user the impression that this command will empty trash, but actually it only removes old checkpoints. If user sets a pretty long value for fs.trash.interval, this command will not remove anything until checkpoints exist longer than this value.

      1. HADOOP-12374.001.patch
        2 kB
        Weiwei Yang
      2. HADOOP-12374.002.patch
        2 kB
        Weiwei Yang
      3. HADOOP-12374.003.patch
        2 kB
        Weiwei Yang
      4. HADOOP-12374.004.patch
        2 kB
        Weiwei Yang

        Issue Links

          Activity

          Hide
          cheersyang Weiwei Yang added a comment -

          The change is minor, but it helps to avoid confusing people to a wrong direction. Can somebody help to review this ?

          Thanks a lot.

          Show
          cheersyang Weiwei Yang added a comment - The change is minor, but it helps to avoid confusing people to a wrong direction. Can somebody help to review this ? Thanks a lot.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 23s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 50s There were no new javac warning messages.
          +1 javadoc 9m 58s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 3s Site still builds.
          +1 checkstyle 1m 7s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 6s Tests passed in hadoop-common.
              69m 48s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753694/HADOOP-12374.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 65ccf2b
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7577/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7577/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7577/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 23s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 50s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 3m 3s Site still builds. +1 checkstyle 1m 7s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 6s Tests passed in hadoop-common.     69m 48s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753694/HADOOP-12374.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 65ccf2b hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7577/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7577/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7577/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          I'm concerned that the new phrasing makes it more confusing. It would help me if you could explain what you find confusing about "empty the trash."

          Show
          templedf Daniel Templeton added a comment - I'm concerned that the new phrasing makes it more confusing. It would help me if you could explain what you find confusing about "empty the trash."
          Hide
          cheersyang Weiwei Yang added a comment -

          Thanks Daniel Templeton

          We'd like to keep it short here but informative and let user read the details from HDFS architecture guide, I am thinking to revise it to

          Find expired checkpoints in trash directory and remove them if trash is enabled. This command does not immediately empty the trash. Refer to the HDFS Architecture Guide for more information on the Trash feature.

          Looks better ?

          Show
          cheersyang Weiwei Yang added a comment - Thanks Daniel Templeton We'd like to keep it short here but informative and let user read the details from HDFS architecture guide, I am thinking to revise it to Find expired checkpoints in trash directory and remove them if trash is enabled. This command does not immediately empty the trash. Refer to the HDFS Architecture Guide for more information on the Trash feature. Looks better ?
          Hide
          templedf Daniel Templeton added a comment -

          My primary concern is with the word "checkpoint." I'm worried that a newbie, i.e. someone who would be reading the documentation, wouldn't understand what that means without having to do more research. The advantage of the current phrasing is that it's immediately understandable, even if it's not exactly accurate.

          Show
          templedf Daniel Templeton added a comment - My primary concern is with the word "checkpoint." I'm worried that a newbie, i.e. someone who would be reading the documentation, wouldn't understand what that means without having to do more research. The advantage of the current phrasing is that it's immediately understandable, even if it's not exactly accurate.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hi Daniel

          someone who would be reading the documentation, wouldn't understand what that means without having to do more research
          >> User can go to reference link to understand what is checkpoint and what does this command do

          The problem is current phrasing is WRONG, it gives user a false impression.

          Show
          cheersyang Weiwei Yang added a comment - Hi Daniel someone who would be reading the documentation, wouldn't understand what that means without having to do more research >> User can go to reference link to understand what is checkpoint and what does this command do The problem is current phrasing is WRONG, it gives user a false impression.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 10s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 37s There were no new javac warning messages.
          +1 javadoc 9m 48s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 0s Site still builds.
          +1 checkstyle 1m 7s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 45s Tests passed in hadoop-common.
              68m 42s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12754418/HADOOP-12374.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 9b68577
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7610/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7610/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7610/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 10s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 48s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 0s Site still builds. +1 checkstyle 1m 7s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 45s Tests passed in hadoop-common.     68m 42s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754418/HADOOP-12374.001.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 9b68577 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7610/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7610/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7610/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          > User can go to reference link to understand what is checkpoint and what does this command do

          The provided link is to the HDFS architecture guide. In that guide, if you search for "trash", it tells you that deleting a file will actually move it into the trash. True, but not helpful. If you search for "checkpoint", it tells you about the NN's edit log checkpointing. Also true, but not helpful. The only thing I was able to find that clarified in specific terms what a trash checkpoint is, is the source code. Googling around a bit, there are a couple of forum and blog posts here and there that do explain bits of how the trash works in HDFS, and taken together you get a pretty clear picture, but that's a handful of hits in a sea of "it empties the trash."

          My point is that this is an excellent opportunity to create a useful source of documentation on what happens when you use -expunge. I think these docs would be much more helpful if they said something like:

          • The trash folder is divided into "checkpoints" that contain the files deleted during given time windows
          • Every fs.trash.checkpoint.interval minutes, HDFS will create a new checkpoint, and all files subsequently deleted will go there
          • Every fs.trash.interval minutes, HDFS will delete all checkpoints older than fs.trash.interval and then create a new checkpoint
          • hdfs -expunge will causes HSDS to delete all checkpoints older than fs.trash.interval

          I didn't think too hard about the phrasing, but you get my point. Provide enough information that a user can understand what a checkpoint is and why they'd want to expunge one without having to go on a Googlequest or read source code.

          Show
          templedf Daniel Templeton added a comment - > User can go to reference link to understand what is checkpoint and what does this command do The provided link is to the HDFS architecture guide. In that guide, if you search for "trash", it tells you that deleting a file will actually move it into the trash. True, but not helpful. If you search for "checkpoint", it tells you about the NN's edit log checkpointing. Also true, but not helpful. The only thing I was able to find that clarified in specific terms what a trash checkpoint is, is the source code. Googling around a bit, there are a couple of forum and blog posts here and there that do explain bits of how the trash works in HDFS, and taken together you get a pretty clear picture, but that's a handful of hits in a sea of "it empties the trash." My point is that this is an excellent opportunity to create a useful source of documentation on what happens when you use -expunge. I think these docs would be much more helpful if they said something like: The trash folder is divided into "checkpoints" that contain the files deleted during given time windows Every fs.trash.checkpoint.interval minutes, HDFS will create a new checkpoint, and all files subsequently deleted will go there Every fs.trash.interval minutes, HDFS will delete all checkpoints older than fs.trash.interval and then create a new checkpoint hdfs -expunge will causes HSDS to delete all checkpoints older than fs.trash.interval I didn't think too hard about the phrasing, but you get my point. Provide enough information that a user can understand what a checkpoint is and why they'd want to expunge one without having to go on a Googlequest or read source code.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hi Daniel Templeton

          Thank you so much for the comments, I get your point and it makes sense to me. My intention was to keep the phrasing simple and clear (like rest of docs), and give an extra link to elaborate how it works. I contributed another patch to improve the document (see HADOOP-5323), it explains checkpoints, those parameters and details about trash feature. So user can go to http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsDesign.html#File_Deletes_and_Undeletes. Note the link directly points to File Deletes and Undeletes, user doesn't need to search.

          So based on that, can we document the expunge command like below ?

          If trash feature is enabled, HDFS moves deleted files to a trash directory and creates checkpoints in a configurable interval, this command finds those expired checkpoints (exists more than fs.trash.interval) and remove them from the file system.

          Show
          cheersyang Weiwei Yang added a comment - Hi Daniel Templeton Thank you so much for the comments, I get your point and it makes sense to me. My intention was to keep the phrasing simple and clear (like rest of docs), and give an extra link to elaborate how it works. I contributed another patch to improve the document (see HADOOP-5323 ), it explains checkpoints, those parameters and details about trash feature. So user can go to http://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsDesign.html#File_Deletes_and_Undeletes . Note the link directly points to File Deletes and Undeletes , user doesn't need to search. So based on that, can we document the expunge command like below ? If trash feature is enabled, HDFS moves deleted files to a trash directory and creates checkpoints in a configurable interval, this command finds those expired checkpoints (exists more than fs.trash.interval) and remove them from the file system.
          Hide
          templedf Daniel Templeton added a comment -

          Thank you for doing HADOOP-5323! Very useful documentation. I wasn't looking at the latest docs, so I missed it.

          Updating the patch to link directly to that section would absolutely be helpful. It would also be nice to mention that File Deletes and Undeletes is in the Space Reclamation section. Because that's the last thing in the doc, the link points the browser further up the page. Knowing the major section title would help folks realize where the right text is.

          I do still have one concern: my original one. The doc text says "checkpoint," but nowhere is that term defined. Can we find a different way to phrase it? What about something like:

          If trash is enabled when a file is deleted, HDFS instead moves the deleted file to a trash directory. This command causes HDFS to permanently delete files from the trash that are older than the retention threshold. See [your link] for more information.

          I don't think the details about checkpointing are important to have here. I don't think the average user cares, and there's a link for those who do.

          Show
          templedf Daniel Templeton added a comment - Thank you for doing HADOOP-5323 ! Very useful documentation. I wasn't looking at the latest docs, so I missed it. Updating the patch to link directly to that section would absolutely be helpful. It would also be nice to mention that File Deletes and Undeletes is in the Space Reclamation section. Because that's the last thing in the doc, the link points the browser further up the page. Knowing the major section title would help folks realize where the right text is. I do still have one concern: my original one. The doc text says "checkpoint," but nowhere is that term defined. Can we find a different way to phrase it? What about something like: If trash is enabled when a file is deleted, HDFS instead moves the deleted file to a trash directory. This command causes HDFS to permanently delete files from the trash that are older than the retention threshold. See [your link] for more information. I don't think the details about checkpointing are important to have here. I don't think the average user cares, and there's a link for those who do.
          Hide
          cheersyang Weiwei Yang added a comment -

          Hello Daniel Templeton

          Many thanks. I have updated the patch that incorporated with your comments, please review it and let me know if it is good now.

          Show
          cheersyang Weiwei Yang added a comment - Hello Daniel Templeton Many thanks. I have updated the patch that incorporated with your comments, please review it and let me know if it is good now.
          Hide
          templedf Daniel Templeton added a comment -

          Looking good. One last quibble: can we get rid of "checkpoint" in the description text?

          Show
          templedf Daniel Templeton added a comment - Looking good. One last quibble: can we get rid of "checkpoint" in the description text?
          Hide
          cheersyang Weiwei Yang added a comment -

          Sure. I just updated that in 003 patch.

          Show
          cheersyang Weiwei Yang added a comment - Sure. I just updated that in 003 patch.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 21m 55s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 9m 4s There were no new javac warning messages.
          +1 javadoc 10m 2s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 2s Site still builds.
          -1 checkstyle 1m 16s The applied patch generated 2 new checkstyle issues (total was 12, now 13).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 25s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 22m 23s Tests failed in hadoop-common.
              71m 55s  



          Reason Tests
          Timed out tests org.apache.hadoop.ha.TestSshFenceByTcpPort



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12754851/HADOOP-12374.003.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 94cf7ab
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7620/artifact/patchprocess/diffcheckstylehadoop-common.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7620/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7620/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7620/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 21m 55s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 9m 4s There were no new javac warning messages. +1 javadoc 10m 2s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 2s Site still builds. -1 checkstyle 1m 16s The applied patch generated 2 new checkstyle issues (total was 12, now 13). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 25s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 22m 23s Tests failed in hadoop-common.     71m 55s   Reason Tests Timed out tests org.apache.hadoop.ha.TestSshFenceByTcpPort Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754851/HADOOP-12374.003.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 94cf7ab checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7620/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7620/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7620/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7620/console This message was automatically generated.
          Hide
          cheersyang Weiwei Yang added a comment -

          Fixed the checkstyle issue in 004 patch.

          Show
          cheersyang Weiwei Yang added a comment - Fixed the checkstyle issue in 004 patch.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 20m 10s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 54s There were no new javac warning messages.
          +1 javadoc 9m 59s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 2s Site still builds.
          +1 checkstyle 1m 8s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 25s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 50s Tests passed in hadoop-common.
              69m 21s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12754875/HADOOP-12374.004.patch
          Optional Tests javadoc javac unit findbugs checkstyle site
          git revision trunk / 0113e45
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7621/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7621/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7621/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 20m 10s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 54s There were no new javac warning messages. +1 javadoc 9m 59s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 site 3m 2s Site still builds. +1 checkstyle 1m 8s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 25s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 50s Tests passed in hadoop-common.     69m 21s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12754875/HADOOP-12374.004.patch Optional Tests javadoc javac unit findbugs checkstyle site git revision trunk / 0113e45 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7621/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7621/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7621/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Awesome! Looks great. +1 (non-binding)

          Thanks for working through this one. I know it was a lot of fuss for a very minor change, but I think the net result is a big improvement to a small part of the Hadoop user experience.

          Show
          templedf Daniel Templeton added a comment - Awesome! Looks great. +1 (non-binding) Thanks for working through this one. I know it was a lot of fuss for a very minor change, but I think the net result is a big improvement to a small part of the Hadoop user experience.
          Hide
          cheersyang Weiwei Yang added a comment -

          Thanks Daniel for all the valuable suggestions

          Show
          cheersyang Weiwei Yang added a comment - Thanks Daniel for all the valuable suggestions
          Hide
          cheersyang Weiwei Yang added a comment -

          Is there anybody who can help to commit this?

          Show
          cheersyang Weiwei Yang added a comment - Is there anybody who can help to commit this?
          Hide
          eyang Eric Yang added a comment -

          +1 I just committed this. Thank you WeiWei.

          Show
          eyang Eric Yang added a comment - +1 I just committed this. Thank you WeiWei.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #394 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/394/)
          HADOOP-12374. Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #394 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/394/ ) HADOOP-12374 . Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8463 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8463/)
          HADOOP-12374. Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8463 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8463/ ) HADOOP-12374 . Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          eyang Eric Yang added a comment -

          Jenkins build failure is not related to this patch.

          Show
          eyang Eric Yang added a comment - Jenkins build failure is not related to this patch.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1135 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1135/)
          HADOOP-12374. Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e)

          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1135 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1135/ ) HADOOP-12374 . Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #401 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/401/)
          HADOOP-12374. Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #401 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/401/ ) HADOOP-12374 . Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2341 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2341/)
          HADOOP-12374. Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2341 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2341/ ) HADOOP-12374 . Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2317 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2317/)
          HADOOP-12374. Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e)

          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2317 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2317/ ) HADOOP-12374 . Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #378 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/378/)
          HADOOP-12374. Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e)

          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #378 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/378/ ) HADOOP-12374 . Updated expunge command description. (eyang: rev 2ffe2db95ede7f30aeaece4619db7eb08b84280e) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Delete.java
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Cherry-picked this to branch-2.7 because this issue is to fix only documents and not likely to cause bugs.

          Show
          ajisakaa Akira Ajisaka added a comment - Cherry-picked this to branch-2.7 because this issue is to fix only documents and not likely to cause bugs.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8803 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8803/)
          Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8803 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8803/ ) Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2607 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2607/)
          Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2607 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2607/ ) Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #678 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/678/)
          Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #678 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/678/ ) Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1402 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1402/)
          Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1402 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1402/ ) Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #666 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/666/)
          Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #666 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/666/ ) Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #605 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/605/)
          Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #605 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/605/ ) Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2542 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2542/)
          Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2542 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2542/ ) Move HADOOP-12374 from 2.8.0 to 2.7.3 in CHANGES.txt. (aajisaka: rev 47c79a2a4d265feff7bd997bf07473eeb74c1c4b) hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Closing the JIRA as part of 2.7.3 release.

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

            People

            • Assignee:
              cheersyang Weiwei Yang
              Reporter:
              cheersyang Weiwei Yang
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development