Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.2.1, 0.23.11, 2.4.1, 2.5.2, 2.6.0, 2.7.0, 2.7.1
    • Fix Version/s: 2.8.0, 2.7.2, 3.0.0-alpha1
    • Component/s: documentation
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The docs at:

      http://hadoop.apache.org/docs/r2.7.1/hadoop-project-dist/hadoop-common/FileSystemShell.html#getmerge

      say that addnl is a valid parameter, but as of HADOOP-7348, it's been replaced with -nl. The docs should be updated.

      1. HADOOP-12359-01.patch
        1 kB
        Jagadesh Kiran N
      2. HADOOP-12359-02.patch
        1 kB
        Jagadesh Kiran N
      3. HADOOP-12359-03.patch
        1 kB
        Jagadesh Kiran N
      4. HADOOP-12359-04.patch
        1 kB
        Jagadesh Kiran N

        Issue Links

          Activity

          Hide
          jagadesh.kiran Jagadesh Kiran N added a comment -

          Attached the patch please review

          Show
          jagadesh.kiran Jagadesh Kiran N added a comment - Attached the patch please review
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 3m 15s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 3m 5s Site still builds.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              6m 46s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12752677/HADOOP-12359-01.patch
          Optional Tests site
          git revision trunk / fdb56f7
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7536/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 3m 15s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 3m 5s Site still builds. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     6m 46s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752677/HADOOP-12359-01.patch Optional Tests site git revision trunk / fdb56f7 Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7536/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Minor nitpick, but it would be nice if the doc's usage string matched what the shell prints:

          Usage: hadoop fs [generic options] -getmerge [-nl] <src> <localdst>

          i.e. swap the -nl to be the first, not last, arg.

          Show
          templedf Daniel Templeton added a comment - Minor nitpick, but it would be nice if the doc's usage string matched what the shell prints: Usage: hadoop fs [generic options] -getmerge [-nl] <src> <localdst> i.e. swap the -nl to be the first, not last, arg.
          Hide
          jagadesh.kiran Jagadesh Kiran N added a comment -

          Thanks for your review Daniel Templeton ,please find the updated patch, review the same

          Show
          jagadesh.kiran Jagadesh Kiran N added a comment - Thanks for your review Daniel Templeton ,please find the updated patch, review the same
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 3m 9s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 54s Site still builds.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              6m 27s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12752755/HADOOP-12359-02.patch
          Optional Tests site
          git revision trunk / 0bf2854
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7537/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 3m 9s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 21s The applied patch does not increase the total number of release audit warnings. +1 site 2m 54s Site still builds. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     6m 27s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752755/HADOOP-12359-02.patch Optional Tests site git revision trunk / 0bf2854 Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7537/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          Patch looks good to me. +1

          Show
          templedf Daniel Templeton added a comment - Patch looks good to me. +1
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Daniel Templeton thanks for reporting this jira and Jagadesh Kiran N thanks for working on this...

          how about adding exit code and example for this command like other commands,any thoughts..?

          Show
          brahmareddy Brahma Reddy Battula added a comment - Daniel Templeton thanks for reporting this jira and Jagadesh Kiran N thanks for working on this... how about adding exit code and example for this command like other commands,any thoughts..?
          Hide
          jagadesh.kiran Jagadesh Kiran N added a comment -

          Thanks Brahma Reddy Battula for your comments , I will update the patch

          Show
          jagadesh.kiran Jagadesh Kiran N added a comment - Thanks Brahma Reddy Battula for your comments , I will update the patch
          Hide
          jagadesh.kiran Jagadesh Kiran N added a comment -

          Brahma Reddy Battula updated the patch as per your comments. Akira Ajisaka ,Brahma Reddy Battula ,Daniel Templeton Please review the same

          Show
          jagadesh.kiran Jagadesh Kiran N added a comment - Brahma Reddy Battula updated the patch as per your comments. Akira Ajisaka , Brahma Reddy Battula , Daniel Templeton Please review the same
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 2m 53s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 59s Site still builds.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              6m 15s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12752980/HADOOP-12359-03.patch
          Optional Tests site
          git revision trunk / e166c03
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7546/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 2m 53s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 site 2m 59s Site still builds. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     6m 15s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12752980/HADOOP-12359-03.patch Optional Tests site git revision trunk / e166c03 Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7546/console This message was automatically generated.
          Hide
          templedf Daniel Templeton added a comment -

          New patch looks good. +1

          Show
          templedf Daniel Templeton added a comment - New patch looks good. +1
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Jagadesh Kiran N thanks for updated patch..It's looks good me..+1 (non-binding)

          Show
          brahmareddy Brahma Reddy Battula added a comment - Jagadesh Kiran N thanks for updated patch..It's looks good me..+1 (non-binding)
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Looks good to me.

          Optionally -nl can be set to enable adding a newline character at the end of each file.

          Would you document that the newline character is LF? Adding (LF) between 'character' and 'at the end' is fine to me.

          Show
          ajisakaa Akira Ajisaka added a comment - Looks good to me. Optionally -nl can be set to enable adding a newline character at the end of each file. Would you document that the newline character is LF? Adding (LF) between 'character' and 'at the end' is fine to me.
          Hide
          jagadesh.kiran Jagadesh Kiran N added a comment -

          Thanks Akira Ajisaka for your review,Updated with Review comments ,please check

          Show
          jagadesh.kiran Jagadesh Kiran N added a comment - Thanks Akira Ajisaka for your review,Updated with Review comments ,please check
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 3m 15s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 59s Site still builds.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              6m 39s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12753508/HADOOP-12359-04.patch
          Optional Tests site
          git revision trunk / faa38e1
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7571/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 3m 15s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 site 2m 59s Site still builds. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     6m 39s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12753508/HADOOP-12359-04.patch Optional Tests site git revision trunk / faa38e1 Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7571/console This message was automatically generated.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Jagadesh Kiran N for updating the patch. Looks good to me, +1.

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Jagadesh Kiran N for updating the patch. Looks good to me, +1.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk, branch-2, and branch-2.7. Thanks Jagadesh for the contribution, and thanks Daniel Templeton and Brahma Reddy Battula for reviewing the patches.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk, branch-2, and branch-2.7. Thanks Jagadesh for the contribution, and thanks Daniel Templeton and Brahma Reddy Battula for reviewing the patches.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #8379 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8379/)
          HADOOP-12359. hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4)

          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #8379 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8379/ ) HADOOP-12359 . hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #335 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/335/)
          HADOOP-12359. hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4)

          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #335 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/335/ ) HADOOP-12359 . hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #1062 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1062/)
          HADOOP-12359. hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4)

          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #1062 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1062/ ) HADOOP-12359 . hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #327 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/327/)
          HADOOP-12359. hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #327 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/327/ ) HADOOP-12359 . hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2276 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2276/)
          HADOOP-12359. hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2276 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2276/ ) HADOOP-12359 . hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #319 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/319/)
          HADOOP-12359. hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4)

          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #319 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/319/ ) HADOOP-12359 . hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2258 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2258/)
          HADOOP-12359. hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2258 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2258/ ) HADOOP-12359 . hadoop fs -getmerge doc is wrong. Contributed by Jagadesh Kiran N. (aajisaka: rev 2e251a767427a38ecb6c309ad979feecb29a09f4) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md

            People

            • Assignee:
              jagadesh.kiran Jagadesh Kiran N
              Reporter:
              templedf Daniel Templeton
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development