[HADOOP-12318] Expose underlying LDAP exceptions in SaslPlainServer

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Component/s: security
• Target Version/s: 2.8.0
• Hadoop Flags: Reviewed
• Assignee: Mike Yoder
• Reporter: Mike Yoder
• Created: 12/Aug/15 19:05
• Updated: 30/Aug/16 01:24
• Resolved: 12/Aug/15 22:25

Description

In the code of class SaslPlainServer, the underlying exception is not included in the SaslException, which leads to below error message in HiveServer2:

2015-07-22 11:50:28,433 DEBUG org.apache.thrift.transport.TSaslServerTransport: failed to open server transport
org.apache.thrift.transport.TTransportException: PLAIN auth failed: Error validating LDAP user
	at org.apache.thrift.transport.TSaslTransport.sendAndThrowMessage(TSaslTransport.java:232)
	at org.apache.thrift.transport.TSaslTransport.open(TSaslTransport.java:316)
	at org.apache.thrift.transport.TSaslServerTransport.open(TSaslServerTransport.java:41)
	at org.apache.thrift.transport.TSaslServerTransport$Factory.getTransport(TSaslServerTransport.java:216)
	at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:268)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
	at java.lang.Thread.run(Thread.java:745)

Make COEs very hard to understand what the real error is.

Can we change that line as:

    } catch (Exception e) {
      throw new SaslException("PLAIN auth failed: " + e.getMessage(), e);
    }