Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12313

NPE in JvmPauseMonitor when calling stop() before start()

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Allow stop() before start() completed in JvmPauseMonitor

      Description

      It is observed that after YARN-4019 some tests are failing in TestRMAdminService with null pointer exceptions in build build failure

      unning org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService
      Tests run: 19, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 11.541 sec <<< FAILURE! - in org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService
      testModifyLabelsOnNodesWithDistributedConfigurationDisabled(org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService)  Time elapsed: 0.132 sec  <<< ERROR!
      java.lang.NullPointerException: null
      	at org.apache.hadoop.util.JvmPauseMonitor.stop(JvmPauseMonitor.java:86)
      	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceStop(ResourceManager.java:601)
      	at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
      	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.stopActiveServices(ResourceManager.java:983)
      	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.transitionToStandby(ResourceManager.java:1038)
      	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceStop(ResourceManager.java:1085)
      	at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
      	at org.apache.hadoop.service.AbstractService.close(AbstractService.java:250)
      	at org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testModifyLabelsOnNodesWithDistributedConfigurationDisabled(TestRMAdminService.java:824)
      
      testRemoveClusterNodeLabelsWithDistributedConfigurationEnabled(org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService)  Time elapsed: 0.121 sec  <<< ERROR!
      java.lang.NullPointerException: null
      	at org.apache.hadoop.util.JvmPauseMonitor.stop(JvmPauseMonitor.java:86)
      	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager$RMActiveServices.serviceStop(ResourceManager.java:601)
      	at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
      	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.stopActiveServices(ResourceManager.java:983)
      	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.transitionToStandby(ResourceManager.java:1038)
      	at org.apache.hadoop.yarn.server.resourcemanager.ResourceManager.serviceStop(ResourceManager.java:1085)
      	at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:221)
      	at org.apache.hadoop.service.AbstractService.close(AbstractService.java:250)
      	at org.apache.hadoop.yarn.server.resourcemanager.TestRMAdminService.testRemoveClusterNodeLabelsWithDistributedConfigurationEnabled(TestRMAdminService.java:867)
      
      
      1. HADOOP-12313.2.patch
        2 kB
        Gabor Liptak
      2. HADOOP-12313.3.patch
        1 kB
        Gabor Liptak
      3. YARN-4035.1.patch
        1 kB
        Gabor Liptak

        Issue Links

          Activity

          Hide
          bibinchundatt Bibin A Chundatt added a comment -

          In JvmPauseMonitor monitorThread gets initialized only in RMActiveServices#serviceStart but in testcases we are not starting the same.

          One fix could be JvmPauseMonitor#stop

            public void stop() {
              shouldRun = false;
              if (null != monitorThread) {
                monitorThread.interrupt();
                try {
                  monitorThread.join();
                } catch (InterruptedException e) {
                  Thread.currentThread().interrupt();
                }
              }
            }
          

          Thoughts?

          Show
          bibinchundatt Bibin A Chundatt added a comment - In JvmPauseMonitor monitorThread gets initialized only in RMActiveServices#serviceStart but in testcases we are not starting the same. One fix could be JvmPauseMonitor#stop public void stop() { shouldRun = false ; if ( null != monitorThread) { monitorThread.interrupt(); try { monitorThread.join(); } catch (InterruptedException e) { Thread .currentThread().interrupt(); } } } Thoughts?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 42s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 42s There were no new javac warning messages.
          +1 javadoc 9m 37s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 5s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 21s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 22m 18s Tests failed in hadoop-common.
              61m 38s  



          Reason Tests
          Failed unit tests hadoop.ha.TestZKFailoverController
            hadoop.net.TestNetUtils



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12749428/YARN-4035.1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 8f73bdd
          hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8800/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8800/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-YARN-Build/8800/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 42s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 5s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 53s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 22m 18s Tests failed in hadoop-common.     61m 38s   Reason Tests Failed unit tests hadoop.ha.TestZKFailoverController   hadoop.net.TestNetUtils Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12749428/YARN-4035.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8f73bdd hadoop-common test log https://builds.apache.org/job/PreCommit-YARN-Build/8800/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-YARN-Build/8800/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-YARN-Build/8800/console This message was automatically generated.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          thanks of the patch!!
          One comment, the below code modification is not required right

          +    if (shouldRun) {
          +      monitorThread.start();
          +    }
          
          Show
          rohithsharma Rohith Sharma K S added a comment - thanks of the patch!! One comment, the below code modification is not required right + if (shouldRun) { + monitorThread.start(); + }
          Hide
          djp Junping Du added a comment -

          Thanks Gabor Liptak for working out a patch and Rohith Sharma K S for the comments!
          Instead of adding "if (shouldRun)" to start monitorThread in start(), I think the right thing to do is set "shouldRun = true" in start(), so JvmPauseMonitor could be restarted after stop (or it cannot be restart again).
          In addition, given the patch all happens in hadoop-common-project, I think we should move the JIRA from YARN to HADOOP.

          Show
          djp Junping Du added a comment - Thanks Gabor Liptak for working out a patch and Rohith Sharma K S for the comments! Instead of adding "if (shouldRun)" to start monitorThread in start(), I think the right thing to do is set "shouldRun = true" in start(), so JvmPauseMonitor could be restarted after stop (or it cannot be restart again). In addition, given the patch all happens in hadoop-common-project, I think we should move the JIRA from YARN to HADOOP.
          Hide
          gliptak Gabor Liptak added a comment -

          Rohith Sharma K S That is my attempt to make this "state-friendly" ... If stop() happens before start completed, you would leave a thread behind.

          Junping Du The "proper way" would be to synchronize both start()/stop() (in particular if restart is an expectation). Would you like an updated patch implementing?

          Show
          gliptak Gabor Liptak added a comment - Rohith Sharma K S That is my attempt to make this "state-friendly" ... If stop() happens before start completed, you would leave a thread behind. Junping Du The "proper way" would be to synchronize both start()/stop() (in particular if restart is an expectation). Would you like an updated patch implementing?
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          given the patch all happens in hadoop-common-project, I think we should move the JIRA from YARN to HADOOP.

          make sense, this fix is in Hadoop common, moving to HADOOP common project.

          Show
          rohithsharma Rohith Sharma K S added a comment - given the patch all happens in hadoop-common-project, I think we should move the JIRA from YARN to HADOOP. make sense, this fix is in Hadoop common, moving to HADOOP common project.
          Hide
          rohithsharma Rohith Sharma K S added a comment -

          Assigned to me by mistake, assigned back to Gabor Liptak

          Show
          rohithsharma Rohith Sharma K S added a comment - Assigned to me by mistake, assigned back to Gabor Liptak
          Hide
          djp Junping Du added a comment -

          The "proper way" would be to synchronize both start()/stop() (in particular if restart is an expectation). Would you like an updated patch implementing?

          I am not sure if restart is an expectation at the beginning. But theoretically, any services should be restartable. However, just double checked with other services, like: NodeManager, ResourceManager, etc., it seems like all these services are implemented as one time only service. So I am fine with keeping things like this to conform the same pattern with other services. I will file another separated JIRA to discuss restartable issue unless someone tells me a solid reason on this.
          Based on above comments, we don't need to handle start() after stop() case, so "if (shouldRun)

          { monitorThread.start(); }

          " is not necessary or not sufficient (at least we should log some warn messages). Either way should be fine to me.

          Show
          djp Junping Du added a comment - The "proper way" would be to synchronize both start()/stop() (in particular if restart is an expectation). Would you like an updated patch implementing? I am not sure if restart is an expectation at the beginning. But theoretically, any services should be restartable. However, just double checked with other services, like: NodeManager, ResourceManager, etc., it seems like all these services are implemented as one time only service. So I am fine with keeping things like this to conform the same pattern with other services. I will file another separated JIRA to discuss restartable issue unless someone tells me a solid reason on this. Based on above comments, we don't need to handle start() after stop() case, so "if (shouldRun) { monitorThread.start(); } " is not necessary or not sufficient (at least we should log some warn messages). Either way should be fine to me.
          Hide
          gliptak Gabor Liptak added a comment -

          Junping Du I suggest keeping the if (shouldRun), as it helps in the edge case corrected here (when stop() comes before start() completes during unit tests).

          Show
          gliptak Gabor Liptak added a comment - Junping Du I suggest keeping the if (shouldRun), as it helps in the edge case corrected here (when stop() comes before start() completes during unit tests).
          Hide
          djp Junping Du added a comment -

          I suggest keeping the if (shouldRun), as it helps in the edge case corrected here (when stop() comes before start() completes during unit tests)

          If so, please add a warn message or user have not hints if it get started or not.

          Show
          djp Junping Du added a comment - I suggest keeping the if (shouldRun), as it helps in the edge case corrected here (when stop() comes before start() completes during unit tests) If so, please add a warn message or user have not hints if it get started or not.
          Hide
          gliptak Gabor Liptak added a comment -

          Added warn message.

          Show
          gliptak Gabor Liptak added a comment - Added warn message.
          Hide
          djp Junping Du added a comment -

          Latest patch LGTM. +1 pending on Jenkins result.

          Show
          djp Junping Du added a comment - Latest patch LGTM. +1 pending on Jenkins result.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 0s The patch command could not apply the patch during dryrun.



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12750008/HADOOP-12313.2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1c12adb
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7450/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750008/HADOOP-12313.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1c12adb Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7450/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 0s The patch command could not apply the patch during dryrun.



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12750008/HADOOP-12313.2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 1c12adb
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7451/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750008/HADOOP-12313.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 1c12adb Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7451/console This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          There are seems to be problem with Jenkins test against Hadoop Common Project. Filed INFRA-10111 to track that.

          Show
          djp Junping Du added a comment - There are seems to be problem with Jenkins test against Hadoop Common Project. Filed INFRA-10111 to track that.
          Hide
          jianhe Jian He added a comment -

          Gabor Liptak, this patch got conflicted with YARN-3999 which just got committed. would you mind rebasing on that.

          Show
          jianhe Jian He added a comment - Gabor Liptak , this patch got conflicted with YARN-3999 which just got committed. would you mind rebasing on that.
          Hide
          gliptak Gabor Liptak added a comment -

          Uploaded rebased patch.

          Show
          gliptak Gabor Liptak added a comment - Uploaded rebased patch.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 46s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 45s There were no new javac warning messages.
          +1 javadoc 9m 45s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 8s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 22s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 22m 37s Tests failed in hadoop-common.
              62m 15s  



          Reason Tests
          Failed unit tests hadoop.net.TestNetUtils
            hadoop.security.token.delegation.web.TestWebDelegationToken
            hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12750170/HADOOP-12313.3.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 820f864
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7455/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7455/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7455/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 46s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 45s There were no new javac warning messages. +1 javadoc 9m 45s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 8s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 22s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 22m 37s Tests failed in hadoop-common.     62m 15s   Reason Tests Failed unit tests hadoop.net.TestNetUtils   hadoop.security.token.delegation.web.TestWebDelegationToken   hadoop.ha.TestZKFailoverController Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12750170/HADOOP-12313.3.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 820f864 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7455/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7455/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7455/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          why not make JvmPauseMonitor a subclass of ActiveService, so getting the lifecycle and non-reentrant serviceStop calls? It'd also make it trivial to deploy under any instance of CompositeService, so avoid needing any specific hooks in any service class planning to use it.

          Show
          stevel@apache.org Steve Loughran added a comment - why not make JvmPauseMonitor a subclass of ActiveService, so getting the lifecycle and non-reentrant serviceStop calls? It'd also make it trivial to deploy under any instance of CompositeService, so avoid needing any specific hooks in any service class planning to use it.
          Hide
          kasha Karthik Kambatla added a comment -

          I believe I created a JIRA long time ago to allow for pause/resume or stop/start semantics for services. Any takers?

          Show
          kasha Karthik Kambatla added a comment - I believe I created a JIRA long time ago to allow for pause/resume or stop/start semantics for services. Any takers?
          Hide
          gliptak Gabor Liptak added a comment -

          I created HADOOP-12320 yesterday (which might be a duplicate as per Karthik Kambatla

          Steve Loughran Would you see this being worked under this Jira or the new "improvement" one?

          Show
          gliptak Gabor Liptak added a comment - I created HADOOP-12320 yesterday (which might be a duplicate as per Karthik Kambatla Steve Loughran Would you see this being worked under this Jira or the new "improvement" one?
          Hide
          rkanter Robert Kanter added a comment -

          Let's fix the NPE in this JIRA, use HADOOP-12321 to make JvmPauseMonitor a Service, and use HADOOP-12320 to discuss making Services restartable in general.

          Show
          rkanter Robert Kanter added a comment - Let's fix the NPE in this JIRA, use HADOOP-12321 to make JvmPauseMonitor a Service, and use HADOOP-12320 to discuss making Services restartable in general.
          Hide
          wheat9 Haohui Mai added a comment -

          +1. Committing.

          Show
          wheat9 Haohui Mai added a comment - +1. Committing.
          Hide
          wheat9 Haohui Mai added a comment -

          I've committed the patch to trunk and branch-2. Thanks Gabor Liptak for the contribution.

          Show
          wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Gabor Liptak for the contribution.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8858 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8858/)
          HADOOP-12313. NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8858 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8858/ ) HADOOP-12313 . NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #701 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/701/)
          HADOOP-12313. NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #701 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/701/ ) HADOOP-12313 . NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2642 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2642/)
          HADOOP-12313. NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2642 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2642/ ) HADOOP-12313 . NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 55s trunk passed
          +1 compile 9m 41s trunk passed with JDK v1.8.0_66
          +1 compile 10m 6s trunk passed with JDK v1.7.0_85
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 1m 10s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          -1 findbugs 2m 6s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 1m 2s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 16s trunk passed with JDK v1.7.0_85
          +1 mvninstall 1m 45s the patch passed
          +1 compile 9m 59s the patch passed with JDK v1.8.0_66
          +1 javac 9m 59s the patch passed
          +1 compile 10m 23s the patch passed with JDK v1.7.0_85
          +1 javac 10m 23s the patch passed
          +1 checkstyle 0m 19s the patch passed
          +1 mvnsite 1m 13s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 20s the patch passed
          +1 javadoc 1m 5s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 9s the patch passed with JDK v1.7.0_85
          -1 unit 7m 59s hadoop-common in the patch failed with JDK v1.8.0_66.
          -1 unit 8m 12s hadoop-common in the patch failed with JDK v1.7.0_85.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          81m 8s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.fs.permission.TestFsPermission
            hadoop.fs.shell.TestCopyPreserveFlag
            hadoop.io.compress.TestCompressorDecompressor
          JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor
          JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission
            hadoop.io.compress.TestCompressorDecompressor
          JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12750170/HADOOP-12313.3.patch
          JIRA Issue HADOOP-12313
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 609eb72c5639 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8228697
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt
          JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 75MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 55s trunk passed +1 compile 9m 41s trunk passed with JDK v1.8.0_66 +1 compile 10m 6s trunk passed with JDK v1.7.0_85 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 10s trunk passed +1 mvneclipse 0m 15s trunk passed -1 findbugs 2m 6s hadoop-common-project/hadoop-common in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 2s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 16s trunk passed with JDK v1.7.0_85 +1 mvninstall 1m 45s the patch passed +1 compile 9m 59s the patch passed with JDK v1.8.0_66 +1 javac 9m 59s the patch passed +1 compile 10m 23s the patch passed with JDK v1.7.0_85 +1 javac 10m 23s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 1m 13s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 20s the patch passed +1 javadoc 1m 5s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 9s the patch passed with JDK v1.7.0_85 -1 unit 7m 59s hadoop-common in the patch failed with JDK v1.8.0_66. -1 unit 8m 12s hadoop-common in the patch failed with JDK v1.7.0_85. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 81m 8s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.fs.permission.TestFsPermission   hadoop.fs.shell.TestCopyPreserveFlag   hadoop.io.compress.TestCompressorDecompressor JDK v1.8.0_66 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor JDK v1.7.0_85 Failed junit tests hadoop.fs.permission.TestFsPermission   hadoop.io.compress.TestCompressorDecompressor JDK v1.7.0_85 Timed out junit tests org.apache.hadoop.io.compress.lz4.TestLz4CompressorDecompressor Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12750170/HADOOP-12313.3.patch JIRA Issue HADOOP-12313 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 609eb72c5639 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8228697 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-common-warnings.html unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_85.txt JDK v1.7.0_85 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8134/console This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #712 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/712/)
          HADOOP-12313. NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #712 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/712/ ) HADOOP-12313 . NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1436 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1436/)
          HADOOP-12313. NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1436 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1436/ ) HADOOP-12313 . NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          stevel@apache.org Steve Loughran added a comment -

          although its nice to have a fix, I'm testing HADOOP-12321 for a broader one ... it relies on the yarn service model for a strict state machine & won't won't do things like permit calls to start twice spawning off a thread again, etc.

          Show
          stevel@apache.org Steve Loughran added a comment - although its nice to have a fix, I'm testing HADOOP-12321 for a broader one ... it relies on the yarn service model for a strict state machine & won't won't do things like permit calls to start twice spawning off a thread again, etc.
          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #630 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/630/)
          HADOOP-12313. NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Hadoop-Hdfs-trunk-Java8 #630 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/630/ ) HADOOP-12313 . NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2569 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2569/)
          HADOOP-12313. NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2569 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2569/ ) HADOOP-12313 . NPE in JvmPauseMonitor when calling stop() before start(). (wheat9: rev 817ae221ac1ca8552748f6310d29ea1b26b5a21b) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/JvmPauseMonitor.java hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              gliptak Gabor Liptak
              Reporter:
              rohithsharma Rohith Sharma K S
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development