[HADOOP-12206] The preceding invocations of findlargest in test-patch effect the following invocation results

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: HADOOP-12111
• Fix Version/s: HADOOP-12111
• Component/s: yetus
• Labels: newbie
• Assignee: Kengo Seki
• Reporter: Kengo Seki
• Created: 08/Jul/15 06:58
• Updated: 10/Jul/15 15:27
• Resolved: 10/Jul/15 15:27

Description

Because $maxlen is not defined as a local variable, the preceding invocations effect the following results.

function findlargest
{
  local column=$1
  shift
  local a=("$@")
  local sizeofa=${#a[@]}
  local i=0

  until [[ ${i} -gt ${sizeofa} ]]; do
    # shellcheck disable=SC2086
    string=$( echo ${a[$i]} | cut -f$((column + 1)) -d\| )
    if [[ ${#string} -gt $maxlen ]]; then
      maxlen=${#string}
    fi
    i=$((i+1))
  done
  echo "${maxlen}"
}

Also,

until [[ ${i} -gt ${sizeofa} ]]; do

should be -eq or -ge.