Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: native
    • Labels:
      None
    • Environment:

      Solaris

    • Target Version/s:

      Description

      The POSIX subclass in NativeIO contains the following constants that are not defined in POSIX:

      O_ASYNC, O_FSYNC, O_NDELAY

      Stat.S_IFWHT

      These constants are not used within Hadoop, as far as I could tell. As they are not part of the POSIX specification, they should be removed as part of an effort to create portable code.

        Issue Links

          Activity

          Hide
          martinw Martin Walsh added a comment -

          Patch attached and ready for review

          Show
          martinw Martin Walsh added a comment - Patch attached and ready for review
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 29s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 36s There were no new javac warning messages.
          +1 javadoc 9m 37s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 6s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 20s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 43s Tests passed in hadoop-common.
              61m 41s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12744466/HADOOP-12184.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / d66302e
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7227/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7227/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7227/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 29s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 36s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 6s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 43s Tests passed in hadoop-common.     61m 41s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12744466/HADOOP-12184.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / d66302e hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7227/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7227/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7227/console This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          If they are unused, let's removed them. +1.

          Show
          cmccabe Colin P. McCabe added a comment - If they are unused, let's removed them. +1.
          Hide
          cmccabe Colin P. McCabe added a comment -

          committed to 2.8, thanks!

          Show
          cmccabe Colin P. McCabe added a comment - committed to 2.8, thanks!
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8201 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8201/)
          HADOOP-12184. Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8201 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8201/ ) HADOOP-12184 . Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #995 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/995/)
          HADOOP-12184. Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #995 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/995/ ) HADOOP-12184 . Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #265 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/265/)
          HADOOP-12184. Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #265 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/265/ ) HADOOP-12184 . Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2192 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2192/)
          HADOOP-12184. Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2192 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2192/ ) HADOOP-12184 . Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #254 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/254/)
          HADOOP-12184. Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #254 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/254/ ) HADOOP-12184 . Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #262 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/262/)
          HADOOP-12184. Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #262 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/262/ ) HADOOP-12184 . Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2211/)
          HADOOP-12184. Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2211/ ) HADOOP-12184 . Remove unused Linux-specific constants in NativeIO (Martin Walsh via Colin P. McCabe) (cmccabe: rev 1b3bceb58c8e536a75fa3f99cc3ceeaba91a07de) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              martinw Martin Walsh
              Reporter:
              martinw Martin Walsh
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development