Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12183

Annotate the HTrace span created by FsShell with the command-line arguments passed by the user

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: tracing
    • Labels:
      None
    • Target Version/s:

      Description

      Tracing span of FsShell contains only command name as its description. Adding whole command line arguments as KV annotation to span helps analyze traces later.

      1. HADOOP-12183.001.patch
        2 kB
        Masatake Iwasaki
      2. HADOOP-12183.002.patch
        2 kB
        Masatake Iwasaki

        Issue Links

          Activity

          Hide
          cmccabe Colin P. McCabe added a comment -

          Good idea,

          Show
          cmccabe Colin P. McCabe added a comment - Good idea,
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 22s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 40s There were no new javac warning messages.
          +1 javadoc 9m 36s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 5s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 20s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 24s Tests passed in hadoop-common.
              61m 15s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12747747/HADOOP-12183.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 2a1d656
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7358/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7358/testReport/
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7358/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 22s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 40s There were no new javac warning messages. +1 javadoc 9m 36s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 5s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 24s Tests passed in hadoop-common.     61m 15s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12747747/HADOOP-12183.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2a1d656 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7358/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7358/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7358/console This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Looks good! Can we add a sanity check that the string is not too long. For example, scope.getSpan().addKVAnnotation("args", StringUtils.join(" ", argv).substring(0, 2048). That way if some bizarrely long command line comes along, we won't create a huge trace span.

          Show
          cmccabe Colin P. McCabe added a comment - Looks good! Can we add a sanity check that the string is not too long. For example, scope.getSpan().addKVAnnotation("args", StringUtils.join(" ", argv).substring(0, 2048) . That way if some bizarrely long command line comes along, we won't create a huge trace span.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Can we add a sanity check that the string is not too long.

          Sure. I think 2048 is reasonable upper limit. Thanks for the comment. I am attaching 002.

          Show
          iwasakims Masatake Iwasaki added a comment - Can we add a sanity check that the string is not too long. Sure. I think 2048 is reasonable upper limit. Thanks for the comment. I am attaching 002.
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1 pending jenkins. Thanks, Masatake Iwasaki.

          Show
          cmccabe Colin P. McCabe added a comment - +1 pending jenkins. Thanks, Masatake Iwasaki .
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 42s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 41s There were no new javac warning messages.
          +1 javadoc 9m 47s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 4s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 20s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 21m 35s Tests failed in hadoop-common.
              60m 56s  



          Reason Tests
          Failed unit tests hadoop.fs.sftp.TestSFTPFileSystem



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12748066/HADOOP-12183.002.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 88d8736
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7378/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7378/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7378/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 42s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 41s There were no new javac warning messages. +1 javadoc 9m 47s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 20s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 21m 35s Tests failed in hadoop-common.     60m 56s   Reason Tests Failed unit tests hadoop.fs.sftp.TestSFTPFileSystem Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12748066/HADOOP-12183.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 88d8736 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7378/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7378/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7378/console This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          Test failure in TestSFTPFileSystem is not related to this, since it doesn't change SFTP. +1. Thanks, Masatake Iwasaki. Committed to 2.8

          Show
          cmccabe Colin P. McCabe added a comment - Test failure in TestSFTPFileSystem is not related to this, since it doesn't change SFTP. +1. Thanks, Masatake Iwasaki . Committed to 2.8
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #8253 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8253/)
          HADOOP-12183. Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8253 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8253/ ) HADOOP-12183 . Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks, Colin P. McCabe!

          Show
          iwasakims Masatake Iwasaki added a comment - Thanks, Colin P. McCabe !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #1004 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1004/)
          HADOOP-12183. Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #1004 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/1004/ ) HADOOP-12183 . Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #274 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/274/)
          HADOOP-12183. Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #274 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/274/ ) HADOOP-12183 . Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2220 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2220/)
          HADOOP-12183. Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2220 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2220/ ) HADOOP-12183 . Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2201 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2201/)
          HADOOP-12183. Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2201 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2201/ ) HADOOP-12183 . Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/263/)
          HADOOP-12183. Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #263 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/263/ ) HADOOP-12183 . Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #271 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/271/)
          HADOOP-12183. Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #271 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/271/ ) HADOOP-12183 . Annotate the HTrace span created by FsShell with the command-line arguments passed by the user (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 454da959c726528ac98dbca1b935a83ed4b9e235) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFsShell.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FsShell.java hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              iwasakims Masatake Iwasaki
              Reporter:
              iwasakims Masatake Iwasaki
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development