Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12151

Enforce Checkstyle validation in build

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      Checksyle usage in Hadoop project https://github.com/apache/hadoop/blob/trunk/hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml

      but latest sources generate about 200 errors by command "mvn clean compile checkstyle:check"

      If Hadoop team fix all errors(warnings are not considered for now) Chekstyle team will put Hadoop project to Checkstyle regression testing,
      that will ensure no regressions on each commit to Checkstyle against Hadoop sources.

      Both of our project will benefit from that.

      from Allen Wittenauer:
      Yup. While Hadoop has had checkstyle enabled for a very long time, it’s pretty much been ignored until recently when we integrated it with our pre-patch checks.

      Thank you for the offer! It is much appreciated!
      There’s no doubt this would be a benefit to both teams and it would be tremendous to be part of the checkstyle regression testing. Realistically, however, unless someone from the community steps up to make it a priority to fix the issues, we’ll likely remain broken for a while.

      Attachments

        Activity

          People

            Unassigned Unassigned
            romani Roman Ivanov
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated: