Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12117

Potential NPE from Configuration#loadProperty with allowNullValueProperties set.

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: conf
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Potential NPE from Configuration#loadProperty with allowNullValueProperties set.
      The following code will cause NPE:

      } else if (!value.equals(properties.getProperty(attr))) {
      

      Because if allowNullValueProperties is true, value is null and finalParameters contains attr, NullPointerException will happen

      1. HADOOP-12117.000.patch
        3 kB
        zhihai xu
      2. HADOOP-12117.001.patch
        3 kB
        zhihai xu
      3. HADOOP-12117.002.patch
        3 kB
        zhihai xu

        Activity

        Hide
        zxu zhihai xu added a comment -

        Without the fix, the test will fail with the following exception:

        -------------------------------------------------------
         T E S T S
        -------------------------------------------------------
        Running org.apache.hadoop.conf.TestConfiguration
        Tests run: 62, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 27.865 sec <<< FAILURE! - in org.apache.hadoop.conf.TestConfiguration
        testLoadProperty(org.apache.hadoop.conf.TestConfiguration)  Time elapsed: 0.007 sec  <<< ERROR!
        java.lang.NullPointerException: null
        	at org.apache.hadoop.conf.Configuration.loadProperty(Configuration.java:2750)
        	at org.apache.hadoop.conf.TestConfiguration.testLoadProperty(TestConfiguration.java:1520)
        Results :
        Tests in error: 
          TestConfiguration.testLoadProperty:1520 » NullPointer
        Tests run: 62, Failures: 0, Errors: 1, Skipped: 0
        
        Show
        zxu zhihai xu added a comment - Without the fix, the test will fail with the following exception: ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.conf.TestConfiguration Tests run: 62, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 27.865 sec <<< FAILURE! - in org.apache.hadoop.conf.TestConfiguration testLoadProperty(org.apache.hadoop.conf.TestConfiguration) Time elapsed: 0.007 sec <<< ERROR! java.lang.NullPointerException: null at org.apache.hadoop.conf.Configuration.loadProperty(Configuration.java:2750) at org.apache.hadoop.conf.TestConfiguration.testLoadProperty(TestConfiguration.java:1520) Results : Tests in error: TestConfiguration.testLoadProperty:1520 » NullPointer Tests run: 62, Failures: 0, Errors: 1, Skipped: 0
        Hide
        zxu zhihai xu added a comment -

        I uploaded a patch HADOOP-12117.000.patch for review, the patch will set value before access it and also checking allowNullValueProperties is not necessary inside if statement, because allowNullValueProperties will guarantee being true if value is null.

        Show
        zxu zhihai xu added a comment - I uploaded a patch HADOOP-12117 .000.patch for review, the patch will set value before access it and also checking allowNullValueProperties is not necessary inside if statement, because allowNullValueProperties will guarantee being true if value is null.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 40s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 38s There were no new javac warning messages.
        +1 javadoc 9m 46s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 176, now 176).
        +1 whitespace 0m 1s The patch has no lines that end in whitespace.
        +1 install 1m 36s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 21s Tests passed in hadoop-common.
            61m 55s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741688/HADOOP-12117.000.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 2236b57
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7032/artifact/patchprocess/diffcheckstylehadoop-common.txt
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7032/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7032/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7032/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 40s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 38s There were no new javac warning messages. +1 javadoc 9m 46s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 176, now 176). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 21s Tests passed in hadoop-common.     61m 55s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741688/HADOOP-12117.000.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 2236b57 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7032/artifact/patchprocess/diffcheckstylehadoop-common.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7032/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7032/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7032/console This message was automatically generated.
        Hide
        zxu zhihai xu added a comment -

        The checkstyle issue is not related to my change.

        ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:1: File length is 3,033 lines (max allowed is 2,000).
        
        Show
        zxu zhihai xu added a comment - The checkstyle issue is not related to my change. ./hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java:1: File length is 3,033 lines (max allowed is 2,000).
        Hide
        raviprak Ravi Prakash added a comment -

        Thanks for the contribution Zhihai! setAllowNullValueProperties seems to have been added to support unit test cases downstream. Is there a unit test case you can point me to which is causing this?

        I'd be wary of opening up the access level of a Configuration method (even if it is labeled @VisibleForTesting) . Are you sure we can't unit test without changing the access level?
        Also please log the exception in testLoadProperty().

        Show
        raviprak Ravi Prakash added a comment - Thanks for the contribution Zhihai! setAllowNullValueProperties seems to have been added to support unit test cases downstream. Is there a unit test case you can point me to which is causing this? I'd be wary of opening up the access level of a Configuration method (even if it is labeled @VisibleForTesting) . Are you sure we can't unit test without changing the access level? Also please log the exception in testLoadProperty().
        Hide
        zxu zhihai xu added a comment -

        Hi Ravi Prakash, thanks for the review! The current unit tests don't trigger this issue.

        I'd be wary of opening up the access level of a Configuration method (even if it is labeled @VisibleForTesting) . Are you sure we can't unit test without changing the access level? Also please log the exception in testLoadProperty().

        Good suggestions! fixed in the new patch.
        I uploaded a new patch HADOOP-12117.001.patch, which addressed all your comments, please review it.

        Show
        zxu zhihai xu added a comment - Hi Ravi Prakash , thanks for the review! The current unit tests don't trigger this issue. I'd be wary of opening up the access level of a Configuration method (even if it is labeled @VisibleForTesting) . Are you sure we can't unit test without changing the access level? Also please log the exception in testLoadProperty(). Good suggestions! fixed in the new patch. I uploaded a new patch HADOOP-12117 .001.patch, which addressed all your comments, please review it.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 25s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 33s There were no new javac warning messages.
        +1 javadoc 9m 42s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 2s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 35s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 17s Tests passed in hadoop-common.
            61m 26s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12742044/HADOOP-12117.001.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / 8ef07f7
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7049/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7049/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7049/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 25s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 33s There were no new javac warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 2s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 35s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 52s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 17s Tests passed in hadoop-common.     61m 26s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12742044/HADOOP-12117.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 8ef07f7 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7049/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7049/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7049/console This message was automatically generated.
        Hide
        zxu zhihai xu added a comment -

        As Ravi Prakash said, since setAllowNullValueProperties was added to support unit test cases downstream, I change the issue to minor from major. Ravi, Is the latest patch ok for you?

        Show
        zxu zhihai xu added a comment - As Ravi Prakash said, since setAllowNullValueProperties was added to support unit test cases downstream, I change the issue to minor from major. Ravi, Is the latest patch ok for you?
        Hide
        zxu zhihai xu added a comment -

        Hi Ravi Prakash, Do you have time to review the patch? If you don't mind, I will ask other people to review the patch. thanks

        Show
        zxu zhihai xu added a comment - Hi Ravi Prakash , Do you have time to review the patch? If you don't mind, I will ask other people to review the patch. thanks
        Hide
        vinayrpet Vinayakumar B added a comment -

        Hi zhihai xu,
        I have one nit in test.

        No need to catch Exception and then fail. Let it fail directly with NPE.

        Otherwise +1.

        Show
        vinayrpet Vinayakumar B added a comment - Hi zhihai xu , I have one nit in test. No need to catch Exception and then fail. Let it fail directly with NPE. Otherwise +1.
        Hide
        zxu zhihai xu added a comment -

        Thanks Vinayakumar B for the review, I uploaded a new patch HADOOP-12117.002.patch which addressed your comment. Please review it.

        Show
        zxu zhihai xu added a comment - Thanks Vinayakumar B for the review, I uploaded a new patch HADOOP-12117 .002.patch which addressed your comment. Please review it.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 16m 29s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
        +1 javac 7m 37s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 1m 6s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 33s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 12s Tests passed in hadoop-common.
            61m 24s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12743763/HADOOP-12117.002.patch
        Optional Tests javadoc javac unit findbugs checkstyle
        git revision trunk / fc92d3e
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7163/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7163/testReport/
        Java 1.7.0_55
        uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7163/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 29s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 37s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 6s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 12s Tests passed in hadoop-common.     61m 24s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12743763/HADOOP-12117.002.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / fc92d3e hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7163/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7163/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7163/console This message was automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk and branch-2.
        Thanks zhihai xu for the contribution.
        Thanks Ravi Prakash for the participation.

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks zhihai xu for the contribution. Thanks Ravi Prakash for the participation.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8122 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8122/)
        HADOOP-12117. Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8122 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8122/ ) HADOOP-12117 . Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #247 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/247/)
        HADOOP-12117. Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #247 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/247/ ) HADOOP-12117 . Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2195 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2195/)
        HADOOP-12117. Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2195 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2195/ ) HADOOP-12117 . Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2176/)
        HADOOP-12117. Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2176/ ) HADOOP-12117 . Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #237 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/237/)
        HADOOP-12117. Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #237 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/237/ ) HADOOP-12117 . Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        Hide
        zxu zhihai xu added a comment -

        thanks Ravi Prakash for the review! thanks Vinayakumar B for the review and committing the patch!

        Show
        zxu zhihai xu added a comment - thanks Ravi Prakash for the review! thanks Vinayakumar B for the review and committing the patch!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #250 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/250/)
        HADOOP-12117. Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #250 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/250/ ) HADOOP-12117 . Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #980 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/980/)
        HADOOP-12117. Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #980 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/980/ ) HADOOP-12117 . Potential NPE from Configuration#loadProperty with allowNullValueProperties set. (Contributed by zhihai xu) (vinayakumarb: rev 99c8c5839b65666e6099116e4d7024e0eb4682b9) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfiguration.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java

          People

          • Assignee:
            zxu zhihai xu
            Reporter:
            zxu zhihai xu
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development