Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11985 Improve Solaris support in Hadoop
  3. HADOOP-12112

Make hadoop-common-project Native code -Wall-clean

        Details

        • Type: Sub-task
        • Status: Resolved
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 2.7.0
        • Fix Version/s: 2.8.0, 3.0.0-alpha1
        • Component/s: native
        • Labels:
          None

          Description

          As we specify -Wall as a default compilation flag, it would be helpful if the Native code was -Wall-clean

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            alanburlison Alan Burlison added a comment -

            Patch attached

            Show
            alanburlison Alan Burlison added a comment - Patch attached
            Hide
            Permalink
            cmccabe Colin P. McCabe added a comment -

            +1 pending jenkins

            Don't forget to hit submit patch to get a jenkins run on these. I will hit it now

            Show
            cmccabe Colin P. McCabe added a comment - +1 pending jenkins Don't forget to hit submit patch to get a jenkins run on these. I will hit it now
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -



            -1 overall



            Vote Subsystem Runtime Comment
            0 pre-patch 5m 20s Pre-patch trunk compilation is healthy.
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
            +1 javac 7m 37s There were no new javac warning messages.
            +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
            +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            +1 install 1m 34s mvn install still works.
            +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
            +1 common tests 22m 9s Tests passed in hadoop-common.
                37m 35s  



            Subsystem Report/Notes
            Patch URL http://issues.apache.org/jira/secure/attachment/12741628/HADOOP-12112.001.patch
            Optional Tests javac unit
            git revision trunk / aa07dea
            hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7058/artifact/patchprocess/testrun_hadoop-common.txt
            Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7058/testReport/
            Java 1.7.0_55
            uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
            Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7058/console

            This message was automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 20s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 37s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 common tests 22m 9s Tests passed in hadoop-common.     37m 35s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741628/HADOOP-12112.001.patch Optional Tests javac unit git revision trunk / aa07dea hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7058/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7058/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7058/console This message was automatically generated.
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-trunk-Commit #8087 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8087/)
            HADOOP-12112. Make hadoop-common-project Native code -Wall-clean (alanburlison via cmccabe) (cmccabe: rev fad291ea6dbe49782e33a32cd6608088951e2c58)

            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCrc32.c
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8087 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8087/ ) HADOOP-12112 . Make hadoop-common-project Native code -Wall-clean (alanburlison via cmccabe) (cmccabe: rev fad291ea6dbe49782e33a32cd6608088951e2c58) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCrc32.c hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/)
            HADOOP-12112. Make hadoop-common-project Native code -Wall-clean (alanburlison via cmccabe) (cmccabe: rev fad291ea6dbe49782e33a32cd6608088951e2c58)

            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCrc32.c
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/ ) HADOOP-12112 . Make hadoop-common-project Native code -Wall-clean (alanburlison via cmccabe) (cmccabe: rev fad291ea6dbe49782e33a32cd6608088951e2c58) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCrc32.c hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/)
            HADOOP-12112. Make hadoop-common-project Native code -Wall-clean (alanburlison via cmccabe) (cmccabe: rev fad291ea6dbe49782e33a32cd6608088951e2c58)

            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCrc32.c
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/ ) HADOOP-12112 . Make hadoop-common-project Native code -Wall-clean (alanburlison via cmccabe) (cmccabe: rev fad291ea6dbe49782e33a32cd6608088951e2c58) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCrc32.c hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/)
            HADOOP-12112. Make hadoop-common-project Native code -Wall-clean (alanburlison via cmccabe) (cmccabe: rev fad291ea6dbe49782e33a32cd6608088951e2c58)

            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCrc32.c
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
            • hadoop-common-project/hadoop-common/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/ ) HADOOP-12112 . Make hadoop-common-project Native code -Wall-clean (alanburlison via cmccabe) (cmccabe: rev fad291ea6dbe49782e33a32cd6608088951e2c58) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCrc32.c hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c hadoop-common-project/hadoop-common/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/)
            HADOOP-12112. Make hadoop-common-project Native code -Wall-clean (alanburlison via cmccabe) (cmccabe: rev fad291ea6dbe49782e33a32cd6608088951e2c58)

            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
            • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCrc32.c
            • hadoop-common-project/hadoop-common/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/ ) HADOOP-12112 . Make hadoop-common-project Native code -Wall-clean (alanburlison via cmccabe) (cmccabe: rev fad291ea6dbe49782e33a32cd6608088951e2c58) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/io/nativeio/NativeIO.c hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/util/NativeCrc32.c hadoop-common-project/hadoop-common/CHANGES.txt

              People

              • Assignee:
                alanburlison Alan Burlison
                Reporter:
                alanburlison Alan Burlison
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development