Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12101

Add automatic search of default Configuration variables to TestConfigurationFieldsBase

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Add functionality given a Configuration variable FOO, to at least check the xml file value against DEFAULT_FOO.

      Without waivers and a mapping for exceptions, this can probably never be a test method that generates actual errors.

      1. HADOOP-12101.016.patch
        16 kB
        Ray Chiang
      2. HADOOP-12101.015.patch
        16 kB
        Ray Chiang
      3. HADOOP-12101.014.patch
        16 kB
        Ray Chiang
      4. HADOOP-12101.013.patch
        16 kB
        Ray Chiang
      5. HADOOP-12101.012.patch
        16 kB
        Ray Chiang
      6. HADOOP-12101.011.patch
        16 kB
        Ray Chiang
      7. HADOOP-12101.010.patch
        16 kB
        Ray Chiang
      8. HADOOP-12101.009.patch
        15 kB
        Ray Chiang
      9. HADOOP-12101.008.patch
        15 kB
        Ray Chiang
      10. HADOOP-12101.007.patch
        15 kB
        Ray Chiang
      11. HADOOP-12101.006.patch
        15 kB
        Ray Chiang
      12. HADOOP-12101.005.patch
        15 kB
        Ray Chiang
      13. HADOOP-12101.004.patch
        15 kB
        Ray Chiang
      14. HADOOP-12101.003.patch
        11 kB
        Ray Chiang
      15. HADOOP-12101.002.patch
        15 kB
        Ray Chiang
      16. HADOOP-12101.001.patch
        10 kB
        Ray Chiang

        Issue Links

          Activity

          Hide
          rchiang Ray Chiang added a comment -

          Thanks for the review and the commit Masatake Iwasaki!

          Show
          rchiang Ray Chiang added a comment - Thanks for the review and the commit Masatake Iwasaki !
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Committed. Thanks, Ray Chiang!

          Show
          iwasakims Masatake Iwasaki added a comment - Committed. Thanks, Ray Chiang !
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9711 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9711/)
          HADOOP-12101. Add automatic search of default Configuration variables to (iwasakims: rev 355325bcc7111fa4aac801fd23a26422ffabaf7c)

          • dev-support/verify-xml.sh
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationFieldsBase.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9711 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9711/ ) HADOOP-12101 . Add automatic search of default Configuration variables to (iwasakims: rev 355325bcc7111fa4aac801fd23a26422ffabaf7c) dev-support/verify-xml.sh hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/conf/TestConfigurationFieldsBase.java
          Hide
          iwasakims Masatake Iwasaki added a comment -

          +1, committing this.

          Show
          iwasakims Masatake Iwasaki added a comment - +1, committing this.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          0 shelldocs 0m 6s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 50s trunk passed
          +1 compile 6m 4s trunk passed with JDK v1.8.0_92
          +1 compile 6m 36s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 1m 37s trunk passed
          +1 javadoc 0m 57s trunk passed with JDK v1.8.0_92
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 42s the patch passed
          +1 compile 5m 40s the patch passed with JDK v1.8.0_92
          +1 javac 5m 40s the patch passed
          +1 compile 6m 37s the patch passed with JDK v1.7.0_95
          +1 javac 6m 37s the patch passed
          +1 checkstyle 0m 23s the patch passed
          +1 mvnsite 0m 59s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          +1 shellcheck 0m 10s There were no new shellcheck issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 53s the patch passed
          +1 javadoc 0m 59s the patch passed with JDK v1.8.0_92
          +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95
          -1 unit 17m 7s hadoop-common in the patch failed with JDK v1.8.0_92.
          +1 unit 9m 35s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          72m 23s



          Reason Tests
          JDK v1.8.0_92 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801968/HADOOP-12101.016.patch
          JIRA Issue HADOOP-12101
          Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 5f1451e135df 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 06413da
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          shellcheck v0.4.3
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9259/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9259/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9259/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9259/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. 0 shelldocs 0m 6s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 50s trunk passed +1 compile 6m 4s trunk passed with JDK v1.8.0_92 +1 compile 6m 36s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 37s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_92 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 5m 40s the patch passed with JDK v1.8.0_92 +1 javac 5m 40s the patch passed +1 compile 6m 37s the patch passed with JDK v1.7.0_95 +1 javac 6m 37s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 59s the patch passed +1 mvneclipse 0m 17s the patch passed +1 shellcheck 0m 10s There were no new shellcheck issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 53s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_92 +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95 -1 unit 17m 7s hadoop-common in the patch failed with JDK v1.8.0_92. +1 unit 9m 35s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 72m 23s Reason Tests JDK v1.8.0_92 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801968/HADOOP-12101.016.patch JIRA Issue HADOOP-12101 Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle uname Linux 5f1451e135df 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 06413da Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_92 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 shellcheck v0.4.3 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9259/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9259/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_92.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9259/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9259/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • More shellcheck cleanup
          Show
          rchiang Ray Chiang added a comment - More shellcheck cleanup
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
          0 shelldocs 0m 4s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 9s trunk passed
          +1 compile 6m 6s trunk passed with JDK v1.8.0_91
          +1 compile 6m 49s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 1m 4s trunk passed
          +1 mvneclipse 0m 18s trunk passed
          +1 findbugs 1m 39s trunk passed
          +1 javadoc 0m 59s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 43s the patch passed
          +1 compile 6m 4s the patch passed with JDK v1.8.0_91
          +1 javac 6m 4s the patch passed
          +1 compile 6m 52s the patch passed with JDK v1.7.0_95
          +1 javac 6m 52s the patch passed
          +1 checkstyle 0m 24s the patch passed
          +1 mvnsite 1m 0s the patch passed
          +1 mvneclipse 0m 17s the patch passed
          -1 shellcheck 0m 10s The patch generated 12 new + 96 unchanged - 0 fixed = 108 total (was 96)
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 53s the patch passed
          +1 javadoc 0m 57s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95
          -1 unit 13m 53s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 8m 58s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          69m 49s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801854/HADOOP-12101.015.patch
          JIRA Issue HADOOP-12101
          Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 7182d29494b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9e8411d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          shellcheck v0.4.3
          findbugs v3.0.0
          shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/9254/artifact/patchprocess/diff-patch-shellcheck.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9254/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9254/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9254/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated. 0 shelldocs 0m 4s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 9s trunk passed +1 compile 6m 6s trunk passed with JDK v1.8.0_91 +1 compile 6m 49s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 4s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 39s trunk passed +1 javadoc 0m 59s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 43s the patch passed +1 compile 6m 4s the patch passed with JDK v1.8.0_91 +1 javac 6m 4s the patch passed +1 compile 6m 52s the patch passed with JDK v1.7.0_95 +1 javac 6m 52s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 1m 0s the patch passed +1 mvneclipse 0m 17s the patch passed -1 shellcheck 0m 10s The patch generated 12 new + 96 unchanged - 0 fixed = 108 total (was 96) +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 53s the patch passed +1 javadoc 0m 57s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95 -1 unit 13m 53s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 8m 58s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 69m 49s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801854/HADOOP-12101.015.patch JIRA Issue HADOOP-12101 Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle uname Linux 7182d29494b6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9e8411d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 shellcheck v0.4.3 findbugs v3.0.0 shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/9254/artifact/patchprocess/diff-patch-shellcheck.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9254/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9254/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9254/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          0 shelldocs 0m 4s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 39s trunk passed
          +1 compile 7m 1s trunk passed with JDK v1.8.0_91
          +1 compile 7m 0s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 1m 37s trunk passed
          +1 javadoc 0m 57s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 43s the patch passed
          +1 compile 6m 14s the patch passed with JDK v1.8.0_91
          +1 javac 6m 14s the patch passed
          +1 compile 7m 12s the patch passed with JDK v1.7.0_95
          +1 javac 7m 12s the patch passed
          +1 checkstyle 0m 24s the patch passed
          +1 mvnsite 1m 3s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          -1 shellcheck 0m 10s The patch generated 12 new + 96 unchanged - 0 fixed = 108 total (was 96)
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 53s the patch passed
          +1 javadoc 0m 57s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95
          -1 unit 21m 24s hadoop-common in the patch failed with JDK v1.8.0_91.
          +1 unit 9m 15s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 25s The patch does not generate ASF License warnings.
          78m 34s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.ipc.TestIPC
          JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801793/HADOOP-12101.014.patch
          JIRA Issue HADOOP-12101
          Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 486a897fcceb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9e8411d
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          shellcheck v0.4.3
          findbugs v3.0.0
          shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/9252/artifact/patchprocess/diff-patch-shellcheck.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9252/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9252/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9252/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9252/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. 0 shelldocs 0m 4s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 39s trunk passed +1 compile 7m 1s trunk passed with JDK v1.8.0_91 +1 compile 7m 0s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 37s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 43s the patch passed +1 compile 6m 14s the patch passed with JDK v1.8.0_91 +1 javac 6m 14s the patch passed +1 compile 7m 12s the patch passed with JDK v1.7.0_95 +1 javac 7m 12s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 16s the patch passed -1 shellcheck 0m 10s The patch generated 12 new + 96 unchanged - 0 fixed = 108 total (was 96) +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 53s the patch passed +1 javadoc 0m 57s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 8s the patch passed with JDK v1.7.0_95 -1 unit 21m 24s hadoop-common in the patch failed with JDK v1.8.0_91. +1 unit 9m 15s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 25s The patch does not generate ASF License warnings. 78m 34s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.ipc.TestIPC JDK v1.8.0_91 Timed out junit tests org.apache.hadoop.http.TestHttpServerLifecycle Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801793/HADOOP-12101.014.patch JIRA Issue HADOOP-12101 Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle uname Linux 486a897fcceb 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 9e8411d Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 shellcheck v0.4.3 findbugs v3.0.0 shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/9252/artifact/patchprocess/diff-patch-shellcheck.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9252/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9252/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9252/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9252/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Fix variable reference
          Show
          rchiang Ray Chiang added a comment - Fix variable reference
          Hide
          iwasakims Masatake Iwasaki added a comment -

          Thanks for the update.

          108	export yarnOutputFile="$(find "{dir}" -name org.apache.hadoop.yarn.conf.TestYarnConfigurationFields-output.txt)"
          
          {dir} should be ${dir}
          Show
          iwasakims Masatake Iwasaki added a comment - Thanks for the update. 108 export yarnOutputFile="$(find "{dir}" -name org.apache.hadoop.yarn.conf.TestYarnConfigurationFields-output.txt)" {dir} should be ${dir}
          Hide
          rchiang Ray Chiang added a comment -
          • Fix shellcheck issues and fix missing pasted code.
          Show
          rchiang Ray Chiang added a comment - Fix shellcheck issues and fix missing pasted code.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          0 shelldocs 0m 4s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 55s trunk passed
          +1 compile 5m 47s trunk passed with JDK v1.8.0_91
          +1 compile 6m 38s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 23s trunk passed
          +1 mvnsite 1m 3s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 57s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 42s the patch passed
          +1 compile 5m 41s the patch passed with JDK v1.8.0_91
          +1 javac 5m 41s the patch passed
          +1 compile 6m 35s the patch passed with JDK v1.7.0_95
          +1 javac 6m 35s the patch passed
          +1 checkstyle 0m 22s the patch passed
          +1 mvnsite 0m 57s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          -1 shellcheck 0m 11s The patch generated 3 new + 96 unchanged - 0 fixed = 99 total (was 96)
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95
          -1 unit 6m 40s hadoop-common in the patch failed with JDK v1.8.0_91.
          -1 unit 7m 0s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          58m 53s



          Reason Tests
          JDK v1.8.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          JDK v1.7.0_95 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801779/HADOOP-12101.013.patch
          JIRA Issue HADOOP-12101
          Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle
          uname Linux fce83610b2c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 2beedea
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          shellcheck v0.4.3
          findbugs v3.0.0
          shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/artifact/patchprocess/diff-patch-shellcheck.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. 0 shelldocs 0m 4s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 55s trunk passed +1 compile 5m 47s trunk passed with JDK v1.8.0_91 +1 compile 6m 38s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 23s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 5m 41s the patch passed with JDK v1.8.0_91 +1 javac 5m 41s the patch passed +1 compile 6m 35s the patch passed with JDK v1.7.0_95 +1 javac 6m 35s the patch passed +1 checkstyle 0m 22s the patch passed +1 mvnsite 0m 57s the patch passed +1 mvneclipse 0m 16s the patch passed -1 shellcheck 0m 11s The patch generated 3 new + 96 unchanged - 0 fixed = 99 total (was 96) +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 49s the patch passed +1 javadoc 0m 54s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 4s the patch passed with JDK v1.7.0_95 -1 unit 6m 40s hadoop-common in the patch failed with JDK v1.8.0_91. -1 unit 7m 0s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 58m 53s Reason Tests JDK v1.8.0_91 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics JDK v1.7.0_95 Failed junit tests hadoop.security.ssl.TestReloadingX509TrustManager Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12801779/HADOOP-12101.013.patch JIRA Issue HADOOP-12101 Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle uname Linux fce83610b2c5 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 2beedea Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 shellcheck v0.4.3 findbugs v3.0.0 shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/artifact/patchprocess/diff-patch-shellcheck.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_91.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9251/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Fixes for verify-xml.sh script
          Show
          rchiang Ray Chiang added a comment - Fixes for verify-xml.sh script
          Hide
          rchiang Ray Chiang added a comment -

          Thanks Masatake! I will update the script with your suggestions.

          Show
          rchiang Ray Chiang added a comment - Thanks Masatake! I will update the script with your suggestions.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          The patch affects TestHdfsConfigFields, TestYarnConfigurationFields and TestMapreduceConfigFields but QA build does not run them since the patch only changes the codes under hadoop-common. I ran TestHdfsConfigFields, TestYarnConfigurationFields and TestMapreduceConfigFields locally and verified that it works.

          I think it is ok to handle values with units and variable expantion in follow-up JIRAs.

            XML Property: dfs.namenode.lifeline.handler.ratio
            XML Value:    0.10
            Config Name:  DFS_NAMENODE_LIFELINE_HANDLER_RATIO_DEFAULT
            Config Value: 0.1
          
            XML Property: dfs.namenode.retrycache.heap.percent
            XML Value:    0.03f
            Config Name:  DFS_NAMENODE_RETRY_CACHE_HEAP_PERCENT_DEFAULT
            Config Value: 0.03
          
            XML Property: dfs.namenode.edits.dir
            XML Value:    ${dfs.namenode.name.dir}
            Config Name:  DFS_NAMENODE_EDITS_DIR_DEFAULT
            Config Value: file:///tmp/hadoop/dfs/name
          
            XML Property: dfs.datanode.balance.bandwidthPerSec
            XML Value:    10m
            Config Name:  DFS_DATANODE_BALANCE_BANDWIDTHPERSEC_DEFAULT
            Config Value: 10485760
          
          Show
          iwasakims Masatake Iwasaki added a comment - The patch affects TestHdfsConfigFields, TestYarnConfigurationFields and TestMapreduceConfigFields but QA build does not run them since the patch only changes the codes under hadoop-common. I ran TestHdfsConfigFields, TestYarnConfigurationFields and TestMapreduceConfigFields locally and verified that it works. I think it is ok to handle values with units and variable expantion in follow-up JIRAs. XML Property: dfs.namenode.lifeline.handler.ratio XML Value: 0.10 Config Name: DFS_NAMENODE_LIFELINE_HANDLER_RATIO_DEFAULT Config Value: 0.1 XML Property: dfs.namenode.retrycache.heap.percent XML Value: 0.03f Config Name: DFS_NAMENODE_RETRY_CACHE_HEAP_PERCENT_DEFAULT Config Value: 0.03 XML Property: dfs.namenode.edits.dir XML Value: ${dfs.namenode.name.dir} Config Name: DFS_NAMENODE_EDITS_DIR_DEFAULT Config Value: file:///tmp/hadoop/dfs/name XML Property: dfs.datanode.balance.bandwidthPerSec XML Value: 10m Config Name: DFS_DATANODE_BALANCE_BANDWIDTHPERSEC_DEFAULT Config Value: 10485760
          Hide
          iwasakims Masatake Iwasaki added a comment -

          verify-xml.sh is intended to be run on top directory of source tree but it is not obvious. Is it possible to do cd in the script before run_*_xml_test? like

          # Main body
          
          cd -P -- "$(dirname -- ${BASH_SOURCE-$0})/.."
          dir="$(pwd -P)"
          export commonOutputFile="$(find "${dir}" -name org.apache.hadoop.conf.TestCommonConfigurationFields-output.txt)"
          ...
          

          Otherwise we should add some instruction to comment and usage.

            *)                                                                                                                                                                                           |
              echo "$0 <mode>"
              echo "  where <mode> is one of all, hdfs, mr, yarn"
          

          Usage should be prefixed by "Usage: " and common is missing in modes.

          Show
          iwasakims Masatake Iwasaki added a comment - verify-xml.sh is intended to be run on top directory of source tree but it is not obvious. Is it possible to do cd in the script before run_*_xml_test? like # Main body cd -P -- "$(dirname -- ${BASH_SOURCE-$0})/.." dir="$(pwd -P)" export commonOutputFile="$(find "${dir}" -name org.apache.hadoop.conf.TestCommonConfigurationFields-output.txt)" ... Otherwise we should add some instruction to comment and usage. *) | echo "$0 <mode>" echo " where <mode> is one of all, hdfs, mr, yarn" Usage should be prefixed by "Usage: " and common is missing in modes.
          Hide
          rchiang Ray Chiang added a comment -
          • Same file. Force Jenkins relaunch.
          Show
          rchiang Ray Chiang added a comment - Same file. Force Jenkins relaunch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 docker 0m 3s Docker failed to build yetus/hadoop:fbe3e86.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800606/HADOOP-12101.011.patch
          JIRA Issue HADOOP-12101
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9173/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 0m 3s Docker failed to build yetus/hadoop:fbe3e86. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800606/HADOOP-12101.011.patch JIRA Issue HADOOP-12101 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9173/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Same patch. Re-launch Jenkins.
          Show
          rchiang Ray Chiang added a comment - Same patch. Re-launch Jenkins.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 docker 11m 2s Docker failed to build yetus/hadoop:fbe3e86.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800592/HADOOP-12101.010.patch
          JIRA Issue HADOOP-12101
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9170/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 11m 2s Docker failed to build yetus/hadoop:fbe3e86. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800592/HADOOP-12101.010.patch JIRA Issue HADOOP-12101 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9170/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Add support for TestCommonConfigurationFields
          • Current fails TestYarnConfigurationFields due to YARN-4992
          Show
          rchiang Ray Chiang added a comment - Add support for TestCommonConfigurationFields Current fails TestYarnConfigurationFields due to YARN-4992
          Hide
          rchiang Ray Chiang added a comment -

          RE: Failed unit test

          Test passes in my tree.

          Show
          rchiang Ray Chiang added a comment - RE: Failed unit test Test passes in my tree.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 10m 44s Docker mode activated.
          0 shelldocs 0m 4s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 43s trunk passed
          +1 compile 5m 42s trunk passed with JDK v1.8.0_74
          +1 compile 7m 12s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 20s trunk passed
          +1 mvnsite 1m 1s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 34s trunk passed
          +1 javadoc 0m 52s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 9s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 46s the patch passed
          +1 compile 7m 9s the patch passed with JDK v1.8.0_74
          +1 javac 7m 9s the patch passed
          +1 compile 6m 39s the patch passed with JDK v1.7.0_95
          +1 javac 6m 39s the patch passed
          +1 checkstyle 0m 21s the patch passed
          +1 mvnsite 0m 56s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 shellcheck 0m 9s There were no new shellcheck issues.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 2s the patch passed with JDK v1.7.0_95
          -1 unit 7m 47s hadoop-common in the patch failed with JDK v1.8.0_74.
          +1 unit 8m 44s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          73m 35s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791423/HADOOP-12101.009.patch
          JIRA Issue HADOOP-12101
          Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle
          uname Linux 6e20199ee676 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / cbd3132
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          shellcheck v0.4.3
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8786/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8786/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8786/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8786/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 44s Docker mode activated. 0 shelldocs 0m 4s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 43s trunk passed +1 compile 5m 42s trunk passed with JDK v1.8.0_74 +1 compile 7m 12s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 20s trunk passed +1 mvnsite 1m 1s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 34s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 9s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 46s the patch passed +1 compile 7m 9s the patch passed with JDK v1.8.0_74 +1 javac 7m 9s the patch passed +1 compile 6m 39s the patch passed with JDK v1.7.0_95 +1 javac 6m 39s the patch passed +1 checkstyle 0m 21s the patch passed +1 mvnsite 0m 56s the patch passed +1 mvneclipse 0m 14s the patch passed +1 shellcheck 0m 9s There were no new shellcheck issues. +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 2s the patch passed with JDK v1.7.0_95 -1 unit 7m 47s hadoop-common in the patch failed with JDK v1.8.0_74. +1 unit 8m 44s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 73m 35s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791423/HADOOP-12101.009.patch JIRA Issue HADOOP-12101 Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle uname Linux 6e20199ee676 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / cbd3132 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 shellcheck v0.4.3 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8786/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8786/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_74.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8786/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8786/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Updates based on Robert's feedback.
          Show
          rchiang Ray Chiang added a comment - Updates based on Robert's feedback.
          Hide
          rkanter Robert Kanter added a comment -

          A few more minor things:

          1. Use curly braces on this if statement in extractDefaultVariablesFromConfigurationFields. I've found that not having them, even for such simple things, are very error-prone, especially if someone else needs to update this in the future.
            +    if (fields==null)
            +      return null;
            
          2. I'm not sure there's an advantage to declaring these ahead of the try block in extractDefaultVariablesFromConfigurationFields.
            +        boolean bValue;
            +        float fValue;
            +        short shValue;
            +        int iValue;
            +        long lValue;
            +        String sValue;
            
          3. The try block in extractDefaultVariablesFromConfigurationFields }} doesn't handle {{double. That doesn't seem to be a problem running the script now, but Configuration does have a getDouble() method, so we should add it to be on the safe side.
          4. Why put the script in dev-support/bin/ instead of just dev-support/? There's other scripts in dev-support/ already so I don't think we need to add a new bin/ subdir.
          Show
          rkanter Robert Kanter added a comment - A few more minor things: Use curly braces on this if statement in extractDefaultVariablesFromConfigurationFields . I've found that not having them, even for such simple things, are very error-prone, especially if someone else needs to update this in the future. + if (fields== null ) + return null ; I'm not sure there's an advantage to declaring these ahead of the try block in extractDefaultVariablesFromConfigurationFields . + boolean bValue; + float fValue; + short shValue; + int iValue; + long lValue; + String sValue; The try block in extractDefaultVariablesFromConfigurationFields }} doesn't handle {{double . That doesn't seem to be a problem running the script now, but Configuration does have a getDouble() method, so we should add it to be on the safe side. Why put the script in dev-support/bin/ instead of just dev-support/ ? There's other scripts in dev-support/ already so I don't think we need to add a new bin/ subdir.
          Hide
          rchiang Ray Chiang added a comment -

          RE: Failing unit tests

          All tests pass in my tree and are unrelated.

          Show
          rchiang Ray Chiang added a comment - RE: Failing unit tests All tests pass in my tree and are unrelated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          0 shelldocs 0m 3s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 6m 58s trunk passed
          +1 compile 7m 53s trunk passed with JDK v1.8.0_72
          +1 compile 7m 5s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 19s trunk passed
          +1 mvnsite 1m 7s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 35s trunk passed
          +1 javadoc 1m 0s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 42s the patch passed
          +1 compile 7m 48s the patch passed with JDK v1.8.0_72
          +1 javac 7m 48s the patch passed
          +1 compile 7m 19s the patch passed with JDK v1.7.0_95
          +1 javac 7m 19s the patch passed
          +1 checkstyle 0m 19s the patch passed
          +1 mvnsite 1m 3s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 shellcheck 0m 8s There were no new shellcheck issues.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 47s the patch passed
          +1 javadoc 0m 59s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95
          +1 unit 11m 31s hadoop-common in the patch passed with JDK v1.8.0_72.
          -1 unit 11m 7s hadoop-common in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          73m 1s



          Reason Tests
          JDK v1.7.0_95 Failed junit tests hadoop.fs.shell.find.TestIname
            hadoop.fs.shell.find.TestPrint0
            hadoop.fs.shell.find.TestPrint
            hadoop.fs.shell.find.TestName
            hadoop.ipc.TestProtoBufRpc



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790537/HADOOP-12101.008.patch
          JIRA Issue HADOOP-12101
          Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle
          uname Linux d8d0a3792a3d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1cb2f93
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          shellcheck v0.4.3
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8746/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8746/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8746/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8746/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. 0 shelldocs 0m 3s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 58s trunk passed +1 compile 7m 53s trunk passed with JDK v1.8.0_72 +1 compile 7m 5s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 19s trunk passed +1 mvnsite 1m 7s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 35s trunk passed +1 javadoc 1m 0s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 7s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 42s the patch passed +1 compile 7m 48s the patch passed with JDK v1.8.0_72 +1 javac 7m 48s the patch passed +1 compile 7m 19s the patch passed with JDK v1.7.0_95 +1 javac 7m 19s the patch passed +1 checkstyle 0m 19s the patch passed +1 mvnsite 1m 3s the patch passed +1 mvneclipse 0m 13s the patch passed +1 shellcheck 0m 8s There were no new shellcheck issues. +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 59s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 7s the patch passed with JDK v1.7.0_95 +1 unit 11m 31s hadoop-common in the patch passed with JDK v1.8.0_72. -1 unit 11m 7s hadoop-common in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 73m 1s Reason Tests JDK v1.7.0_95 Failed junit tests hadoop.fs.shell.find.TestIname   hadoop.fs.shell.find.TestPrint0   hadoop.fs.shell.find.TestPrint   hadoop.fs.shell.find.TestName   hadoop.ipc.TestProtoBufRpc Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12790537/HADOOP-12101.008.patch JIRA Issue HADOOP-12101 Optional Tests asflicense mvnsite unit shellcheck shelldocs compile javac javadoc mvninstall findbugs checkstyle uname Linux d8d0a3792a3d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1cb2f93 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 shellcheck v0.4.3 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8746/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8746/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8746/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8746/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Move verify-xml.sh into dev-support/bin directory
          Show
          rchiang Ray Chiang added a comment - Move verify-xml.sh into dev-support/bin directory
          Hide
          rchiang Ray Chiang added a comment -

          RE: Failing unit tests with JDK8

          Both tests pass in my tree using JDK8.

          Show
          rchiang Ray Chiang added a comment - RE: Failing unit tests with JDK8 Both tests pass in my tree using JDK8.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 58s trunk passed
          +1 compile 11m 26s trunk passed with JDK v1.8.0_66
          +1 compile 9m 28s trunk passed with JDK v1.7.0_91
          +1 checkstyle 0m 18s trunk passed
          +1 mvnsite 1m 6s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 2m 9s trunk passed
          +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 18s trunk passed with JDK v1.7.0_91
          +1 mvninstall 1m 49s the patch passed
          +1 compile 11m 18s the patch passed with JDK v1.8.0_66
          +1 javac 11m 18s the patch passed
          +1 compile 9m 32s the patch passed with JDK v1.7.0_91
          +1 javac 9m 32s the patch passed
          +1 checkstyle 0m 17s the patch passed
          +1 mvnsite 1m 9s the patch passed
          +1 mvneclipse 0m 15s the patch passed
          +1 shellcheck 0m 8s There were no new shellcheck issues.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 14s the patch passed
          +1 javadoc 1m 2s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 10s the patch passed with JDK v1.7.0_91
          -1 unit 10m 9s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 9m 39s hadoop-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          86m 30s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781100/HADOOP-12101.007.patch
          JIRA Issue HADOOP-12101
          Optional Tests asflicense mvnsite unit shellcheck compile javac javadoc mvninstall findbugs checkstyle
          uname Linux e2dcd59408ad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 89022f8
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          shellcheck v0.4.1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8360/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8360/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8360/testReport/
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Max memory used 75MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8360/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 58s trunk passed +1 compile 11m 26s trunk passed with JDK v1.8.0_66 +1 compile 9m 28s trunk passed with JDK v1.7.0_91 +1 checkstyle 0m 18s trunk passed +1 mvnsite 1m 6s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 2m 9s trunk passed +1 javadoc 1m 5s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 18s trunk passed with JDK v1.7.0_91 +1 mvninstall 1m 49s the patch passed +1 compile 11m 18s the patch passed with JDK v1.8.0_66 +1 javac 11m 18s the patch passed +1 compile 9m 32s the patch passed with JDK v1.7.0_91 +1 javac 9m 32s the patch passed +1 checkstyle 0m 17s the patch passed +1 mvnsite 1m 9s the patch passed +1 mvneclipse 0m 15s the patch passed +1 shellcheck 0m 8s There were no new shellcheck issues. +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 14s the patch passed +1 javadoc 1m 2s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 10s the patch passed with JDK v1.7.0_91 -1 unit 10m 9s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 9m 39s hadoop-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 86m 30s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.ha.TestZKFailoverController Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781100/HADOOP-12101.007.patch JIRA Issue HADOOP-12101 Optional Tests asflicense mvnsite unit shellcheck compile javac javadoc mvninstall findbugs checkstyle uname Linux e2dcd59408ad 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 89022f8 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 shellcheck v0.4.1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8360/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8360/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8360/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Max memory used 75MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8360/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Add short values to catch a few more matchups
          Show
          rchiang Ray Chiang added a comment - Add short values to catch a few more matchups
          Hide
          rchiang Ray Chiang added a comment -

          RE: failing unit tests

          Unrelated unit tests. All tests pass in my tree.

          Show
          rchiang Ray Chiang added a comment - RE: failing unit tests Unrelated unit tests. All tests pass in my tree.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 8m 58s trunk passed
          +1 compile 4m 27s trunk passed with JDK v1.8.0_60
          +1 compile 4m 15s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 18s trunk passed
          +1 mvneclipse 0m 17s trunk passed
          +1 findbugs 1m 49s trunk passed
          +1 javadoc 0m 55s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 5s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 35s the patch passed
          +1 compile 4m 23s the patch passed with JDK v1.8.0_60
          +1 javac 4m 23s the patch passed
          +1 compile 4m 11s the patch passed with JDK v1.7.0_79
          +1 javac 4m 11s the patch passed
          +1 checkstyle 0m 16s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 shellcheck 0m 8s There were no new shellcheck issues.
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 47s the patch passed
          +1 javadoc 0m 51s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 3s the patch passed with JDK v1.7.0_79
          -1 unit 8m 9s hadoop-common in the patch failed with JDK v1.8.0_60.
          -1 unit 8m 33s hadoop-common in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          54m 49s



          Reason Tests
          JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.fs.TestSymlinkLocalFSFileSystem
            hadoop.fs.TestSymlinkLocalFSFileContext



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-23
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768415/HADOOP-12101.006.patch
          JIRA Issue HADOOP-12101
          Optional Tests asflicense unit shellcheck javac javadoc mvninstall findbugs checkstyle compile
          uname Linux e331dbc2d731 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh
          git revision trunk / 15eb84b
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          shellcheck v0.4.1
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/testReport/
          Max memory used 229MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 8m 58s trunk passed +1 compile 4m 27s trunk passed with JDK v1.8.0_60 +1 compile 4m 15s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 18s trunk passed +1 mvneclipse 0m 17s trunk passed +1 findbugs 1m 49s trunk passed +1 javadoc 0m 55s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 35s the patch passed +1 compile 4m 23s the patch passed with JDK v1.8.0_60 +1 javac 4m 23s the patch passed +1 compile 4m 11s the patch passed with JDK v1.7.0_79 +1 javac 4m 11s the patch passed +1 checkstyle 0m 16s the patch passed +1 mvneclipse 0m 13s the patch passed +1 shellcheck 0m 8s There were no new shellcheck issues. +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 47s the patch passed +1 javadoc 0m 51s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 3s the patch passed with JDK v1.7.0_79 -1 unit 8m 9s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 8m 33s hadoop-common in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 54m 49s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.TestSymlinkLocalFSFileSystem   hadoop.fs.TestSymlinkLocalFSFileContext Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-23 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768415/HADOOP-12101.006.patch JIRA Issue HADOOP-12101 Optional Tests asflicense unit shellcheck javac javadoc mvninstall findbugs checkstyle compile uname Linux e331dbc2d731 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh git revision trunk / 15eb84b Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 shellcheck v0.4.1 unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/testReport/ Max memory used 229MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7922/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          Fix shellcheck issue

          Show
          rchiang Ray Chiang added a comment - Fix shellcheck issue
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s docker + precommit patch detected.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 3m 11s trunk passed
          +1 compile 4m 34s trunk passed with JDK v1.8.0_60
          +1 compile 4m 12s trunk passed with JDK v1.7.0_79
          +1 checkstyle 0m 16s trunk passed
          +1 mvneclipse 0m 16s trunk passed
          +1 findbugs 1m 37s trunk passed
          +1 javadoc 0m 57s trunk passed with JDK v1.8.0_60
          +1 javadoc 1m 5s trunk passed with JDK v1.7.0_79
          +1 mvninstall 1m 26s the patch passed
          +1 compile 4m 21s the patch passed with JDK v1.8.0_60
          +1 javac 4m 21s the patch passed
          +1 compile 4m 8s the patch passed with JDK v1.7.0_79
          +1 javac 4m 8s the patch passed
          +1 checkstyle 0m 15s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          -1 shellcheck 0m 9s The applied patch generated 1 new shellcheck issues (total was 97, now 98).
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 1m 54s the patch passed
          +1 javadoc 0m 58s the patch passed with JDK v1.8.0_60
          +1 javadoc 1m 6s the patch passed with JDK v1.7.0_79
          -1 unit 8m 6s hadoop-common in the patch failed with JDK v1.8.0_60.
          -1 unit 8m 7s hadoop-common in the patch failed with JDK v1.7.0_79.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          48m 31s



          Reason Tests
          JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
            hadoop.fs.shell.TestCopyPreserveFlag



          Subsystem Report/Notes
          Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768166/HADOOP-12101.005.patch
          JIRA Issue HADOOP-12101
          Optional Tests asflicense unit shellcheck javac javadoc mvninstall findbugs checkstyle compile
          uname Linux 4d2b1d0050e2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh
          git revision trunk / 124a412
          Default Java 1.7.0_79
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79
          findbugs v3.0.0
          shellcheck v0.4.1
          shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/artifact/patchprocess/diff-patch-shellcheck.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt
          JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/testReport/
          Max memory used 225MB
          Powered by Apache Yetus http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s docker + precommit patch detected. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 3m 11s trunk passed +1 compile 4m 34s trunk passed with JDK v1.8.0_60 +1 compile 4m 12s trunk passed with JDK v1.7.0_79 +1 checkstyle 0m 16s trunk passed +1 mvneclipse 0m 16s trunk passed +1 findbugs 1m 37s trunk passed +1 javadoc 0m 57s trunk passed with JDK v1.8.0_60 +1 javadoc 1m 5s trunk passed with JDK v1.7.0_79 +1 mvninstall 1m 26s the patch passed +1 compile 4m 21s the patch passed with JDK v1.8.0_60 +1 javac 4m 21s the patch passed +1 compile 4m 8s the patch passed with JDK v1.7.0_79 +1 javac 4m 8s the patch passed +1 checkstyle 0m 15s the patch passed +1 mvneclipse 0m 14s the patch passed -1 shellcheck 0m 9s The applied patch generated 1 new shellcheck issues (total was 97, now 98). +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 1m 54s the patch passed +1 javadoc 0m 58s the patch passed with JDK v1.8.0_60 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_79 -1 unit 8m 6s hadoop-common in the patch failed with JDK v1.8.0_60. -1 unit 8m 7s hadoop-common in the patch failed with JDK v1.7.0_79. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 48m 31s Reason Tests JDK v1.7.0_79 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics   hadoop.fs.shell.TestCopyPreserveFlag Subsystem Report/Notes Docker Client=1.7.1 Server=1.7.1 Image:test-patch-base-hadoop-date2015-10-22 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12768166/HADOOP-12101.005.patch JIRA Issue HADOOP-12101 Optional Tests asflicense unit shellcheck javac javadoc mvninstall findbugs checkstyle compile uname Linux 4d2b1d0050e2 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/patchprocess/apache-yetus-28a3a3d/dev-support/personality/hadoop.sh git revision trunk / 124a412 Default Java 1.7.0_79 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_60 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_79 findbugs v3.0.0 shellcheck v0.4.1 shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/artifact/patchprocess/diff-patch-shellcheck.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_60.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_79.txt JDK v1.7.0_79 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/testReport/ Max memory used 225MB Powered by Apache Yetus http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7916/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Update script based on feedback
          Show
          rchiang Ray Chiang added a comment - Update script based on feedback
          Hide
          rchiang Ray Chiang added a comment -

          For the last item, it looks like YARN-3958 moved the test from hadoop-yarn-common to hadoop-yarn-api.

          Show
          rchiang Ray Chiang added a comment - For the last item, it looks like YARN-3958 moved the test from hadoop-yarn-common to hadoop-yarn-api.
          Hide
          rkanter Robert Kanter added a comment -

          Overall looks good. A few minor comments:

          • In the usage output, mode should be <mode>
          • If you do the all mode, it prints out the location of the output file after each maven run, so earlier runs get buried (or lost depending on scroll back). We should print them all out at the end when doing all.
          • We could save some time and lots of output when running all by having it use the same maven invocation for all of them. In other words, mvn test -Dtest=TestHdfsConfigFields,TestMapreduceConfigFields,TestYarnConfigurationFields instead of three separate mvn test runs.
          • When running the yarn mode, it doesn't print out the location of the output file, though I don't see why.
          Show
          rkanter Robert Kanter added a comment - Overall looks good. A few minor comments: In the usage output, mode should be <mode> If you do the all mode, it prints out the location of the output file after each maven run, so earlier runs get buried (or lost depending on scroll back). We should print them all out at the end when doing all . We could save some time and lots of output when running all by having it use the same maven invocation for all of them. In other words, mvn test -Dtest=TestHdfsConfigFields,TestMapreduceConfigFields,TestYarnConfigurationFields instead of three separate mvn test runs. When running the yarn mode, it doesn't print out the location of the output file, though I don't see why.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 9m 43s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 10m 30s There were no new javac warning messages.
          +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 30s There were no new checkstyle issues.
          -1 shellcheck 0m 8s The applied patch generated 118 new shellcheck (v0.3.3) issues (total was 20, now 138).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 51s mvn install still works.
          +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse.
          +1 findbugs 2m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 15m 51s Tests failed in hadoop-common.
              43m 4s  



          Reason Tests
          Failed unit tests hadoop.ipc.TestDecayRpcScheduler
            hadoop.ha.TestZKFailoverController



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12766856/HADOOP-12101.004.patch
          Optional Tests shellcheck javac unit findbugs checkstyle
          git revision trunk / 8d2d3eb
          shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/7826/artifact/patchprocess/diffpatchshellcheck.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7826/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7826/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7826/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 9m 43s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 10m 30s There were no new javac warning messages. +1 release audit 0m 25s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 30s There were no new checkstyle issues. -1 shellcheck 0m 8s The applied patch generated 118 new shellcheck (v0.3.3) issues (total was 20, now 138). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 51s mvn install still works. +1 eclipse:eclipse 0m 40s The patch built with eclipse:eclipse. +1 findbugs 2m 21s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 15m 51s Tests failed in hadoop-common.     43m 4s   Reason Tests Failed unit tests hadoop.ipc.TestDecayRpcScheduler   hadoop.ha.TestZKFailoverController Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12766856/HADOOP-12101.004.patch Optional Tests shellcheck javac unit findbugs checkstyle git revision trunk / 8d2d3eb shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/7826/artifact/patchprocess/diffpatchshellcheck.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7826/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7826/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7826/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          Add back missing script.

          Show
          rchiang Ray Chiang added a comment - Add back missing script.
          Hide
          rchiang Ray Chiang added a comment -

          Akira Ajisaka Tsuyoshi Ozawa, any other comments?

          Show
          rchiang Ray Chiang added a comment - Akira Ajisaka Tsuyoshi Ozawa , any other comments?
          Hide
          rchiang Ray Chiang added a comment -

          RE: Pre-patch findbugs

          Not in related code

          RE: Failed unit test

          Unrelated test and test doesn't fail in my tree

          Show
          rchiang Ray Chiang added a comment - RE: Pre-patch findbugs Not in related code RE: Failed unit test Unrelated test and test doesn't fail in my tree
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 7m 26s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 0s There were no new javac warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 8s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 30s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          -1 common tests 7m 22s Tests failed in hadoop-common.
              28m 17s  



          Reason Tests
          Failed unit tests hadoop.ipc.TestRPCWaitForProxy



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764098/HADOOP-12101.003.patch
          Optional Tests javac unit findbugs checkstyle
          git revision trunk / e5992ef
          Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7720/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7720/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7720/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7720/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 7m 26s Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 0s There were no new javac warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 8s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 30s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 51s The patch does not introduce any new Findbugs (version 3.0.0) warnings. -1 common tests 7m 22s Tests failed in hadoop-common.     28m 17s   Reason Tests Failed unit tests hadoop.ipc.TestRPCWaitForProxy Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764098/HADOOP-12101.003.patch Optional Tests javac unit findbugs checkstyle git revision trunk / e5992ef Pre-patch Findbugs warnings https://builds.apache.org/job/PreCommit-HADOOP-Build/7720/artifact/patchprocess/trunkFindbugsWarningshadoop-common.html hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7720/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7720/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7720/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Minor shellcheck cleanup
          Show
          rchiang Ray Chiang added a comment - Minor shellcheck cleanup
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 7m 26s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 0s There were no new javac warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 8s There were no new checkstyle issues.
          -1 shellcheck 0m 5s The applied patch generated 14 new shellcheck (v0.3.3) issues (total was 20, now 34).
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 4s Tests passed in hadoop-common.
              44m 4s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12741095/HADOOP-12101.002.patch
          Optional Tests shellcheck javac unit findbugs checkstyle
          git revision trunk / 67b0e96
          shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/7708/artifact/patchprocess/diffpatchshellcheck.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7708/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7708/testReport/
          Java 1.7.0_55
          uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7708/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 7m 26s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 0s There were no new javac warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 8s There were no new checkstyle issues. -1 shellcheck 0m 5s The applied patch generated 14 new shellcheck (v0.3.3) issues (total was 20, now 34). +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 54s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 4s Tests passed in hadoop-common.     44m 4s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741095/HADOOP-12101.002.patch Optional Tests shellcheck javac unit findbugs checkstyle git revision trunk / 67b0e96 shellcheck https://builds.apache.org/job/PreCommit-HADOOP-Build/7708/artifact/patchprocess/diffpatchshellcheck.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7708/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7708/testReport/ Java 1.7.0_55 uname Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7708/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          Any comments? I'd love to get this in instead of patching all my other trees for my own debugging.

          Show
          rchiang Ray Chiang added a comment - Any comments? I'd love to get this in instead of patching all my other trees for my own debugging.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 6m 50s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 29s There were no new javac warning messages.
          +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 4s There were no new checkstyle issues.
          +1 shellcheck 0m 5s There were no new shellcheck (v0.3.3) issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
          +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 21m 50s Tests passed in hadoop-common.
              41m 36s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12741095/HADOOP-12101.002.patch
          Optional Tests shellcheck javac unit findbugs checkstyle
          git revision trunk / 445b132
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7015/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7015/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7015/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 6m 50s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 29s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 4s There were no new checkstyle issues. +1 shellcheck 0m 5s There were no new shellcheck (v0.3.3) issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 1m 50s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 21m 50s Tests passed in hadoop-common.     41m 36s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741095/HADOOP-12101.002.patch Optional Tests shellcheck javac unit findbugs checkstyle git revision trunk / 445b132 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7015/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7015/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7015/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -
          • Fix some places where the xml filename was hardcoded
          • Add test script called verify-xml.sh
          Show
          rchiang Ray Chiang added a comment - Fix some places where the xml filename was hardcoded Add test script called verify-xml.sh
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 7m 5s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 49s There were no new javac warning messages.
          +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 6s There were no new checkstyle issues.
          +1 whitespace 0m 1s The patch has no lines that end in whitespace.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 10s Tests passed in hadoop-common.
              42m 30s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12740302/HADOOP-12101.001.patch
          Optional Tests javac unit findbugs checkstyle
          git revision trunk / 295d678
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6987/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6987/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6987/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 7m 5s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 49s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 6s There were no new checkstyle issues. +1 whitespace 0m 1s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 10s Tests passed in hadoop-common.     42m 30s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12740302/HADOOP-12101.001.patch Optional Tests javac unit findbugs checkstyle git revision trunk / 295d678 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6987/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6987/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6987/console This message was automatically generated.
          Hide
          rchiang Ray Chiang added a comment -

          Thanks!

          I did talk to Allen Wittenauer about running it as a separate test category and it seemed like test-patch should figure out when to run it automatically. I haven't done any work yet to verify that .xml changes or Configuration changes would trigger the various Test*Config* unit tests.

          I can certainly add a basic shell script for running the 3 existing tests. I might need some help with doing anything fancier since I'm not super familiar with any of the build/test scripts.

          Show
          rchiang Ray Chiang added a comment - Thanks! I did talk to Allen Wittenauer about running it as a separate test category and it seemed like test-patch should figure out when to run it automatically. I haven't done any work yet to verify that .xml changes or Configuration changes would trigger the various Test*Config* unit tests. I can certainly add a basic shell script for running the 3 existing tests. I might need some help with doing anything fancier since I'm not super familiar with any of the build/test scripts.
          Hide
          ozawa Tsuyoshi Ozawa added a comment -

          Ray Chiang Thank you for taking this issue. It looks very useful tool. +1 on the idea. It's very useful to add this as a test. I think it's also useful to add a shell script to dev-support directory to launch the check. Thoughts?

          Show
          ozawa Tsuyoshi Ozawa added a comment - Ray Chiang Thank you for taking this issue. It looks very useful tool. +1 on the idea. It's very useful to add this as a test. I think it's also useful to add a shell script to dev-support directory to launch the check. Thoughts?

            People

            • Assignee:
              rchiang Ray Chiang
              Reporter:
              rchiang Ray Chiang
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development