Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12097

Allow port range to be specified while starting webapp

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha4
    • Component/s: None
    • Labels:
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      This can be used by AM while starting its webapp.
      Currently a random port is chosen, which is never a good idea.

      And Webapps has facility to allow only a specific port to be configured which may be occupied. A port range in case of AM, hence will be useful.

      1. tests.patch
        5 kB
        Varun Saxena
      2. HADOOP-12097.01.patch
        10 kB
        Varun Saxena
      3. HADOOP-12097.02.patch
        10 kB
        Varun Saxena
      4. HADOOP-12097.03.patch
        15 kB
        Varun Saxena

        Issue Links

          Activity

          Hide
          varun_saxena Varun Saxena added a comment -

          Thanks Junping Du for the review and commit.

          Show
          varun_saxena Varun Saxena added a comment - Thanks Junping Du for the review and commit.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11212 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11212/)
          HADOOP-12097. Allow port range to be specified while starting webapp. (junping_du: rev cce35c38159b23eb55204b3c9afcaa3215f4f4ef)

          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
          • (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java
          • (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11212 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11212/ ) HADOOP-12097 . Allow port range to be specified while starting webapp. (junping_du: rev cce35c38159b23eb55204b3c9afcaa3215f4f4ef) (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/webapp/TestWebApp.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java (edit) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/webapp/WebApps.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/http/TestHttpServer.java
          Hide
          djp Junping Du added a comment -

          I have commit the patch to trunk and branch-2. Thanks Varun Saxena for reporting the issue and delivering the fix!

          Show
          djp Junping Du added a comment - I have commit the patch to trunk and branch-2. Thanks Varun Saxena for reporting the issue and delivering the fix!
          Hide
          djp Junping Du added a comment -

          Thanks Varun Saxena for updating the patch! The latest one LGTM. Will commit it shortly.

          Show
          djp Junping Du added a comment - Thanks Varun Saxena for updating the patch! The latest one LGTM. Will commit it shortly.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
          0 mvndep 0m 19s Maven dependency ordering for branch
          +1 mvninstall 14m 35s trunk passed
          +1 compile 14m 42s trunk passed
          +1 checkstyle 1m 55s trunk passed
          +1 mvnsite 1m 59s trunk passed
          +1 mvneclipse 0m 42s trunk passed
          +1 findbugs 2m 58s trunk passed
          +1 javadoc 1m 26s trunk passed
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 1m 20s the patch passed
          +1 compile 12m 30s the patch passed
          +1 javac 12m 30s the patch passed
          -0 checkstyle 1m 58s root: The patch generated 7 new + 302 unchanged - 0 fixed = 309 total (was 302)
          +1 mvnsite 1m 51s the patch passed
          +1 mvneclipse 0m 42s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 31s the patch passed
          +1 javadoc 1m 45s the patch passed
          +1 unit 9m 32s hadoop-common in the patch passed.
          +1 unit 3m 11s hadoop-yarn-common in the patch passed.
          +1 asflicense 0m 43s The patch does not generate ASF License warnings.
          100m 54s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:a9ad5d6
          JIRA Issue HADOOP-12097
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848947/HADOOP-12097.03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 4d5c34e7e6a8 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0101267
          Default Java 1.8.0_121
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11503/artifact/patchprocess/diff-checkstyle-root.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11503/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11503/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files. 0 mvndep 0m 19s Maven dependency ordering for branch +1 mvninstall 14m 35s trunk passed +1 compile 14m 42s trunk passed +1 checkstyle 1m 55s trunk passed +1 mvnsite 1m 59s trunk passed +1 mvneclipse 0m 42s trunk passed +1 findbugs 2m 58s trunk passed +1 javadoc 1m 26s trunk passed 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 20s the patch passed +1 compile 12m 30s the patch passed +1 javac 12m 30s the patch passed -0 checkstyle 1m 58s root: The patch generated 7 new + 302 unchanged - 0 fixed = 309 total (was 302) +1 mvnsite 1m 51s the patch passed +1 mvneclipse 0m 42s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 31s the patch passed +1 javadoc 1m 45s the patch passed +1 unit 9m 32s hadoop-common in the patch passed. +1 unit 3m 11s hadoop-yarn-common in the patch passed. +1 asflicense 0m 43s The patch does not generate ASF License warnings. 100m 54s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-12097 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12848947/HADOOP-12097.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4d5c34e7e6a8 3.13.0-103-generic #150-Ubuntu SMP Thu Nov 24 10:34:17 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0101267 Default Java 1.8.0_121 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/11503/artifact/patchprocess/diff-checkstyle-root.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11503/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11503/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          For some reason, build wasn't invoked. Invoking it manually.

          Show
          varun_saxena Varun Saxena added a comment - For some reason, build wasn't invoked. Invoking it manually.
          Hide
          varun_saxena Varun Saxena added a comment -

          Rebased the patch.
          The test cases added may be a little flaky as they rely on a specific port range but as we are waiting for a free port and also give a large range, it should rarely fail.

          Show
          varun_saxena Varun Saxena added a comment - Rebased the patch. The test cases added may be a little flaky as they rely on a specific port range but as we are waiting for a free port and also give a large range, it should rarely fail.
          Hide
          varun_saxena Varun Saxena added a comment -

          Junping Du, just saw your comment. Will update the patch by tomorrow.

          Show
          varun_saxena Varun Saxena added a comment - Junping Du , just saw your comment. Will update the patch by tomorrow.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HADOOP-12097 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HADOOP-12097
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783339/HADOOP-12097.02.patch
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11452/console
          Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HADOOP-12097 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-12097 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783339/HADOOP-12097.02.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11452/console Powered by Apache Yetus 0.5.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          djp Junping Du added a comment -

          Thanks Varun Saxena for reporting the issue and delivering the fix. The patch looks good in overall. Can you merge the unit test patch into the main patch and rebase to latest trunk? I will review it from there. Thanks!

          Show
          djp Junping Du added a comment - Thanks Varun Saxena for reporting the issue and delivering the fix. The patch looks good in overall. Can you merge the unit test patch into the main patch and rebase to latest trunk? I will review it from there. Thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 18s trunk passed
          +1 compile 7m 46s trunk passed with JDK v1.8.0_91
          +1 compile 7m 22s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 27s trunk passed
          +1 mvnsite 1m 34s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          -1 findbugs 1m 9s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 1m 27s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 37s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 1m 10s the patch passed
          +1 compile 6m 44s the patch passed with JDK v1.8.0_91
          +1 javac 6m 44s the patch passed
          +1 compile 7m 21s the patch passed with JDK v1.7.0_95
          +1 javac 7m 21s the patch passed
          -1 checkstyle 1m 30s root: The patch generated 2 new + 270 unchanged - 0 fixed = 272 total (was 270)
          +1 mvnsite 1m 33s the patch passed
          +1 mvneclipse 0m 26s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 24s the patch passed
          +1 javadoc 1m 37s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 47s the patch passed with JDK v1.7.0_95
          +1 unit 8m 50s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
          +1 unit 8m 28s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 27s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          81m 37s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783339/HADOOP-12097.02.patch
          JIRA Issue HADOOP-12097
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5eae9f0fc9fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3fa1380
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9427/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9427/artifact/patchprocess/diff-checkstyle-root.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9427/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9427/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 18s trunk passed +1 compile 7m 46s trunk passed with JDK v1.8.0_91 +1 compile 7m 22s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 27s trunk passed +1 mvnsite 1m 34s trunk passed +1 mvneclipse 0m 27s trunk passed -1 findbugs 1m 9s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 27s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 37s trunk passed with JDK v1.7.0_95 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 10s the patch passed +1 compile 6m 44s the patch passed with JDK v1.8.0_91 +1 javac 6m 44s the patch passed +1 compile 7m 21s the patch passed with JDK v1.7.0_95 +1 javac 7m 21s the patch passed -1 checkstyle 1m 30s root: The patch generated 2 new + 270 unchanged - 0 fixed = 272 total (was 270) +1 mvnsite 1m 33s the patch passed +1 mvneclipse 0m 26s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 24s the patch passed +1 javadoc 1m 37s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 47s the patch passed with JDK v1.7.0_95 +1 unit 8m 50s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 2m 7s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. +1 unit 8m 28s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 2m 27s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 81m 37s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783339/HADOOP-12097.02.patch JIRA Issue HADOOP-12097 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5eae9f0fc9fa 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3fa1380 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9427/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9427/artifact/patchprocess/diff-checkstyle-root.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9427/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9427/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 12s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 57s Maven dependency ordering for branch
          +1 mvninstall 6m 38s trunk passed
          +1 compile 6m 3s trunk passed with JDK v1.8.0_91
          +1 compile 6m 46s trunk passed with JDK v1.7.0_95
          +1 checkstyle 1m 28s trunk passed
          +1 mvnsite 1m 30s trunk passed
          +1 mvneclipse 0m 27s trunk passed
          -1 findbugs 1m 6s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings.
          +1 javadoc 1m 30s trunk passed with JDK v1.8.0_91
          +1 javadoc 1m 41s trunk passed with JDK v1.7.0_95
          0 mvndep 0m 16s Maven dependency ordering for patch
          +1 mvninstall 1m 14s the patch passed
          +1 compile 7m 47s the patch passed with JDK v1.8.0_91
          +1 javac 7m 47s the patch passed
          +1 compile 7m 47s the patch passed with JDK v1.7.0_95
          +1 javac 7m 47s the patch passed
          -1 checkstyle 1m 30s root: The patch generated 2 new + 270 unchanged - 0 fixed = 272 total (was 270)
          +1 mvnsite 1m 36s the patch passed
          +1 mvneclipse 0m 27s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 3m 18s the patch passed
          +1 javadoc 1m 28s the patch passed with JDK v1.8.0_91
          +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95
          +1 unit 9m 0s hadoop-common in the patch passed with JDK v1.8.0_91.
          +1 unit 2m 32s hadoop-yarn-common in the patch passed with JDK v1.8.0_91.
          +1 unit 9m 10s hadoop-common in the patch passed with JDK v1.7.0_95.
          +1 unit 2m 29s hadoop-yarn-common in the patch passed with JDK v1.7.0_95.
          +1 asflicense 0m 22s The patch does not generate ASF License warnings.
          81m 50s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:cf2ee45
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783339/HADOOP-12097.02.patch
          JIRA Issue HADOOP-12097
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 0ee9d4b1656a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3fa1380
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9425/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9425/artifact/patchprocess/diff-checkstyle-root.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9425/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9425/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 12s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 57s Maven dependency ordering for branch +1 mvninstall 6m 38s trunk passed +1 compile 6m 3s trunk passed with JDK v1.8.0_91 +1 compile 6m 46s trunk passed with JDK v1.7.0_95 +1 checkstyle 1m 28s trunk passed +1 mvnsite 1m 30s trunk passed +1 mvneclipse 0m 27s trunk passed -1 findbugs 1m 6s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common in trunk has 1 extant Findbugs warnings. +1 javadoc 1m 30s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 41s trunk passed with JDK v1.7.0_95 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 14s the patch passed +1 compile 7m 47s the patch passed with JDK v1.8.0_91 +1 javac 7m 47s the patch passed +1 compile 7m 47s the patch passed with JDK v1.7.0_95 +1 javac 7m 47s the patch passed -1 checkstyle 1m 30s root: The patch generated 2 new + 270 unchanged - 0 fixed = 272 total (was 270) +1 mvnsite 1m 36s the patch passed +1 mvneclipse 0m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 3m 18s the patch passed +1 javadoc 1m 28s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95 +1 unit 9m 0s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 2m 32s hadoop-yarn-common in the patch passed with JDK v1.8.0_91. +1 unit 9m 10s hadoop-common in the patch passed with JDK v1.7.0_95. +1 unit 2m 29s hadoop-yarn-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 22s The patch does not generate ASF License warnings. 81m 50s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783339/HADOOP-12097.02.patch JIRA Issue HADOOP-12097 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0ee9d4b1656a 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3fa1380 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/9425/artifact/patchprocess/branch-findbugs-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-common-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/9425/artifact/patchprocess/diff-checkstyle-root.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9425/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9425/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          varun_saxena Varun Saxena added a comment -

          Kindly review.
          Fixed those checkstyle issues which could be fixed. Others follow the same style as previous code. If required, can be fixed.

          Show
          varun_saxena Varun Saxena added a comment - Kindly review. Fixed those checkstyle issues which could be fixed. Others follow the same style as previous code. If required, can be fixed.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 33s Maven dependency ordering for branch
          +1 mvninstall 8m 12s trunk passed
          +1 compile 6m 43s trunk passed with JDK v1.8.0_66
          +1 compile 7m 31s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 9s trunk passed
          +1 mvnsite 1m 44s trunk passed
          +1 mvneclipse 0m 29s trunk passed
          +1 findbugs 3m 15s trunk passed
          +1 javadoc 1m 27s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 39s trunk passed with JDK v1.7.0_91
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 2m 7s the patch passed
          +1 compile 6m 38s the patch passed with JDK v1.8.0_66
          +1 javac 6m 38s the patch passed
          +1 compile 7m 28s the patch passed with JDK v1.7.0_91
          +1 javac 7m 28s the patch passed
          -1 checkstyle 1m 4s root: patch generated 2 new + 274 unchanged - 0 fixed = 276 total (was 274)
          +1 mvnsite 1m 39s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 44s the patch passed
          +1 javadoc 1m 26s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 41s the patch passed with JDK v1.7.0_91
          -1 unit 7m 29s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 2s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 7m 33s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          80m 29s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          JDK v1.7.0_91 Failed junit tests hadoop.fs.TestSymlinkLocalFSFileContext



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783339/HADOOP-12097.02.patch
          JIRA Issue HADOOP-12097
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 866852092edd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 57d0a94
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Max memory used 77MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 33s Maven dependency ordering for branch +1 mvninstall 8m 12s trunk passed +1 compile 6m 43s trunk passed with JDK v1.8.0_66 +1 compile 7m 31s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 9s trunk passed +1 mvnsite 1m 44s trunk passed +1 mvneclipse 0m 29s trunk passed +1 findbugs 3m 15s trunk passed +1 javadoc 1m 27s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 39s trunk passed with JDK v1.7.0_91 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 2m 7s the patch passed +1 compile 6m 38s the patch passed with JDK v1.8.0_66 +1 javac 6m 38s the patch passed +1 compile 7m 28s the patch passed with JDK v1.7.0_91 +1 javac 7m 28s the patch passed -1 checkstyle 1m 4s root: patch generated 2 new + 274 unchanged - 0 fixed = 276 total (was 274) +1 mvnsite 1m 39s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 44s the patch passed +1 javadoc 1m 26s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 41s the patch passed with JDK v1.7.0_91 -1 unit 7m 29s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 2m 2s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 7m 33s hadoop-common in the patch failed with JDK v1.7.0_91. +1 unit 2m 16s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 80m 29s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics JDK v1.7.0_91 Failed junit tests hadoop.fs.TestSymlinkLocalFSFileContext Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12783339/HADOOP-12097.02.patch JIRA Issue HADOOP-12097 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 866852092edd 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 57d0a94 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Max memory used 77MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8442/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 2s trunk passed
          +1 compile 8m 58s trunk passed with JDK v1.8.0_66
          +1 compile 9m 38s trunk passed with JDK v1.7.0_91
          +1 checkstyle 1m 6s trunk passed
          +1 mvnsite 1m 42s trunk passed
          +1 mvneclipse 0m 28s trunk passed
          +1 findbugs 3m 30s trunk passed
          +1 javadoc 1m 31s trunk passed with JDK v1.8.0_66
          +1 javadoc 1m 42s trunk passed with JDK v1.7.0_91
          +1 mvninstall 2m 7s the patch passed
          +1 compile 8m 51s the patch passed with JDK v1.8.0_66
          +1 javac 8m 51s the patch passed
          +1 compile 9m 31s the patch passed with JDK v1.7.0_91
          +1 javac 9m 31s the patch passed
          -1 checkstyle 1m 7s Patch generated 6 new checkstyle issues in root (total was 276, now 281).
          +1 mvnsite 1m 41s the patch passed
          +1 mvneclipse 0m 28s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 3m 41s the patch passed
          +1 javadoc 1m 31s the patch passed with JDK v1.8.0_66
          +1 javadoc 1m 42s the patch passed with JDK v1.7.0_91
          -1 unit 8m 31s hadoop-common in the patch failed with JDK v1.8.0_66.
          +1 unit 2m 5s hadoop-yarn-common in the patch passed with JDK v1.8.0_66.
          -1 unit 8m 3s hadoop-common in the patch failed with JDK v1.7.0_91.
          +1 unit 2m 24s hadoop-yarn-common in the patch passed with JDK v1.7.0_91.
          +1 asflicense 0m 24s Patch does not generate ASF License warnings.
          90m 15s



          Reason Tests
          JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics
          JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781558/HADOOP-12097.01.patch
          JIRA Issue HADOOP-12097
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 36abba9514b0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 76e7270
          Default Java 1.7.0_91
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt
          unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt
          JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: .
          Max memory used 76MB
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 2s trunk passed +1 compile 8m 58s trunk passed with JDK v1.8.0_66 +1 compile 9m 38s trunk passed with JDK v1.7.0_91 +1 checkstyle 1m 6s trunk passed +1 mvnsite 1m 42s trunk passed +1 mvneclipse 0m 28s trunk passed +1 findbugs 3m 30s trunk passed +1 javadoc 1m 31s trunk passed with JDK v1.8.0_66 +1 javadoc 1m 42s trunk passed with JDK v1.7.0_91 +1 mvninstall 2m 7s the patch passed +1 compile 8m 51s the patch passed with JDK v1.8.0_66 +1 javac 8m 51s the patch passed +1 compile 9m 31s the patch passed with JDK v1.7.0_91 +1 javac 9m 31s the patch passed -1 checkstyle 1m 7s Patch generated 6 new checkstyle issues in root (total was 276, now 281). +1 mvnsite 1m 41s the patch passed +1 mvneclipse 0m 28s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 3m 41s the patch passed +1 javadoc 1m 31s the patch passed with JDK v1.8.0_66 +1 javadoc 1m 42s the patch passed with JDK v1.7.0_91 -1 unit 8m 31s hadoop-common in the patch failed with JDK v1.8.0_66. +1 unit 2m 5s hadoop-yarn-common in the patch passed with JDK v1.8.0_66. -1 unit 8m 3s hadoop-common in the patch failed with JDK v1.7.0_91. +1 unit 2m 24s hadoop-yarn-common in the patch passed with JDK v1.7.0_91. +1 asflicense 0m 24s Patch does not generate ASF License warnings. 90m 15s Reason Tests JDK v1.8.0_66 Failed junit tests hadoop.metrics2.impl.TestGangliaMetrics JDK v1.7.0_91 Failed junit tests hadoop.fs.shell.TestCopyPreserveFlag Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12781558/HADOOP-12097.01.patch JIRA Issue HADOOP-12097 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 36abba9514b0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 76e7270 Default Java 1.7.0_91 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_66 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_91 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt unit https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt unit test logs https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.8.0_66.txt https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common-jdk1.7.0_91.txt JDK v1.7.0_91 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common U: . Max memory used 76MB Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/8382/console This message was automatically generated.

            People

            • Assignee:
              varun_saxena Varun Saxena
              Reporter:
              varun_saxena Varun Saxena
            • Votes:
              1 Vote for this issue
              Watchers:
              14 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development