Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12078

The default retry policy does not handle RetriableException correctly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 2.7.1, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      The default policy in RetryUtils does not retry RetriableExceptions even when defaultRetryPolicyEnabled is true.

      This was discovered via an HDFS client failing to retry getFileBlockLocations after checkNNStartup failed.

      1. HDFS-8561.01.patch
        3 kB
        Arpit Agarwal
      2. HDFS-8561.02.patch
        7 kB
        Arpit Agarwal

        Issue Links

          Activity

          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Forgot to resolve it. Thanks for the reminder Vinod Kumar Vavilapalli.

          Show
          arpitagarwal Arpit Agarwal added a comment - Forgot to resolve it. Thanks for the reminder Vinod Kumar Vavilapalli .
          Hide
          vinodkv Vinod Kumar Vavilapalli added a comment -

          Arpit Agarwal, seems like this is already committed and can be closed?

          Show
          vinodkv Vinod Kumar Vavilapalli added a comment - Arpit Agarwal , seems like this is already committed and can be closed?
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2170 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2170/)
          HADOOP-12078. The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2170 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2170/ ) HADOOP-12078 . The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #222 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/222/)
          HADOOP-12078. The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #222 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/222/ ) HADOOP-12078 . The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #213 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/213/)
          HADOOP-12078. The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #213 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/213/ ) HADOOP-12078 . The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2152 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2152/)
          HADOOP-12078. The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2152 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2152/ ) HADOOP-12078 . The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #954 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/954/)
          HADOOP-12078. The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #954 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/954/ ) HADOOP-12078 . The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #224 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/224/)
          HADOOP-12078. The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #224 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/224/ ) HADOOP-12078 . The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Thanks for the review Jing Zhao!

          The checkstyle warning and test failures are unrelated to the patch. I fixed the whitespace issue during commit. Committed for 2.7.1.

          Show
          arpitagarwal Arpit Agarwal added a comment - Thanks for the review Jing Zhao ! The checkstyle warning and test failures are unrelated to the patch. I fixed the whitespace issue during commit. Committed for 2.7.1.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7999 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7999/)
          HADOOP-12078. The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7999 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7999/ ) HADOOP-12078 . The default retry policy does not handle RetriableException correctly. (Contributed by Arpit Agarwal) (arp: rev 3107434031e0da149ea2c09c5fc76f1a152435a0) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryPolicies.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/retry/TestDefaultRetryPolicy.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/retry/RetryUtils.java
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 0s The patch command could not apply the patch during dryrun.



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12738682/HDFS-8561.02.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 3107434
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6947/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 0s The patch command could not apply the patch during dryrun. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738682/HDFS-8561.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3107434 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6947/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 19m 27s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 29s There were no new javac warning messages.
          +1 javadoc 9m 41s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 3m 17s The applied patch generated 1 new checkstyle issues (total was 57, now 57).
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 5m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 23m 9s Tests passed in hadoop-common.
          -1 hdfs tests 160m 44s Tests failed in hadoop-hdfs.
              231m 27s  



          Reason Tests
          Failed unit tests hadoop.hdfs.server.namenode.TestDeadDatanode
            hadoop.hdfs.util.TestByteArrayManager



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12738682/HDFS-8561.02.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 3c2397c
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11295/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11295/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11295/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11295/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11295/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11295/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 19m 27s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 41s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 3m 17s The applied patch generated 1 new checkstyle issues (total was 57, now 57). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 5m 7s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 23m 9s Tests passed in hadoop-common. -1 hdfs tests 160m 44s Tests failed in hadoop-hdfs.     231m 27s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestDeadDatanode   hadoop.hdfs.util.TestByteArrayManager Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738682/HDFS-8561.02.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3c2397c checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/11295/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11295/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11295/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11295/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11295/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11295/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          -1 pre-patch 16m 49s Findbugs (version ) appears to be broken on trunk.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 27s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 53s There were no new checkstyle issues.
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 5m 5s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 24m 16s Tests passed in hadoop-common.
          +1 hdfs tests 161m 32s Tests passed in hadoop-hdfs.
              229m 12s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12738640/HDFS-8561.01.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 3c2397c
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11294/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11294/artifact/patchprocess/testrun_hadoop-common.txt
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11294/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11294/testReport/
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11294/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 pre-patch 16m 49s Findbugs (version ) appears to be broken on trunk. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 27s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 53s There were no new checkstyle issues. -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 5m 5s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 24m 16s Tests passed in hadoop-common. +1 hdfs tests 161m 32s Tests passed in hadoop-hdfs.     229m 12s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12738640/HDFS-8561.01.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3c2397c whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/11294/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/11294/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/11294/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/11294/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/11294/console This message was automatically generated.
          Hide
          jingzhao Jing Zhao added a comment -

          Thanks for working on this, Arpit! The v2 patch looks good to me. +1 pending Jenkins.

          Show
          jingzhao Jing Zhao added a comment - Thanks for working on this, Arpit! The v2 patch looks good to me. +1 pending Jenkins.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          v2 includes test cases.

          Show
          arpitagarwal Arpit Agarwal added a comment - v2 includes test cases.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Patch for Jenkins run. Needs a test case.

          Show
          arpitagarwal Arpit Agarwal added a comment - Patch for Jenkins run. Needs a test case.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Effectively a regression since 2.6, although 2.6 was broken differently.

          One way to fix it is have checkNNState throw RetriableException and also fix the default retry policy.

          Show
          arpitagarwal Arpit Agarwal added a comment - Effectively a regression since 2.6, although 2.6 was broken differently. One way to fix it is have checkNNState throw RetriableException and also fix the default retry policy.

            People

            • Assignee:
              arpitagarwal Arpit Agarwal
              Reporter:
              arpitagarwal Arpit Agarwal
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development