Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-12042

Users may see TrashPolicy if hdfs dfs -rm is run

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Doing 'hdfs dfs -rm file' generates an extra log message on the console:

      14/07/29 15:18:56 INFO fs.TrashPolicyDefault: Namenode trash configuration: Deletion interval = 0 minutes, Emptier interval = 0 minutes.
      

      This shouldn't be seen by users.

      1. HDFS-6775.1.patch
        2 kB
        J.Andreina
      2. HDFS-6775.2.patch
        2 kB
        J.Andreina

        Issue Links

          Activity

          Hide
          aw Allen Wittenauer added a comment -

          I haven't played much with the trash policy stuff, but I have a few suspicions/hints. This was a fresh HDFS with a very minimal config.

          1. This was the first delete on the file system.
          2. Trash is not configured at all in *-site.xml.

          Is this an edge case?

          Show
          aw Allen Wittenauer added a comment - I haven't played much with the trash policy stuff, but I have a few suspicions/hints. This was a fresh HDFS with a very minimal config. This was the first delete on the file system. Trash is not configured at all in *-site.xml. Is this an edge case?
          Hide
          andreina J.Andreina added a comment -

          Attached an initial patch . ( Logs on trash configuration will be printed on namenode logs and not at client side)

          Please review.

          Show
          andreina J.Andreina added a comment - Attached an initial patch . ( Logs on trash configuration will be printed on namenode logs and not at client side) Please review.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 37s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 30s There were no new javac warning messages.
          +1 javadoc 9m 44s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 47, now 47).
          -1 whitespace 0m 9s The patch has 25 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 38s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 24m 6s Tests passed in hadoop-common.
              61m 29s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731703/HDFS-6775.1.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 02a4a22
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10901/artifact/patchprocess/diffcheckstylehadoop-common.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10901/artifact/patchprocess/whitespace.txt
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10901/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10901/testReport/
          Java 1.7.0_55
          uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10901/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 37s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 44s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 5s The applied patch generated 1 new checkstyle issues (total was 47, now 47). -1 whitespace 0m 9s The patch has 25 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 40s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 24m 6s Tests passed in hadoop-common.     61m 29s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731703/HDFS-6775.1.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 02a4a22 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/10901/artifact/patchprocess/diffcheckstylehadoop-common.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/10901/artifact/patchprocess/whitespace.txt hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10901/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10901/testReport/ Java 1.7.0_55 uname Linux asf900.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10901/console This message was automatically generated.
          Hide
          andreina J.Andreina added a comment -

          Updated the patch, fixing checkStyle failure.
          Kindly review.

          Show
          andreina J.Andreina added a comment - Updated the patch, fixing checkStyle failure. Kindly review.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 28s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 28s There were no new javac warning messages.
          +1 javadoc 9m 35s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 7s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 34s mvn install still works.
          +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
          +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 common tests 21m 47s Tests passed in hadoop-common.
              58m 36s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731912/HDFS-6775.2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 3fa2efc
          hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10912/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10912/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10912/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 28s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 35s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 7s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 34s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 findbugs 1m 39s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 common tests 21m 47s Tests passed in hadoop-common.     58m 36s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731912/HDFS-6775.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 3fa2efc hadoop-common test log https://builds.apache.org/job/PreCommit-HDFS-Build/10912/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/10912/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/10912/console This message was automatically generated.
          Hide
          andreina J.Andreina added a comment -

          The patch is to avoid log message displaying at client side but to redirect to namenode log.
          So no need for testcase.
          Kindly review the patch.

          Show
          andreina J.Andreina added a comment - The patch is to avoid log message displaying at client side but to redirect to namenode log. So no need for testcase. Kindly review the patch.
          Hide
          vinayrpet Vinayakumar B added a comment -

          +1, LGTM.
          Committing soon

          Show
          vinayrpet Vinayakumar B added a comment - +1, LGTM. Committing soon
          Hide
          vinayrpet Vinayakumar B added a comment -

          Committed to trunk and branch-2.
          Thanks J.Andreina

          Show
          vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2. Thanks J.Andreina
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7925 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7925/)
          HADOOP-12042. Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7925 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7925/ ) HADOOP-12042 . Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 16m 19s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 javac 7m 29s There were no new javac warning messages.
          +1 javadoc 9m 39s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 6s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 common tests 22m 7s Tests passed in hadoop-common.
              61m 1s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731912/HDFS-6775.2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / b75df69
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6869/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6869/testReport/
          Java 1.7.0_55
          uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6869/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 16m 19s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 29s There were no new javac warning messages. +1 javadoc 9m 39s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 6s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 49s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 7s Tests passed in hadoop-common.     61m 1s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731912/HDFS-6775.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / b75df69 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6869/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6869/testReport/ Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6869/console This message was automatically generated.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2140 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2140/)
          HADOOP-12042. Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2140 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2140/ ) HADOOP-12042 . Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #201 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/201/)
          HADOOP-12042. Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #201 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/201/ ) HADOOP-12042 . Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #210 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/210/)
          HADOOP-12042. Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #210 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/210/ ) HADOOP-12042 . Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #943 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/943/)
          HADOOP-12042. Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #943 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/943/ ) HADOOP-12042 . Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #213 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/213/)
          HADOOP-12042. Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #213 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/213/ ) HADOOP-12042 . Users may see TrashPolicy if hdfs dfs -rm is run (Contributed by Andreina J) (vinayakumarb: rev 7366e4256395ed7550702275d0d9f2674bd43d6c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/TrashPolicyDefault.java hadoop-common-project/hadoop-common/CHANGES.txt

            People

            • Assignee:
              andreina J.Andreina
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development