Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11991

test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      I think this condition is wrong.

        if [[ ! ${CHANGED_FILES} =~ dev-support/test-patch
            || ${CHANGED_FILES} =~ dev-support/smart-apply ]] ; then
      
      1. HADOOP-11991.004.patch
        1 kB
        Kengo Seki
      2. HADOOP-11991.003.patch
        1 kB
        Kengo Seki
      3. HADOOP-11991.002.patch
        1 kB
        Kengo Seki
      4. HADOOP-11991.001.patch
        0.8 kB
        Kengo Seki

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #206 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/206/)
          HADOOP-11991. test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #206 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/206/ ) HADOOP-11991 . test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2145 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2145/)
          HADOOP-11991. test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2145 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2145/ ) HADOOP-11991 . test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/215/)
          HADOOP-11991. test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #215 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/215/ ) HADOOP-11991 . test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2163 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2163/)
          HADOOP-11991. test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • dev-support/test-patch.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2163 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2163/ ) HADOOP-11991 . test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #947 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/947/)
          HADOOP-11991. test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e)

          • dev-support/test-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #947 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/947/ ) HADOOP-11991 . test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #217 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/217/)
          HADOOP-11991. test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e)

          • dev-support/test-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #217 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/217/ ) HADOOP-11991 . test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7947/)
          HADOOP-11991. test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e)

          • dev-support/test-patch.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7947/ ) HADOOP-11991 . test-patch.sh isn't re-executed even if smart-apply-patch.sh is modified. Contributed by Kengo Seki. (aajisaka: rev a6a8ee3c24e2457ce3ccc9a4a4e2535b223f547e) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Committed this to trunk and branch-2. Thanks Kengo Seki and Allen Wittenauer for the contribution.

          Show
          ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Kengo Seki and Allen Wittenauer for the contribution.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          +1, committing this.

          Show
          ajisakaa Akira Ajisaka added a comment - +1, committing this.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s dev-support patch detected.
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          0 @author 0m 0s Skipping @author checks as test-patch has been patched.
          +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
          +1 shellcheck 0m 8s There were no new shellcheck (v0.3.3) issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 31s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12735997/HADOOP-11991.004.patch
          Optional Tests shellcheck
          git revision trunk / 788bfa0
          Java 1.7.0_55
          uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6861/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 shellcheck 0m 8s There were no new shellcheck (v0.3.3) issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 31s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12735997/HADOOP-11991.004.patch Optional Tests shellcheck git revision trunk / 788bfa0 Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6861/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6861/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6861/console in case of problems.
          Hide
          sekikn Kengo Seki added a comment -

          Thanks, Allen! I fixed them.

          Show
          sekikn Kengo Seki added a comment - Thanks, Allen! I fixed them.
          Hide
          aw Allen Wittenauer added a comment -

          minor, minor nit:

          for QA process

          x 2

          This should be 'for the QA process'.

          Show
          aw Allen Wittenauer added a comment - minor, minor nit: for QA process x 2 This should be 'for the QA process'.
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s dev-support patch detected.
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          0 @author 0m 0s Skipping @author checks as test-patch has been patched.
          +1 release audit 0m 17s The applied patch does not increase the total number of release audit warnings.
          +1 shellcheck 0m 8s There were no new shellcheck (v0.3.3) issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 28s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12733570/HADOOP-11991.003.patch
          Optional Tests shellcheck
          git revision trunk / 182d86d
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6730/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 release audit 0m 17s The applied patch does not increase the total number of release audit warnings. +1 shellcheck 0m 8s There were no new shellcheck (v0.3.3) issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 28s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733570/HADOOP-11991.003.patch Optional Tests shellcheck git revision trunk / 182d86d Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6730/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6730/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6730/console in case of problems.
          Hide
          sekikn Kengo Seki added a comment -

          Akira Ajisaka Allen Wittenauer thank you for your comments!

          -03

          • rendered the description lines within 80 characters
          • tried to make the description and output message more generic (but please correct if my representation is unnatural)
          Show
          sekikn Kengo Seki added a comment - Akira Ajisaka Allen Wittenauer thank you for your comments! -03 rendered the description lines within 80 characters tried to make the description and output message more generic (but please correct if my representation is unnatural)
          Hide
          aw Allen Wittenauer added a comment -

          Also it should be "if this actually patches". Also, as more stuff gets added to the test-patch bits (like the docker stuff), this description is going to be continually out of date... So something more generic would be better for the long haul.

          Show
          aw Allen Wittenauer added a comment - Also it should be "if this actually patches". Also, as more stuff gets added to the test-patch bits (like the docker stuff), this description is going to be continually out of date... So something more generic would be better for the long haul.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Thanks Kengo Seki for the clarification and updating the patch. Mostly looks good to me.

          -## @description  If this patches actually patches test-patch.sh, then
          +## @description  If this patches actually patches test-patch.sh, smart-apply-patch.sh or the files under test-patch.d, then
           ## @description  run with the patched version for the test.
          

          Minor nit: Would you render the line within 80 characters?

          Show
          ajisakaa Akira Ajisaka added a comment - Thanks Kengo Seki for the clarification and updating the patch. Mostly looks good to me. -## @description If this patches actually patches test-patch.sh, then +## @description If this patches actually patches test-patch.sh, smart-apply-patch.sh or the files under test-patch.d, then ## @description run with the patched version for the test. Minor nit: Would you render the line within 80 characters?
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s dev-support patch detected.
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          0 @author 0m 0s Skipping @author checks as test-patch has been patched.
          +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings.
          +1 shellcheck 0m 8s There were no new shellcheck (v0.3.3) issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 26s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12733554/HADOOP-11991.002.patch
          Optional Tests shellcheck
          git revision trunk / a6af024
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6728/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings. +1 shellcheck 0m 8s There were no new shellcheck (v0.3.3) issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 26s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733554/HADOOP-11991.002.patch Optional Tests shellcheck git revision trunk / a6af024 Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6728/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6728/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6728/console in case of problems.
          Hide
          sekikn Kengo Seki added a comment -

          -02:

          • modified the description and output message of this function to clarify its target.
          Show
          sekikn Kengo Seki added a comment - -02: modified the description and output message of this function to clarify its target.
          Hide
          sekikn Kengo Seki added a comment -

          Akira Ajisaka thank you for the comment. The current script is re-exec'ed if any files under test-patch.d are changed, because pattern "dev-support/test-patch" matches dev-support/test-patch.d/*.
          I think the description of this function is inaccurate. It says "If this patches actually patches test-patch.sh, then ...", but not only test-patch.sh, test-patch.d and smart-apply-patch.sh are also included. So I'll fix it.

          Show
          sekikn Kengo Seki added a comment - Akira Ajisaka thank you for the comment. The current script is re-exec'ed if any files under test-patch.d are changed, because pattern "dev-support/test-patch" matches dev-support/test-patch.d/*. I think the description of this function is inaccurate. It says "If this patches actually patches test-patch.sh, then ...", but not only test-patch.sh, test-patch.d and smart-apply-patch.sh are also included. So I'll fix it.
          Hide
          ajisakaa Akira Ajisaka added a comment -

          Nice catch. Could you update the patch to re-execute test-patch.sh if any files in test-patch.d (e.g. checkstyle.sh) is changed?

          Show
          ajisakaa Akira Ajisaka added a comment - Nice catch. Could you update the patch to re-execute test-patch.sh if any files in test-patch.d (e.g. checkstyle.sh) is changed?
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s dev-support patch detected.
          0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
          0 @author 0m 0s Skipping @author checks as test-patch has been patched.
          +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings.
          +1 shellcheck 0m 8s There were no new shellcheck (v0.3.3) issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
              0m 26s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12733439/HADOOP-11991.001.patch
          Optional Tests shellcheck
          git revision trunk / cab0dad
          Java 1.7.0_55
          uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6724/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 release audit 0m 15s The applied patch does not increase the total number of release audit warnings. +1 shellcheck 0m 8s There were no new shellcheck (v0.3.3) issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 26s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12733439/HADOOP-11991.001.patch Optional Tests shellcheck git revision trunk / cab0dad Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6724/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          A patch to test-patch or smart-apply-patch has been detected.
          Re-executing against the patched versions to perform further tests.
          The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6724/console in case of problems.

          Show
          hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6724/console in case of problems.
          Hide
          sekikn Kengo Seki added a comment -

          Attaching a patch.

          Show
          sekikn Kengo Seki added a comment - Attaching a patch.

            People

            • Assignee:
              sekikn Kengo Seki
              Reporter:
              sekikn Kengo Seki
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development