Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: net
    • Labels:
      None
    • Environment:

      Solaris

      Description

      The FIONREAD macro is found in <sys/ioctl.h> on Linux and <sys/filio.h> on Solaris. A conditional include block is required to make sure it is looked for in the right place.

        Activity

        Hide
        alanburlison Alan Burlison added a comment -

        Patch attached

        Show
        alanburlison Alan Burlison added a comment - Patch attached
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 5m 14s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 31s There were no new javac warning messages.
        +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 31s mvn install still works.
        +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
        +1 common tests 22m 9s Tests passed in hadoop-common.
            37m 20s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12741633/HADOOP-11974.001.patch
        Optional Tests javac unit
        git revision trunk / 80a68d6
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7127/artifact/patchprocess/testrun_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7127/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7127/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 5m 14s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 31s There were no new javac warning messages. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 31s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 common tests 22m 9s Tests passed in hadoop-common.     37m 20s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12741633/HADOOP-11974.001.patch Optional Tests javac unit git revision trunk / 80a68d6 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7127/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7127/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7127/console This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1. Thanks, Alan Burlison.

        Show
        cmccabe Colin P. McCabe added a comment - +1. Thanks, Alan Burlison .
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8120 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8120/)
        HADOOP-11974. Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71)

        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8120 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8120/ ) HADOOP-11974 . Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #979 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/979/)
        HADOOP-11974. Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71)

        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #979 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/979/ ) HADOOP-11974 . Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #249 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/249/)
        HADOOP-11974. Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71)

        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #249 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/249/ ) HADOOP-11974 . Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #247 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/247/)
        HADOOP-11974. Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71)

        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #247 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/247/ ) HADOOP-11974 . Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2195 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2195/)
        HADOOP-11974. Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71)

        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2195 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2195/ ) HADOOP-11974 . Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71) hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2176/)
        HADOOP-11974. Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2176/ ) HADOOP-11974 . Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #237 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/237/)
        HADOOP-11974. Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #237 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/237/ ) HADOOP-11974 . Fix FIONREAD #include on Solaris (Alan Burlison via Colin P. McCabe) (cmccabe: rev 81f364437608b21e85fc393f63546bf8b425ac71) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/native/src/org/apache/hadoop/net/unix/DomainSocket.c

          People

          • Assignee:
            alanburlison Alan Burlison
            Reporter:
            alanburlison Alan Burlison
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development