Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11971

Move test utilities for tracing from hadoop-hdfs to hadoop-common

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: tracing
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Utilities used in TestTracing such as SetSpanReceiver should be moved to hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/ in order to make it usable from yarn and other modules.

      1. HADOOP-11971.001.patch
        11 kB
        Masatake Iwasaki

        Activity

        Hide
        iwasakims Masatake Iwasaki added a comment -

        I attached the patch to move SetSpanReceiver from hadoop-hdfs to hadoop-common.

        Show
        iwasakims Masatake Iwasaki added a comment - I attached the patch to move SetSpanReceiver from hadoop-hdfs to hadoop-common.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 10m 12s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 tests included 0m 0s The patch appears to include 3 new or modified test files.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings.
        +1 checkstyle 2m 40s There were no new checkstyle issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 38s mvn install still works.
        +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse.
        +1 findbugs 5m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
        +1 common tests 22m 16s Tests passed in hadoop-common.
        -1 hdfs tests 160m 45s Tests failed in hadoop-hdfs.
            210m 57s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.TestAppendSnapshotTruncate



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12737454/HADOOP-11971.001.patch
        Optional Tests javac unit findbugs checkstyle
        git revision trunk / b5f0d29
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6914/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6914/artifact/patchprocess/testrun_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6914/testReport/
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6914/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 10m 12s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 3 new or modified test files. +1 javac 7m 30s There were no new javac warning messages. +1 release audit 0m 19s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 2m 40s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 31s The patch built with eclipse:eclipse. +1 findbugs 5m 3s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 common tests 22m 16s Tests passed in hadoop-common. -1 hdfs tests 160m 45s Tests failed in hadoop-hdfs.     210m 57s   Reason Tests Failed unit tests hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.TestAppendSnapshotTruncate Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12737454/HADOOP-11971.001.patch Optional Tests javac unit findbugs checkstyle git revision trunk / b5f0d29 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6914/artifact/patchprocess/testrun_hadoop-common.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6914/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6914/testReport/ Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6914/console This message was automatically generated.
        Hide
        iwasakims Masatake Iwasaki added a comment -

        The code path changed by the patch is only related to TestTracing*. TestRollingUpgrade and TestAppendSnapshotTruncate are succeeded on my environment.

        Show
        iwasakims Masatake Iwasaki added a comment - The code path changed by the patch is only related to TestTracing*. TestRollingUpgrade and TestAppendSnapshotTruncate are succeeded on my environment.
        Hide
        cmccabe Colin P. McCabe added a comment -

        +1

        Show
        cmccabe Colin P. McCabe added a comment - +1
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Looks good to me, +1. Committing this.

        Show
        ajisakaa Akira Ajisaka added a comment - Looks good to me, +1. Committing this.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        Committed this to trunk and branch-2. Thanks Masatake Iwasaki and Colin P. McCabe for the contribution.

        Show
        ajisakaa Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Masatake Iwasaki and Colin P. McCabe for the contribution.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #8010 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8010/)
        HADOOP-11971. Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #8010 (See https://builds.apache.org/job/Hadoop-trunk-Commit/8010/ ) HADOOP-11971 . Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #227 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/227/)
        HADOOP-11971. Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #227 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/227/ ) HADOOP-11971 . Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #957 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/957/)
        HADOOP-11971. Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #957 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/957/ ) HADOOP-11971 . Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2155 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2155/)
        HADOOP-11971. Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2155 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2155/ ) HADOOP-11971 . Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #216 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/216/)
        HADOOP-11971. Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #216 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/216/ ) HADOOP-11971 . Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #225 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/225/)
        HADOOP-11971. Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #225 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/225/ ) HADOOP-11971 . Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2173 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2173/)
        HADOOP-11971. Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2173 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2173/ ) HADOOP-11971 . Move test utilities for tracing from hadoop-hdfs to hadoop-common. Contributed by Masatake Iwasaki. (aajisaka: rev e4489d97e5f0cec601b93e1b883fa194a7353229) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/SetSpanReceiver.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracingShortCircuitLocalRead.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/tracing/TestTracing.java

          People

          • Assignee:
            iwasakims Masatake Iwasaki
            Reporter:
            iwasakims Masatake Iwasaki
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development