[HADOOP-11924] Tolerate JDK-8047340-related exceptions in Shell#isSetSidAvailable preventing class init

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.8.0
• Fix Version/s: 2.8.0, 3.0.0-alpha1
• Hadoop Flags: Reviewed
• Assignee: Tsuyoshi Ozawa
• Reporter: Gera Shegalov
• Created: 05/May/15 18:08
• Updated: 30/Aug/16 01:28
• Resolved: 04/Jun/15 18:56

Description

Address the root cause of HADOOP-11916 per https://issues.apache.org/jira/browse/HADOOP-11916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14528009#comment-14528009

JDK-8047340 explicitly calls out BSD-like systems, should not we just exclude those systems instead of enabling solely Linux?

Assume.assumeFalse("Avoiding JDK-8047340 on BSD-based systems", Shell.FREEBSD || Shell.MAC);

However, I don't think this is the right fix. Shell on BSD-like systems is broken with the TR locale. Shell class initialization happens only because StringUtils references Shell.WINDOWS.

We can simply catch Throwable in Shell#isSetsidSupported instead of IOException. If we want to be pedantic we can rethrow

if (!(t instanceof IOException) && !(Shell.FREEBSD || Shell.MAC))

With such a change the test can run unchanged.

Issue Links

• relates to: HADOOP-11916 TestStringUtils#testLowerAndUpperStrings failed on MAC due to a JVM bug