Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11912

Extra configuration key used in TraceUtils should respect prefix

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      HDFS-8213 added prefix handling to configuration used by tracing but extra key value pairs in configuration returned by TraceUtils#wrapHadoopConf does not respect this.

        Issue Links

          Activity

          Hide
          iwasakims Masatake Iwasaki added a comment -

          I attached the patch.

          Show
          iwasakims Masatake Iwasaki added a comment - I attached the patch.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 5s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 7m 39s There were no new javac warning messages.
          +1 javadoc 9m 58s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          +1 checkstyle 1m 6s There were no new checkstyle issues.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 36s mvn install still works.
          +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse.
          +1 findbugs 1m 44s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          -1 common tests 22m 55s Tests failed in hadoop-common.
              61m 1s  



          Reason Tests
          Failed unit tests hadoop.ipc.TestRPCWaitForProxy



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12730364/HADOOP-11912.001.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 338e88a
          hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6483/artifact/patchprocess/testrun_hadoop-common.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6483/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6483/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 5s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 7m 39s There were no new javac warning messages. +1 javadoc 9m 58s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 checkstyle 1m 6s There were no new checkstyle issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 36s mvn install still works. +1 eclipse:eclipse 0m 32s The patch built with eclipse:eclipse. +1 findbugs 1m 44s The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 common tests 22m 55s Tests failed in hadoop-common.     61m 1s   Reason Tests Failed unit tests hadoop.ipc.TestRPCWaitForProxy Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730364/HADOOP-11912.001.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 338e88a hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6483/artifact/patchprocess/testrun_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6483/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6483/console This message was automatically generated.
          Hide
          cmccabe Colin P. McCabe added a comment -

          +1. Thanks, Masatake Iwasaki.

          Show
          cmccabe Colin P. McCabe added a comment - +1. Thanks, Masatake Iwasaki .
          Hide
          cmccabe Colin P. McCabe added a comment -

          Test failure is unrelated and does not reproduce when I run it locally. Committed to 2.8.

          Show
          cmccabe Colin P. McCabe added a comment - Test failure is unrelated and does not reproduce when I run it locally. Committed to 2.8.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7744 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7744/)
          HADOOP-11912. Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7744 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7744/ ) HADOOP-11912 . Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/186/)
          HADOOP-11912. Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5)

          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/186/ ) HADOOP-11912 . Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #919 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/919/)
          HADOOP-11912. Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #919 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/919/ ) HADOOP-11912 . Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2117/)
          HADOOP-11912. Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2117 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2117/ ) HADOOP-11912 . Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/176/)
          HADOOP-11912. Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #176 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/176/ ) HADOOP-11912 . Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2135/)
          HADOOP-11912. Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2135 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2135/ ) HADOOP-11912 . Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/186/)
          HADOOP-11912. Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5)

          • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #186 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/186/ ) HADOOP-11912 . Extra configuration key used in TraceUtils should respect prefix (Masatake Iwasaki via Colin P. McCabe) (cmccabe: rev 90b384564875bb353224630e501772b46d4ca9c5) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/tracing/TestTraceUtils.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/tracing/TraceUtils.java
          Hide
          kihwal Kihwal Lee added a comment -

          TestTraceAdmin#testCreateAndDestroySpanReceiver in HDFS is broken after this. Filed HADOOP-11940.

          Show
          kihwal Kihwal Lee added a comment - TestTraceAdmin#testCreateAndDestroySpanReceiver in HDFS is broken after this. Filed HADOOP-11940 .
          Hide
          cmccabe Colin P. McCabe added a comment -

          Thanks, Kihwal Lee.

          Show
          cmccabe Colin P. McCabe added a comment - Thanks, Kihwal Lee .

            People

            • Assignee:
              iwasakims Masatake Iwasaki
              Reporter:
              iwasakims Masatake Iwasaki
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development