Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11898

add nfs3 and portmap starting command in hadoop-daemon.sh in branch-2

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.8.0
    • Component/s: bin, nfs
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      nfs3 and portmap should also be in the list:

          case $command in
            namenode|secondarynamenode|datanode|journalnode|dfs|dfsadmin|fsck|balancer|zkfc)
              if [ -z "$HADOOP_HDFS_HOME" ]; then
                hdfsScript="$HADOOP_PREFIX"/bin/hdfs
              else
                hdfsScript="$HADOOP_HDFS_HOME"/bin/hdfs
              fi
              nohup nice -n $HADOOP_NICENESS $hdfsScript --config $HADOOP_CONF_DIR $command "$@" > "$log" 2>&1 < /dev/null &
            ;;
            (*)
              nohup nice -n $HADOOP_NICENESS $hadoopScript --config $HADOOP_CONF_DIR $command "$@" > "$log" 2>&1 < /dev/null &
            ;;
      
      1. HADOOOP-11898.001.patch
        0.7 kB
        Brandon Li
      2. HADOOOP-11898.branch-2.patch
        0.7 kB
        Brandon Li
      3. HADOOOP-11898-branch-2.001.patch
        0.7 kB
        Brandon Li

        Activity

        Hide
        brandonli Brandon Li added a comment -

        Uploaded a patch.

        Show
        brandonli Brandon Li added a comment - Uploaded a patch.
        Hide
        jingzhao Jing Zhao added a comment -

        +1 pending Jenkins.

        Show
        jingzhao Jing Zhao added a comment - +1 pending Jenkins.
        Hide
        brandonli Brandon Li added a comment -

        Renamed the patch with correct branch name to trigger the Jenkins run for branch-2.

        Show
        brandonli Brandon Li added a comment - Renamed the patch with correct branch name to trigger the Jenkins run for branch-2.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 0m 0s Pre-patch branch-2 compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 patch 0m 0s The patch command could not apply the patch.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729854/HADOOOP-11898.branch-2.patch
        Optional Tests shellcheck
        git revision branch-2 / 4151e57
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6244/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch branch-2 compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 patch 0m 0s The patch command could not apply the patch. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729854/HADOOOP-11898.branch-2.patch Optional Tests shellcheck git revision branch-2 / 4151e57 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6244/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 0m 0s Pre-patch branch-2 compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 patch 0m 0s The patch command could not apply the patch.



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730314/HADOOOP-11898-branch-2.001.patch
        Optional Tests shellcheck
        git revision branch-2 / f71c49c
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6480/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch branch-2 compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 patch 0m 0s The patch command could not apply the patch. Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730314/HADOOOP-11898-branch-2.001.patch Optional Tests shellcheck git revision branch-2 / f71c49c Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6480/console This message was automatically generated.
        Hide
        brandonli Brandon Li added a comment -

        Allen Wittenauer, could you please let me know if the path is not named properly? It's a tiny patch and I manually apply it to branch-2 with no problem. Thanks!

        Show
        brandonli Brandon Li added a comment - Allen Wittenauer , could you please let me know if the path is not named properly? It's a tiny patch and I manually apply it to branch-2 with no problem. Thanks!
        Hide
        aw Allen Wittenauer added a comment -

        git revision branch-2 / f71c49c

        So it's switching to branch-2 according to that. It's failing because branch-2's smart-apply-patch.sh doesn't support dry-run mode. So when test-patch.sh is checking to see if the patch could be applied, it is actually getting applied. Then later when test-patch.sh wants it applied for real, it's already applied and the patch application fails.

        The fix here is update smart-apply-patch.sh.

        Show
        aw Allen Wittenauer added a comment - git revision branch-2 / f71c49c So it's switching to branch-2 according to that. It's failing because branch-2's smart-apply-patch.sh doesn't support dry-run mode. So when test-patch.sh is checking to see if the patch could be applied, it is actually getting applied. Then later when test-patch.sh wants it applied for real, it's already applied and the patch application fails. The fix here is update smart-apply-patch.sh.
        Hide
        aw Allen Wittenauer added a comment -

        filed HADOOP-11925 to update it.

        Show
        aw Allen Wittenauer added a comment - filed HADOOP-11925 to update it.
        Hide
        brandonli Brandon Li added a comment -

        Thank you, Allen. I will trigger the build again after HADOOP-11925 is resolved.

        Show
        brandonli Brandon Li added a comment - Thank you, Allen. I will trigger the build again after HADOOP-11925 is resolved.
        Hide
        aw Allen Wittenauer added a comment -

        Kicked off a rebuild.

        Show
        aw Allen Wittenauer added a comment - Kicked off a rebuild.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 0m 0s Pre-patch branch-2 compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 release audit 0m 14s The applied patch does not increase the total number of release audit warnings.
        0 shellcheck 0m 14s Shellcheck was not available.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            0m 20s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12730314/HADOOOP-11898-branch-2.001.patch
        Optional Tests shellcheck
        git revision branch-2 / f95fd5b
        Java 1.7.0_55
        uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6488/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 0m 0s Pre-patch branch-2 compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 release audit 0m 14s The applied patch does not increase the total number of release audit warnings. 0 shellcheck 0m 14s Shellcheck was not available. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 20s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12730314/HADOOOP-11898-branch-2.001.patch Optional Tests shellcheck git revision branch-2 / f95fd5b Java 1.7.0_55 uname Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6488/console This message was automatically generated.
        Hide
        brandonli Brandon Li added a comment -

        Thank you, Allen and Jing. I've committed the patch to branch-2.

        Show
        brandonli Brandon Li added a comment - Thank you, Allen and Jing. I've committed the patch to branch-2.

          People

          • Assignee:
            brandonli Brandon Li
            Reporter:
            brandonli Brandon Li
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development