Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11885

hadoop-dist dist-layout-stitching.sh does not work with dash

    Details

    • Target Version/s:

      Description

      Saw this while building the EC branch, pretty sure it'll repro on trunk though too.

           [exec] ./dist-layout-stitching.sh: 53: [: bin: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: etc: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: lib: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: libexec: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: sbin: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: share: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: share: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: bin: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: etc: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: include: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: lib: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: libexec: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: sbin: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: share: unexpected operator
           [exec] $ copy /home/andrew/dev/hadoop/hdfs-7285/hadoop-common-project/hadoop-nfs/target/hadoop-nfs-3.0.0-SNAPSHOT .
           [exec] $ copy /home/andrew/dev/hadoop/hdfs-7285/hadoop-hdfs-project/hadoop-hdfs/target/hadoop-hdfs-3.0.0-SNAPSHOT .
           [exec] $ copy /home/andrew/dev/hadoop/hdfs-7285/hadoop-hdfs-project/hadoop-hdfs-nfs/target/hadoop-hdfs-nfs-3.0.0-SNAPSHOT .
           [exec] $ copy /home/andrew/dev/hadoop/hdfs-7285/hadoop-yarn-project/target/hadoop-yarn-project-3.0.0-SNAPSHOT .
           [exec] ./dist-layout-stitching.sh: 53: [: share: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: bin: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: etc: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: libexec: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: sbin: unexpected operator
           [exec] $ copy /home/andrew/dev/hadoop/hdfs-7285/hadoop-mapreduce-project/target/hadoop-mapreduce-3.0.0-SNAPSHOT .
           [exec] $ copy /home/andrew/dev/hadoop/hdfs-7285/hadoop-tools/hadoop-tools-dist/target/hadoop-tools-dist-3.0.0-SNAPSHOT .
           [exec] ./dist-layout-stitching.sh: 53: [: share: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: bin: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: etc: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: libexec: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: sbin: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: share: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: include: unexpected operator
           [exec] ./dist-layout-stitching.sh: 53: [: share: unexpected operator
      
      1. hadoop-11885.001.patch
        9 kB
        Andrew Wang
      2. hadoop-11885.002.patch
        10 kB
        Andrew Wang

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        I see this line in the pom.xml:

                            <exec executable="sh" dir="${project.build.directory}" failonerror="true">
                              <arg line="./dist-layout-stitching.sh"/>
                            </exec>
        

        sh is dash by default on ubuntu. I tried invoking it directly with dash, got the above errors. When I tried it with bash, it worked.

        Fix might be as easy as changing "sh" to instead be "bash".

        Show
        andrew.wang Andrew Wang added a comment - I see this line in the pom.xml: <exec executable="sh" dir="${project.build.directory}" failonerror="true"> <arg line="./dist-layout-stitching.sh"/> </exec> sh is dash by default on ubuntu. I tried invoking it directly with dash, got the above errors. When I tried it with bash, it worked. Fix might be as easy as changing "sh" to instead be "bash".
        Hide
        andrew.wang Andrew Wang added a comment -

        Allen Wittenauer I think you were the last person to touch this script, any thoughts?

        Show
        andrew.wang Andrew Wang added a comment - Allen Wittenauer I think you were the last person to touch this script, any thoughts?
        Hide
        aw Allen Wittenauer added a comment -

        Actually, I committed the last change but it wasn't my change... you'd know if it was mine.

        Ideally, assuming we want to keep this as a separate script and not something that maven does itself using maven facilities (I think Sean Busbey mentioned assemblies), it should really get pushed into dev-support and then rewritten to use modern shell practices, etc, etc. That way shellcheck could pick it up, etc.

        Show
        aw Allen Wittenauer added a comment - Actually, I committed the last change but it wasn't my change... you'd know if it was mine. Ideally, assuming we want to keep this as a separate script and not something that maven does itself using maven facilities (I think Sean Busbey mentioned assemblies), it should really get pushed into dev-support and then rewritten to use modern shell practices, etc, etc. That way shellcheck could pick it up, etc.
        Hide
        aw Allen Wittenauer added a comment -

        Oh, FWIW, it was decided a while back (like 0.x days) that the official shell was going to be bash. So I agree that forcing this to bash should be a quick and 'legal' fix.

        Show
        aw Allen Wittenauer added a comment - Oh, FWIW, it was decided a while back (like 0.x days) that the official shell was going to be bash. So I agree that forcing this to bash should be a quick and 'legal' fix.
        Hide
        andrew.wang Andrew Wang added a comment -

        Thanks for commenting Allen. This attached patch changes "sh" to "bash" where my grep found it.

        I'm also somewhat puzzled why dash doesn't end up with a non-zero error code when it's spitting all these parse errors. I played with -e and the run() wrapper to no avail. This is pretty scary to me since it means we are silently ignoring errors. If you have a sec, would appreciate a quick look from a more experienced shell scripter.

        -> % mvn -f hadoop-dist/pom.xml package -Pdist
        ...or...
        -> % dash target/dist-layout-stitching.sh
        

        Sounds like we really need that dev-support refactor, or maven assembly.

        Show
        andrew.wang Andrew Wang added a comment - Thanks for commenting Allen. This attached patch changes "sh" to "bash" where my grep found it. I'm also somewhat puzzled why dash doesn't end up with a non-zero error code when it's spitting all these parse errors. I played with -e and the run() wrapper to no avail. This is pretty scary to me since it means we are silently ignoring errors. If you have a sec, would appreciate a quick look from a more experienced shell scripter. -> % mvn -f hadoop-dist/pom.xml package -Pdist ...or... -> % dash target/dist-layout-stitching.sh Sounds like we really need that dev-support refactor, or maven assembly.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Nice catch..Shall I post patch ..?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Nice catch..Shall I post patch ..?
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 28s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 javac 7m 31s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 common tests 23m 25s Tests passed in hadoop-common.
        +1 common tests 1m 37s Tests passed in hadoop-kms.
        +1 dist tests 0m 15s Tests passed in hadoop-dist.
        +1 mapreduce tests 10m 7s Tests passed in hadoop-mapreduce-client-nativetask.
        +1 yarn tests 5m 58s Tests passed in hadoop-yarn-server-nodemanager.
        -1 hdfs tests 164m 30s Tests failed in hadoop-hdfs.
        +1 hdfs tests 3m 32s Tests passed in hadoop-hdfs-httpfs.
            243m 30s  



        Reason Tests
        Failed unit tests hadoop.hdfs.TestEncryptionZonesWithKMS



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729014/hadoop-11885.001.patch
        Optional Tests javadoc javac unit
        git revision trunk / 439614b
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-kms test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-kms.txt
        hadoop-dist test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-dist.txt
        hadoop-mapreduce-client-nativetask test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-mapreduce-client-nativetask.txt
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-hdfs.txt
        hadoop-hdfs-httpfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-hdfs-httpfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/testReport/
        Java 1.7.0_55
        uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 28s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 31s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 common tests 23m 25s Tests passed in hadoop-common. +1 common tests 1m 37s Tests passed in hadoop-kms. +1 dist tests 0m 15s Tests passed in hadoop-dist. +1 mapreduce tests 10m 7s Tests passed in hadoop-mapreduce-client-nativetask. +1 yarn tests 5m 58s Tests passed in hadoop-yarn-server-nodemanager. -1 hdfs tests 164m 30s Tests failed in hadoop-hdfs. +1 hdfs tests 3m 32s Tests passed in hadoop-hdfs-httpfs.     243m 30s   Reason Tests Failed unit tests hadoop.hdfs.TestEncryptionZonesWithKMS Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729014/hadoop-11885.001.patch Optional Tests javadoc javac unit git revision trunk / 439614b hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-common.txt hadoop-kms test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-kms.txt hadoop-dist test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-dist.txt hadoop-mapreduce-client-nativetask test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-mapreduce-client-nativetask.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-httpfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/artifact/patchprocess/testrun_hadoop-hdfs-httpfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/testReport/ Java 1.7.0_55 uname Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6209/console This message was automatically generated.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        better to make the shell exe name a property, then you can change it to sh. bash, whatever in one place, instead of doing another search & replace

        Show
        stevel@apache.org Steve Loughran added a comment - better to make the shell exe name a property, then you can change it to sh. bash, whatever in one place, instead of doing another search & replace
        Hide
        aw Allen Wittenauer added a comment -

        hdfs tests 164m 30s Tests failed in hadoop-hdfs.

        As expected, half the test time is in hdfs. We're going to have to increase the jenkins time out values again soon.

        Show
        aw Allen Wittenauer added a comment - hdfs tests 164m 30s Tests failed in hadoop-hdfs. As expected, half the test time is in hdfs. We're going to have to increase the jenkins time out values again soon.
        Hide
        andrew.wang Andrew Wang added a comment -

        Did another sed to use a maven property. I did a full -Pdist build okay so I think life is okay, despite Jenkins thinking otherwise.

        Show
        andrew.wang Andrew Wang added a comment - Did another sed to use a maven property. I did a full -Pdist build okay so I think life is okay, despite Jenkins thinking otherwise.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 27s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 javac 7m 28s There were no new javac warning messages.
        +1 javadoc 9m 29s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 common tests 23m 34s Tests passed in hadoop-common.
        +1 common tests 1m 38s Tests passed in hadoop-kms.
        +1 dist tests 0m 13s Tests passed in hadoop-dist.
        +1 mapreduce tests 10m 13s Tests passed in hadoop-mapreduce-client-nativetask.
        +1 yarn tests 5m 49s Tests passed in hadoop-yarn-server-nodemanager.
        -1 hdfs tests 225m 32s Tests failed in hadoop-hdfs.
        +1 hdfs tests 3m 37s Tests passed in hadoop-hdfs-httpfs.
            304m 31s  



        Reason Tests
        Failed unit tests hadoop.hdfs.server.namenode.TestDeleteRace
          hadoop.hdfs.TestClose
          hadoop.hdfs.TestDFSClientRetries
          hadoop.hdfs.TestQuota
          hadoop.hdfs.TestMultiThreadedHflush
          hadoop.hdfs.TestDFSOutputStream
          hadoop.hdfs.server.namenode.TestSaveNamespace
          hadoop.hdfs.server.datanode.TestBlockRecovery
          hadoop.cli.TestHDFSCLI
          hadoop.hdfs.TestFileLengthOnClusterRestart
          hadoop.hdfs.TestCrcCorruption
          hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation
        Timed out tests org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache
          org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery
          org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
          org.apache.hadoop.hdfs.TestDataTransferProtocol



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729396/hadoop-11885.002.patch
        Optional Tests javadoc javac unit
        git revision trunk / aa22450
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-kms test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-kms.txt
        hadoop-dist test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-dist.txt
        hadoop-mapreduce-client-nativetask test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-mapreduce-client-nativetask.txt
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-hdfs.txt
        hadoop-hdfs-httpfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-hdfs-httpfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/testReport/
        Java 1.7.0_55
        uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 27s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 javac 7m 28s There were no new javac warning messages. +1 javadoc 9m 29s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 common tests 23m 34s Tests passed in hadoop-common. +1 common tests 1m 38s Tests passed in hadoop-kms. +1 dist tests 0m 13s Tests passed in hadoop-dist. +1 mapreduce tests 10m 13s Tests passed in hadoop-mapreduce-client-nativetask. +1 yarn tests 5m 49s Tests passed in hadoop-yarn-server-nodemanager. -1 hdfs tests 225m 32s Tests failed in hadoop-hdfs. +1 hdfs tests 3m 37s Tests passed in hadoop-hdfs-httpfs.     304m 31s   Reason Tests Failed unit tests hadoop.hdfs.server.namenode.TestDeleteRace   hadoop.hdfs.TestClose   hadoop.hdfs.TestDFSClientRetries   hadoop.hdfs.TestQuota   hadoop.hdfs.TestMultiThreadedHflush   hadoop.hdfs.TestDFSOutputStream   hadoop.hdfs.server.namenode.TestSaveNamespace   hadoop.hdfs.server.datanode.TestBlockRecovery   hadoop.cli.TestHDFSCLI   hadoop.hdfs.TestFileLengthOnClusterRestart   hadoop.hdfs.TestCrcCorruption   hadoop.hdfs.server.datanode.fsdataset.impl.TestRbwSpaceReservation Timed out tests org.apache.hadoop.hdfs.server.namenode.TestNamenodeRetryCache   org.apache.hadoop.hdfs.TestClientProtocolForPipelineRecovery   org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   org.apache.hadoop.hdfs.TestDataTransferProtocol Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729396/hadoop-11885.002.patch Optional Tests javadoc javac unit git revision trunk / aa22450 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-common.txt hadoop-kms test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-kms.txt hadoop-dist test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-dist.txt hadoop-mapreduce-client-nativetask test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-mapreduce-client-nativetask.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-httpfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/artifact/patchprocess/testrun_hadoop-hdfs-httpfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6225/console This message was automatically generated.
        Hide
        andrew.wang Andrew Wang added a comment -

        I'm retriggering the build, some of the tests failed with "directory locked" (Jenkins issue) and the other look like flake timeouts. This is the most flakes I've seen in a while

        Show
        andrew.wang Andrew Wang added a comment - I'm retriggering the build, some of the tests failed with "directory locked" (Jenkins issue) and the other look like flake timeouts. This is the most flakes I've seen in a while
        Hide
        aw Allen Wittenauer added a comment -

        There are a ton of HDFS unit tests running, bogging down the boxes.

        Show
        aw Allen Wittenauer added a comment - There are a ton of HDFS unit tests running, bogging down the boxes.
        Hide
        hadoopqa Hadoop QA added a comment -



        -1 overall



        Vote Subsystem Runtime Comment
        0 pre-patch 14m 35s Pre-patch trunk compilation is healthy.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 javac 7m 30s There were no new javac warning messages.
        +1 javadoc 9m 37s There were no new javadoc warning messages.
        +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
        +1 install 1m 32s mvn install still works.
        +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse.
        +1 common tests 22m 14s Tests passed in hadoop-common.
        +1 common tests 1m 38s Tests passed in hadoop-kms.
        +1 dist tests 0m 13s Tests passed in hadoop-dist.
        +1 mapreduce tests 10m 5s Tests passed in hadoop-mapreduce-client-nativetask.
        +1 yarn tests 5m 49s Tests passed in hadoop-yarn-server-nodemanager.
        +1 hdfs tests 164m 29s Tests passed in hadoop-hdfs.
        +1 hdfs tests 3m 34s Tests passed in hadoop-hdfs-httpfs.
            242m 17s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729396/hadoop-11885.002.patch
        Optional Tests javadoc javac unit
        git revision trunk / 98a6176
        hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-common.txt
        hadoop-kms test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-kms.txt
        hadoop-dist test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-dist.txt
        hadoop-mapreduce-client-nativetask test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-mapreduce-client-nativetask.txt
        hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt
        hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-hdfs.txt
        hadoop-hdfs-httpfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-hdfs-httpfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/testReport/
        Java 1.7.0_55
        uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 35s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac 7m 30s There were no new javac warning messages. +1 javadoc 9m 37s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 32s mvn install still works. +1 eclipse:eclipse 0m 33s The patch built with eclipse:eclipse. +1 common tests 22m 14s Tests passed in hadoop-common. +1 common tests 1m 38s Tests passed in hadoop-kms. +1 dist tests 0m 13s Tests passed in hadoop-dist. +1 mapreduce tests 10m 5s Tests passed in hadoop-mapreduce-client-nativetask. +1 yarn tests 5m 49s Tests passed in hadoop-yarn-server-nodemanager. +1 hdfs tests 164m 29s Tests passed in hadoop-hdfs. +1 hdfs tests 3m 34s Tests passed in hadoop-hdfs-httpfs.     242m 17s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729396/hadoop-11885.002.patch Optional Tests javadoc javac unit git revision trunk / 98a6176 hadoop-common test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-common.txt hadoop-kms test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-kms.txt hadoop-dist test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-dist.txt hadoop-mapreduce-client-nativetask test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-mapreduce-client-nativetask.txt hadoop-yarn-server-nodemanager test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-hdfs.txt hadoop-hdfs-httpfs test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/artifact/patchprocess/testrun_hadoop-hdfs-httpfs.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6231/console This message was automatically generated.
        Hide
        cmccabe Colin P. McCabe added a comment -

        Thanks, Andrew. +1.

        Show
        cmccabe Colin P. McCabe added a comment - Thanks, Andrew. +1.
        Hide
        andrew.wang Andrew Wang added a comment -

        Pushed to trunk and branch-2, thanks Colin and others for reviewing!

        Show
        andrew.wang Andrew Wang added a comment - Pushed to trunk and branch-2, thanks Colin and others for reviewing!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7927 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7927/)
        HADOOP-11885. hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782)

        • pom.xml
        • hadoop-hdfs-project/hadoop-hdfs/pom.xml
        • hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
        • hadoop-yarn-project/pom.xml
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml
        • hadoop-mapreduce-project/pom.xml
        • hadoop-common-project/hadoop-kms/pom.xml
        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-project-dist/pom.xml
        • hadoop-dist/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7927 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7927/ ) HADOOP-11885 . hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782) pom.xml hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml hadoop-yarn-project/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml hadoop-mapreduce-project/pom.xml hadoop-common-project/hadoop-kms/pom.xml hadoop-common-project/hadoop-common/pom.xml hadoop-project-dist/pom.xml hadoop-dist/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #943 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/943/)
        HADOOP-11885. hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782)

        • hadoop-hdfs-project/hadoop-hdfs/pom.xml
        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-mapreduce-project/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-dist/pom.xml
        • hadoop-yarn-project/pom.xml
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml
        • hadoop-project-dist/pom.xml
        • pom.xml
        • hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
        • hadoop-common-project/hadoop-kms/pom.xml
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #943 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/943/ ) HADOOP-11885 . hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782) hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-common-project/hadoop-common/pom.xml hadoop-mapreduce-project/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-dist/pom.xml hadoop-yarn-project/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml hadoop-project-dist/pom.xml pom.xml hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml hadoop-common-project/hadoop-kms/pom.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #213 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/213/)
        HADOOP-11885. hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782)

        • hadoop-hdfs-project/hadoop-hdfs/pom.xml
        • hadoop-dist/pom.xml
        • hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
        • hadoop-project-dist/pom.xml
        • pom.xml
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
        • hadoop-yarn-project/pom.xml
        • hadoop-common-project/hadoop-kms/pom.xml
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml
        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-mapreduce-project/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #213 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/213/ ) HADOOP-11885 . hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782) hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-dist/pom.xml hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml hadoop-project-dist/pom.xml pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml hadoop-yarn-project/pom.xml hadoop-common-project/hadoop-kms/pom.xml hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml hadoop-common-project/hadoop-common/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-mapreduce-project/pom.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2141 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2141/)
        HADOOP-11885. hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782)

        • hadoop-dist/pom.xml
        • hadoop-common-project/hadoop-kms/pom.xml
        • pom.xml
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-project-dist/pom.xml
        • hadoop-hdfs-project/hadoop-hdfs/pom.xml
        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
        • hadoop-yarn-project/pom.xml
        • hadoop-mapreduce-project/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2141 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2141/ ) HADOOP-11885 . hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782) hadoop-dist/pom.xml hadoop-common-project/hadoop-kms/pom.xml pom.xml hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-project-dist/pom.xml hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-common-project/hadoop-common/pom.xml hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml hadoop-yarn-project/pom.xml hadoop-mapreduce-project/pom.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/202/)
        HADOOP-11885. hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml
        • hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
        • hadoop-project-dist/pom.xml
        • hadoop-hdfs-project/hadoop-hdfs/pom.xml
        • hadoop-yarn-project/pom.xml
        • pom.xml
        • hadoop-common-project/hadoop-kms/pom.xml
        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-mapreduce-project/pom.xml
        • hadoop-dist/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #202 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/202/ ) HADOOP-11885 . hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml hadoop-project-dist/pom.xml hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-yarn-project/pom.xml pom.xml hadoop-common-project/hadoop-kms/pom.xml hadoop-common-project/hadoop-common/pom.xml hadoop-mapreduce-project/pom.xml hadoop-dist/pom.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/211/)
        HADOOP-11885. hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782)

        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
        • hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml
        • pom.xml
        • hadoop-project-dist/pom.xml
        • hadoop-hdfs-project/hadoop-hdfs/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-yarn-project/pom.xml
        • hadoop-mapreduce-project/pom.xml
        • hadoop-dist/pom.xml
        • hadoop-common-project/hadoop-kms/pom.xml
        • hadoop-common-project/hadoop-common/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #211 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/211/ ) HADOOP-11885 . hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782) hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml pom.xml hadoop-project-dist/pom.xml hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/pom.xml hadoop-mapreduce-project/pom.xml hadoop-dist/pom.xml hadoop-common-project/hadoop-kms/pom.xml hadoop-common-project/hadoop-common/pom.xml
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2159/)
        HADOOP-11885. hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782)

        • hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml
        • hadoop-dist/pom.xml
        • hadoop-project-dist/pom.xml
        • pom.xml
        • hadoop-common-project/hadoop-common/pom.xml
        • hadoop-hdfs-project/hadoop-hdfs/pom.xml
        • hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml
        • hadoop-mapreduce-project/pom.xml
        • hadoop-yarn-project/pom.xml
        • hadoop-common-project/hadoop-kms/pom.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2159/ ) HADOOP-11885 . hadoop-dist dist-layout-stitching.sh does not work with dash. (wang) (andrew.wang: rev 7673d4f205b26a6a26cfc47d999ece96f3c42782) hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/pom.xml hadoop-dist/pom.xml hadoop-project-dist/pom.xml pom.xml hadoop-common-project/hadoop-common/pom.xml hadoop-hdfs-project/hadoop-hdfs/pom.xml hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/pom.xml hadoop-mapreduce-project/pom.xml hadoop-yarn-project/pom.xml hadoop-common-project/hadoop-kms/pom.xml

          People

          • Assignee:
            andrew.wang Andrew Wang
            Reporter:
            andrew.wang Andrew Wang
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development