Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11884

test-patch.sh should pull the real findbugs version

    Details

      Description

      test-patch.sh currently uses the CLI utilities for findbugs to discover the version. This isn't really accurate since maven pulls down the jars as part of the pom. It should be possible to either read the generated HTML file(s) or perhaps read the pom to discover the real version that was used.

      1. HADOOP-11884.002.patch
        0.8 kB
        Kengo Seki
      2. HADOOP-11884.001.patch
        0.8 kB
        Kengo Seki

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2148 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2148/)
        HADOOP-11884. test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53)

        • dev-support/test-patch.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2148 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2148/ ) HADOOP-11884 . test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/200/)
        HADOOP-11884. test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/200/ ) HADOOP-11884 . test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/190/)
        HADOOP-11884. test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/190/ ) HADOOP-11884 . test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2130 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2130/)
        HADOOP-11884. test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • dev-support/test-patch.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2130 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2130/ ) HADOOP-11884 . test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53) hadoop-common-project/hadoop-common/CHANGES.txt dev-support/test-patch.sh
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #201 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/201/)
        HADOOP-11884. test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53)

        • dev-support/test-patch.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #201 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/201/ ) HADOOP-11884 . test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #932 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/932/)
        HADOOP-11884. test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53)

        • dev-support/test-patch.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #932 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/932/ ) HADOOP-11884 . test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7852 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7852/)
        HADOOP-11884. test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53)

        • dev-support/test-patch.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7852 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7852/ ) HADOOP-11884 . test-patch.sh should pull the real findbugs version (Kengo Seki via aw) (aw: rev 182d86dac04a2168b1888af34f0a7042379d7e53) dev-support/test-patch.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        aw Allen Wittenauer added a comment -

        +1 committed
        thanks!

        Show
        aw Allen Wittenauer added a comment - +1 committed thanks!
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s dev-support patch detected.
        0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
        0 @author 0m 0s Skipping @author checks as test-patch has been patched.
        +1 release audit 0m 14s The applied patch does not increase the total number of release audit warnings.
        +1 shellcheck 0m 7s There were no new shellcheck (v0.3.3) issues.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            0m 25s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12732063/HADOOP-11884.002.patch
        Optional Tests shellcheck
        git revision trunk / 444836b
        Java 1.7.0_55
        uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6602/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 release audit 0m 14s The applied patch does not increase the total number of release audit warnings. +1 shellcheck 0m 7s There were no new shellcheck (v0.3.3) issues. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 25s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12732063/HADOOP-11884.002.patch Optional Tests shellcheck git revision trunk / 444836b Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6602/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        A patch to test-patch or smart-apply-patch has been detected.
        Re-executing against the patched versions to perform further tests.
        The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6602/console in case of problems.

        Show
        hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6602/console in case of problems.
        Hide
        sekikn Kengo Seki added a comment -

        Thank you Allen Wittenauer, I fixed the patch.

        Show
        sekikn Kengo Seki added a comment - Thank you Allen Wittenauer , I fixed the patch.
        Hide
        aw Allen Wittenauer added a comment - - edited

        awk needs to be ${AWK} in case a different awk is specified.

        Show
        aw Allen Wittenauer added a comment - - edited awk needs to be ${AWK} in case a different awk is specified.
        Hide
        hadoopqa Hadoop QA added a comment -



        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s dev-support patch detected.
        0 pre-patch 0m 0s Pre-patch trunk compilation is healthy.
        0 @author 0m 0s Skipping @author checks as test-patch has been patched.
        +1 release audit 0m 14s The applied patch does not increase the total number of release audit warnings.
        0 shellcheck 0m 14s Shellcheck was not available.
        +1 whitespace 0m 0s The patch has no lines that end in whitespace.
            0m 17s  



        Subsystem Report/Notes
        Patch URL http://issues.apache.org/jira/secure/attachment/12729757/HADOOP-11884.001.patch
        Optional Tests shellcheck
        git revision trunk / 1b3b9e5
        Java 1.7.0_55
        uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6234/console

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s dev-support patch detected. 0 pre-patch 0m 0s Pre-patch trunk compilation is healthy. 0 @author 0m 0s Skipping @author checks as test-patch has been patched. +1 release audit 0m 14s The applied patch does not increase the total number of release audit warnings. 0 shellcheck 0m 14s Shellcheck was not available. +1 whitespace 0m 0s The patch has no lines that end in whitespace.     0m 17s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12729757/HADOOP-11884.001.patch Optional Tests shellcheck git revision trunk / 1b3b9e5 Java 1.7.0_55 uname Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6234/console This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        A patch to test-patch or smart-apply-patch has been detected.
        Re-executing against the patched versions to perform further tests.
        The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6234/console in case of problems.

        Show
        hadoopqa Hadoop QA added a comment - A patch to test-patch or smart-apply-patch has been detected. Re-executing against the patched versions to perform further tests. The console is at https://builds.apache.org/job/PreCommit-HADOOP-Build/6234/console in case of problems.
        Hide
        sekikn Kengo Seki added a comment -

        Attaching a patch. It greps the generated file and determines findbugs' version.

        We can also read pom.xml, but in some cases like the order of sibling elements is changed, it is difficult to parse an XML without some tools like xmllint.

        Show
        sekikn Kengo Seki added a comment - Attaching a patch. It greps the generated file and determines findbugs' version. We can also read pom.xml, but in some cases like the order of sibling elements is changed, it is difficult to parse an XML without some tools like xmllint.

          People

          • Assignee:
            sekikn Kengo Seki
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development