Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11814

Reformat hadoop-annotations, o.a.h.classification.tools

        Details

        • Type: Task
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 2.8.0, 2.7.3, 3.0.0-alpha1
        • Component/s: None
        • Labels:
        • Target Version/s:
        • Hadoop Flags:
          Reviewed

          Description

          RootDocProcessor has some indentation problems. It mixes tabs and spaces for indentation. We may want to fix this.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            gtCarrera9 Li Lu added a comment -

            Upload a patch to reformat all classes in o.a.h.classification.tools, replaced all tabs into spaces.

            Show
            gtCarrera9 Li Lu added a comment - Upload a patch to reformat all classes in o.a.h.classification.tools, replaced all tabs into spaces.
            Hide
            Permalink
            wheat9 Haohui Mai added a comment -

            +1 pending Jenkins.

            Show
            wheat9 Haohui Mai added a comment - +1 pending Jenkins.
            Hide
            Permalink
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12723998/HADOOP-11814-040815.patch
            against trunk revision cc25823.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. There were no new javadoc warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-annotations.

            Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6081//testReport/
            Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6081//console

            This message is automatically generated.

            Show
            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12723998/HADOOP-11814-040815.patch against trunk revision cc25823. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-annotations. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6081//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6081//console This message is automatically generated.
            Hide
            Permalink
            wheat9 Haohui Mai added a comment -

            I've committed the patch to trunk and branch-2. Thanks Li Lu for the contribution.

            Show
            wheat9 Haohui Mai added a comment - I've committed the patch to trunk and branch-2. Thanks Li Lu for the contribution.
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-trunk-Commit #7542 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7542/)
            HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)

            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7542 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7542/ ) HADOOP-11814 . Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081) hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java hadoop-common-project/hadoop-common/CHANGES.txt
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #158 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/158/)
            HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)

            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #158 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/158/ ) HADOOP-11814 . Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081) hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk #2090 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2090/)
            HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)

            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2090 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2090/ ) HADOOP-11814 . Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/149/)
            HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)

            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #149 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/149/ ) HADOOP-11814 . Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081) hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
            Hide
            Permalink
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Yarn-trunk #892 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/892/)
            HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)

            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
            Show
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #892 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/892/ ) HADOOP-11814 . Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081) hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/)
            HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)

            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #159 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/159/ ) HADOOP-11814 . Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081) hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
            Hide
            Permalink
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk #2108 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2108/)
            HADOOP-11814. Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081)

            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
            Show
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2108 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2108/ ) HADOOP-11814 . Reformat hadoop-annotations, o.a.h.classification.tools. Contributed by Li Lu. (wheat9: rev dc0282d64c6528b02aa9f2df49be01223f087081) hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/RootDocProcessor.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsJDiffDoclet.java hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/StabilityOptions.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-annotations/src/main/java/org/apache/hadoop/classification/tools/ExcludePrivateAnnotationsStandardDoclet.java
            Hide
            Permalink
            leftnoteasy Wangda Tan added a comment -

            Back ported this changes to branch-2.7 and branch-2.7.3 to overcome merge conflicts.

            Show
            leftnoteasy Wangda Tan added a comment - Back ported this changes to branch-2.7 and branch-2.7.3 to overcome merge conflicts.
            Hide
            Permalink
            vinodkv Vinod Kumar Vavilapalli added a comment -

            Closing the JIRA as part of 2.7.3 release.

            Show
            vinodkv Vinod Kumar Vavilapalli added a comment - Closing the JIRA as part of 2.7.3 release.

              People

              • Assignee:
                gtCarrera9 Li Lu
                Reporter:
                gtCarrera9 Li Lu
              • Votes:
                0 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development