extra imports in DataXCeiver, though really you probably meant to add the @Private annotation and just forgot.
Add a newline in the DSW C file change, break the new POLLHUP check to the next line (like the other if you changed)
Adding a link to the webpage reference (along with mentioning portability / Cygwin) would also be nice, since I wondered why we didn't have to catch yet more poll errors.
I added a comment explaining why POLLHUP
Typo "repsponse" in DataXceiver
We typically have used a singleton to do fault injection, would be good to be consistent since it doesn't look like we need per-instance injection. See DataNodeFaultInjector, probably the best home.
OK. That would eliminate the need to make the DataXceiver class public, which would be nice.
Good fix on the javadoc for allocSlot, but mind adding the blockId param doc too for full coverage?
Hey, I'm trying to make incremental changes here Fixed.
The Throwable catch, it subsumes the IOException catch, so can we just delete it? I think the more specific name of the exception will be printed by its toString.
Param indentation in TestSCCache#checkNumberOfSeg... is inconsistent, I think we typically do double indent?
TestSCCache, the comment "Remove the failure injector" should be moved up a few lines
let me just get rid of that since the log messages says the same thing