Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11719

[Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: scripts
    • Labels:
    • Hadoop Flags:
      Reviewed

      Description

      Scenario:
      ----------
      Execute any fsshell command with invalid options

      Like ./hdfs haadmin -transitionToActive...

      Here it is logging as following..

      bin/hadoop command [genericOptions] [commandOptions]...

      Expected: Here help message is misleading to user saying that bin/hadoop that is not actually user ran

      it's better to log bin/hdfs..Anyway hadoop is deprecated..

      1. HDFS-3387.patch
        0.5 kB
        Brahma Reddy Battula
      2. HDFS-3387_updated.patch
        0.8 kB
        Brahma Reddy Battula
      3. HADOOP-11719-001.patch
        0.8 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Attaching patch..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Attaching patch..
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526018/HDFS-3387.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2389//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526018/HDFS-3387.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2389//console This message is automatically generated.
        Hide
        atm Aaron T. Myers added a comment -

        Hey Brahma, you need to root your patch at repo root. The patch you attached doesn't include the path to the file you edited.

        Show
        atm Aaron T. Myers added a comment - Hey Brahma, you need to root your patch at repo root. The patch you attached doesn't include the path to the file you edited.
        Hide
        daryn Daryn Sharp added a comment -

        Are you sure "hadoop fs" is deprecated? It doesn't seem to make sense to run "hdfs fs" on a non-hdfs filesystem.

        Show
        daryn Daryn Sharp added a comment - Are you sure "hadoop fs" is deprecated? It doesn't seem to make sense to run "hdfs fs" on a non-hdfs filesystem.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        @Aaron T Mayes..I have updated patch..

        Show
        brahmareddy Brahma Reddy Battula added a comment - @Aaron T Mayes..I have updated patch..
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        @Daryn Sharp..Thanks for look...

        hadoop fs is not deprecated..Whatever you told is correct..It's better to separate out hdfs and hadoop(general filesystem) when running fsshell commands...I'll Fix same ..

        Show
        brahmareddy Brahma Reddy Battula added a comment - @Daryn Sharp..Thanks for look... hadoop fs is not deprecated..Whatever you told is correct..It's better to separate out hdfs and hadoop(general filesystem) when running fsshell commands...I'll Fix same ..
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12526384/HDFS-3387_updated.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2408//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2408//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12526384/HDFS-3387_updated.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 eclipse:eclipse. The patch built with eclipse:eclipse. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/2408//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/2408//console This message is automatically generated.
        Hide
        qwertymaniac Harsh J added a comment -

        Canceling current patch as its invalid.

        Perhaps we can remove the whole "bin/hadoop" part, since it is supposed to be 'generic'.

        Show
        qwertymaniac Harsh J added a comment - Canceling current patch as its invalid. Perhaps we can remove the whole "bin/hadoop" part, since it is supposed to be 'generic'.
        Hide
        qwertymaniac Harsh J added a comment -

        The text can rather look generic such as this:

        The general command line syntax is:
        command [genericOptions] [commandOptions]

        Show
        qwertymaniac Harsh J added a comment - The text can rather look generic such as this: The general command line syntax is: command [genericOptions] [commandOptions]
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Updated the patch based on your review comment..Kindly check the same...

        Show
        brahmareddy Brahma Reddy Battula added a comment - Updated the patch based on your review comment..Kindly check the same...
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12707374/HADOOP-11719-001.patch
        against trunk revision 44809b8.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

        org.apache.hadoop.ipc.TestRPC

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6001//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6001//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12707374/HADOOP-11719-001.patch against trunk revision 44809b8. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ipc.TestRPC Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6001//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6001//console This message is automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Test failures are unrelated to this jira..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Test failures are unrelated to this jira..
        Hide
        qwertymaniac Harsh J added a comment -

        +1, committing shortly.

        Show
        qwertymaniac Harsh J added a comment - +1, committing shortly.
        Hide
        qwertymaniac Harsh J added a comment -

        Thanks Brahma! Committed to branch-2 and trunk.

        Show
        qwertymaniac Harsh J added a comment - Thanks Brahma! Committed to branch-2 and trunk.
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7438 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7438/)
        HADOOP-11719.[Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7438 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7438/ ) HADOOP-11719 . [Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Thanks Harsh for review and commit!!!

        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks Harsh for review and commit!!!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #144 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/144/)
        HADOOP-11719.[Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #144 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/144/ ) HADOOP-11719 . [Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #878 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/878/)
        HADOOP-11719.[Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #878 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/878/ ) HADOOP-11719 . [Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #144 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/144/)
        HADOOP-11719.[Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #144 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/144/ ) HADOOP-11719 . [Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2094 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2094/)
        HADOOP-11719.[Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2094 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2094/ ) HADOOP-11719 . [Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2076 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2076/)
        HADOOP-11719.[Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2076 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2076/ ) HADOOP-11719 . [Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/135/)
        HADOOP-11719.[Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #135 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/135/ ) HADOOP-11719 . [Fsshell] Remove bin/hadoop reference from GenericOptionsParser default help text. Contributed by Brahma Reddy Battula. (harsh: rev b4b4fe90569a116c67bfc94fbfbab95b1a0b712a) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/GenericOptionsParser.java

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development