Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11673

Use org.junit.Assume to skip tests instead of return

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We see the following code many times:

      TestCodec.java
          if (!ZlibFactory.isNativeZlibLoaded(conf)) {
            LOG.warn("skipped: native libs not loaded");
            return;
          }
      

      If ZlibFactory.isNativeZlibLoaded(conf) is false, the test will pass, with a warn log. I'd like to skip this test case by using org.junit.Assume.

        Attachments

        1. HADOOP-11673.patch
          2 kB
          Brahma Reddy Battula
        2. HADOOP-11673-001.patch
          2 kB
          Brahma Reddy Battula

          Activity

            People

            • Assignee:
              brahmareddy Brahma Reddy Battula
              Reporter:
              ajisakaa Akira Ajisaka
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: