Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11673

Use org.junit.Assume to skip tests instead of return

VotersStop watchingWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.0.0-alpha1
    • test
    • None
    • Reviewed

    Description

      We see the following code many times:

      TestCodec.java
          if (!ZlibFactory.isNativeZlibLoaded(conf)) {
            LOG.warn("skipped: native libs not loaded");
            return;
          }
      

      If ZlibFactory.isNativeZlibLoaded(conf) is false, the test will pass, with a warn log. I'd like to skip this test case by using org.junit.Assume.

      Attachments

        1. HADOOP-11673.patch
          2 kB
          Brahma Reddy Battula
        2. HADOOP-11673-001.patch
          2 kB
          Brahma Reddy Battula

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            brahmareddy Brahma Reddy Battula
            aajisaka Akira Ajisaka
            Votes:
            0 Vote for this issue
            Watchers:
            4 Stop watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment