Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11653

shellprofiles should require .sh extension

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: scripts
    • Labels:
      None
    • Target Version/s:

      Description

      It's desirable to force an extension if/when the Windows batch files get similar functionality. This way all forms can go into the same directories.

      1. HADOOP-11653.patch
        22 kB
        Brahma Reddy Battula

        Activity

        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Can I take this Jira, if you are ok?

        Show
        brahmareddy Brahma Reddy Battula added a comment - Can I take this Jira, if you are ok?
        Hide
        aw Allen Wittenauer added a comment -

        Sure. This one is pretty easy really. The file list filter needs to get modified and the existing profiles need to get renamed. You'll want to build a git apply-style patch for it since we're doing a rename.

        Show
        aw Allen Wittenauer added a comment - Sure. This one is pretty easy really. The file list filter needs to get modified and the existing profiles need to get renamed. You'll want to build a git apply-style patch for it since we're doing a rename.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Sorry, I am little confused here.
        do you mean adding .sh extension to shellprofiles, is renaming 'hadoop' to 'hadoop.sh' for example?

        Show
        vinayrpet Vinayakumar B added a comment - Sorry, I am little confused here. do you mean adding .sh extension to shellprofiles, is renaming 'hadoop' to 'hadoop.sh' for example?
        Hide
        aw Allen Wittenauer added a comment -

        I specifically mean shellprofiles as introduced by HADOOP-11485.

        Show
        aw Allen Wittenauer added a comment - I specifically mean shellprofiles as introduced by HADOOP-11485 .
        Hide
        cnauroth Chris Nauroth added a comment -

        If this is solely motivated by forward-looking Windows compatibility, I don't think it's necessary. I'm pretty sure cmd.exe requires script files to have a .cmd or .bat extension. We could allow the *nix shell profiles to have no extension, and they could coexist with the corresponding .cmd files.

        I have no objection to the change though if there are other good reasons for it, or if others simply prefer the clarity of having an extension.

        Show
        cnauroth Chris Nauroth added a comment - If this is solely motivated by forward-looking Windows compatibility, I don't think it's necessary. I'm pretty sure cmd.exe requires script files to have a .cmd or .bat extension. We could allow the *nix shell profiles to have no extension, and they could coexist with the corresponding .cmd files. I have no objection to the change though if there are other good reasons for it, or if others simply prefer the clarity of having an extension.
        Hide
        aw Allen Wittenauer added a comment -

        The current code uses *, which means it would pick up both the shell code and the .cmd/.bat files. While it's certainly possible to just exclude those from the generated list, I feel it's better to just tie this down to .sh files for the clarity reasons, as you stated.

        Show
        aw Allen Wittenauer added a comment - The current code uses *, which means it would pick up both the shell code and the .cmd/.bat files. While it's certainly possible to just exclude those from the generated list, I feel it's better to just tie this down to .sh files for the clarity reasons, as you stated.
        Hide
        cnauroth Chris Nauroth added a comment -

        The current code uses *...

        I see now. Thanks for pointing that out.

        Show
        cnauroth Chris Nauroth added a comment - The current code uses *... I see now. Thanks for pointing that out.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12702985/HADOOP-11653.patch
        against trunk revision 952640f.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5865//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5865//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12702985/HADOOP-11653.patch against trunk revision 952640f. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5865//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5865//console This message is automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        +1 committed to trunk.

        Thanks!

        Show
        aw Allen Wittenauer added a comment - +1 committed to trunk. Thanks!
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7273 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7273/)
        HADOOP-11653. shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300)

        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh
        • hadoop-mapreduce-project/shellprofile.d/mapreduce.sh
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example
        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh
        • hadoop-mapreduce-project/shellprofile.d/mapreduce
        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7273 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7273/ ) HADOOP-11653 . shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300) hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh hadoop-mapreduce-project/shellprofile.d/mapreduce.sh hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh hadoop-mapreduce-project/shellprofile.d/mapreduce hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #125 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/125/)
        HADOOP-11653. shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300)

        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-mapreduce-project/shellprofile.d/mapreduce.sh
        • hadoop-mapreduce-project/shellprofile.d/mapreduce
        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn
        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example
        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #125 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/125/ ) HADOOP-11653 . shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300) hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs hadoop-common-project/hadoop-common/CHANGES.txt hadoop-mapreduce-project/shellprofile.d/mapreduce.sh hadoop-mapreduce-project/shellprofile.d/mapreduce hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #859 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/859/)
        HADOOP-11653. shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300)

        • hadoop-mapreduce-project/shellprofile.d/mapreduce
        • hadoop-mapreduce-project/shellprofile.d/mapreduce.sh
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example
        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs
        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn
        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #859 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/859/ ) HADOOP-11653 . shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300) hadoop-mapreduce-project/shellprofile.d/mapreduce hadoop-mapreduce-project/shellprofile.d/mapreduce.sh hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2057 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2057/)
        HADOOP-11653. shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh
        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh
        • hadoop-mapreduce-project/shellprofile.d/mapreduce
        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn
        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        • hadoop-mapreduce-project/shellprofile.d/mapreduce.sh
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2057 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2057/ ) HADOOP-11653 . shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300) hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh hadoop-mapreduce-project/shellprofile.d/mapreduce hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh hadoop-mapreduce-project/shellprofile.d/mapreduce.sh hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #116 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/116/)
        HADOOP-11653. shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300)

        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh
        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-mapreduce-project/shellprofile.d/mapreduce
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example
        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn
        • hadoop-mapreduce-project/shellprofile.d/mapreduce.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #116 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/116/ ) HADOOP-11653 . shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300) hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-mapreduce-project/shellprofile.d/mapreduce hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn hadoop-mapreduce-project/shellprofile.d/mapreduce.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #125 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/125/)
        HADOOP-11653. shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300)

        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs
        • hadoop-mapreduce-project/shellprofile.d/mapreduce
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh
        • hadoop-mapreduce-project/shellprofile.d/mapreduce.sh
        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example
        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #125 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/125/ ) HADOOP-11653 . shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300) hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs hadoop-mapreduce-project/shellprofile.d/mapreduce hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh hadoop-mapreduce-project/shellprofile.d/mapreduce.sh hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2075 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2075/)
        HADOOP-11653. shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300)

        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh
        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh
        • hadoop-mapreduce-project/shellprofile.d/mapreduce.sh
        • hadoop-mapreduce-project/shellprofile.d/mapreduce
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh
        • hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh
        • hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn
        • hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2075 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2075/ ) HADOOP-11653 . shellprofiles should require .sh extension (Brahma Reddy Battula via aw) (aw: rev 01bfe6f05b5eadfe7c37806bc13eed047e0da300) hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs.sh hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn.sh hadoop-mapreduce-project/shellprofile.d/mapreduce.sh hadoop-mapreduce-project/shellprofile.d/mapreduce hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example.sh hadoop-common-project/hadoop-common/src/main/bin/hadoop-functions.sh hadoop-yarn-project/hadoop-yarn/shellprofile.d/yarn hadoop-hdfs-project/hadoop-hdfs/src/main/shellprofile.d/hdfs hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/shellprofile.d/example
        Hide
        brahmareddy Brahma Reddy Battula added a comment -
        Show
        brahmareddy Brahma Reddy Battula added a comment - Thanks Allen Wittenauer !!

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development