Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11626

Comment ReadStatistics to indicate that it tracks the actual read occurred

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Patch Available
    • Priority: Trivial
    • Resolution: Unresolved
    • Affects Version/s: 2.6.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Target Version/s:

      Description

      In DFSOutputStream#actualGetFromOneDataNode(), it updates the ReadStatistics even the read is failed:

              int nread = reader.readAll(buf, offset, len);
              updateReadStatistics(readStatistics, nread, reader);
      
              if (nread != len) {
                throw new IOException("truncated return from reader.read(): " +
                                      "excpected " + len + ", got " + nread);
              }
      

      It indicates that ReadStatistics tracks actual read occurred. Need to add comment to ReadStatistics to make this clear.

        Attachments

        1. HADOOP-11626.000.patch
          1 kB
          Lei (Eddy) Xu
        2. HADOOP-11626.001.patch
          1 kB
          Lei (Eddy) Xu
        3. HADOOP-11626.002.patch
          1 kB
          Lei (Eddy) Xu

          Activity

            People

            • Assignee:
              eddyxu Lei (Eddy) Xu
              Reporter:
              eddyxu Lei (Eddy) Xu
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated: