Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11603

Metric Snapshot log can be changed #MetricsSystemImpl.java since all the services will be initialized

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Namenode,DataNode,journalnode,ResourceManager, Nodemanager and historyservice etc... will initialize DefaultMetricsSystem hence following log will be logged for all the classes.. Since there is snapshot feature in HDFS ,it's better to change the following...

      LOG.info("Scheduled snapshot period at "+ period +" second(s).");
      
      1. defaultmetricIntialize-classes.JPG
        43 kB
        Brahma Reddy Battula
      2. HADOOP-11603.patch
        0.7 kB
        Brahma Reddy Battula
      3. HADOOP-11603-002.patch
        1 kB
        Brahma Reddy Battula

        Activity

        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12699094/defaultmetricIntialize-classes.JPG
        against trunk revision ab0b958.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5715//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699094/defaultmetricIntialize-classes.JPG against trunk revision ab0b958. -1 patch . The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5715//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12699080/HADOOP-11603.patch
        against trunk revision ab0b958.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5711//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5711//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699080/HADOOP-11603.patch against trunk revision ab0b958. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5711//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5711//console This message is automatically generated.
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Brahma Reddy Battula the term "snapshot" is not related to HDFS snapshot in MetricsSystemImpl:

          /**
           * Sample all the sources for a snapshot of metrics/tags
           * @return  the metrics buffer containing the snapshot
           */
          synchronized MetricsBuffer sampleMetrics() {
        

        Is it OK to close this as "Not a problem"?

        Show
        ozawa Tsuyoshi Ozawa added a comment - Brahma Reddy Battula the term "snapshot" is not related to HDFS snapshot in MetricsSystemImpl: /** * Sample all the sources for a snapshot of metrics/tags * @ return the metrics buffer containing the snapshot */ synchronized MetricsBuffer sampleMetrics() { Is it OK to close this as "Not a problem"?
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Yes,, you are correct,just I confused....

        can we change variable some thing like metric_snapshot_period and log

        "configured metrics/tags period" (instead of Scheduled snapshot period at)..? which will be meaning full and user will not get confused..

        Please let me know your opinion on same...Anything is ok for me..

        Show
        brahmareddy Brahma Reddy Battula added a comment - Yes,, you are correct,just I confused.... can we change variable some thing like metric_snapshot_period and log "configured metrics/tags period" (instead of Scheduled snapshot period at)..? which will be meaning full and user will not get confused.. Please let me know your opinion on same...Anything is ok for me..
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Uploading the patch to change the log message and remove the ununsed property...

        Show
        brahmareddy Brahma Reddy Battula added a comment - Uploading the patch to change the log message and remove the ununsed property...
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 docker 0m 4s Docker failed to build yetus/hadoop:fbe3e86.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800995/HADOOP-11603-002.patch
        JIRA Issue HADOOP-11603
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9192/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 0m 4s Docker failed to build yetus/hadoop:fbe3e86. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800995/HADOOP-11603-002.patch JIRA Issue HADOOP-11603 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9192/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1 pending Jenkins.

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1 pending Jenkins.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 15s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
        +1 mvninstall 7m 5s trunk passed
        +1 compile 9m 49s trunk passed
        +1 checkstyle 0m 29s trunk passed
        +1 mvnsite 1m 3s trunk passed
        +1 mvneclipse 0m 18s trunk passed
        +1 findbugs 1m 30s trunk passed
        +1 javadoc 0m 48s trunk passed
        +1 mvninstall 0m 38s the patch passed
        +1 compile 9m 19s the patch passed
        +1 javac 9m 19s the patch passed
        +1 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 0 new + 40 unchanged - 1 fixed = 40 total (was 41)
        +1 mvnsite 1m 1s the patch passed
        +1 mvneclipse 0m 19s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 33s the patch passed
        +1 javadoc 0m 47s the patch passed
        +1 unit 8m 50s hadoop-common in the patch passed.
        +1 asflicense 0m 31s The patch does not generate ASF License warnings.
        46m 33s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:a9ad5d6
        JIRA Issue HADOOP-11603
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800995/HADOOP-11603-002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 4e5707689492 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e15c20e
        Default Java 1.8.0_111
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11127/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11127/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 5s trunk passed +1 compile 9m 49s trunk passed +1 checkstyle 0m 29s trunk passed +1 mvnsite 1m 3s trunk passed +1 mvneclipse 0m 18s trunk passed +1 findbugs 1m 30s trunk passed +1 javadoc 0m 48s trunk passed +1 mvninstall 0m 38s the patch passed +1 compile 9m 19s the patch passed +1 javac 9m 19s the patch passed +1 checkstyle 0m 29s hadoop-common-project/hadoop-common: The patch generated 0 new + 40 unchanged - 1 fixed = 40 total (was 41) +1 mvnsite 1m 1s the patch passed +1 mvneclipse 0m 19s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 33s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 8m 50s hadoop-common in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 46m 33s Subsystem Report/Notes Docker Image:yetus/hadoop:a9ad5d6 JIRA Issue HADOOP-11603 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12800995/HADOOP-11603-002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 4e5707689492 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e15c20e Default Java 1.8.0_111 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/11127/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/11127/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        brahmareddy Brahma Reddy Battula added a comment -

        Akira Ajisaka thanks a lot for review..Jenkins report is fine and it's just log change hence test is not added.

        Committed to trunk,branch-2 and branch-2.8.

        Show
        brahmareddy Brahma Reddy Battula added a comment - Akira Ajisaka thanks a lot for review..Jenkins report is fine and it's just log change hence test is not added. Committed to trunk,branch-2 and branch-2.8.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10888 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10888/)
        HADOOP-11603. Metric Snapshot log can be changed #MetricsSystemImpl.java (brahma: rev 13501053dd95f41ac14091f5bbd79bcb2a3896a3)

        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10888 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10888/ ) HADOOP-11603 . Metric Snapshot log can be changed #MetricsSystemImpl.java (brahma: rev 13501053dd95f41ac14091f5bbd79bcb2a3896a3) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/impl/MetricsSystemImpl.java

          People

          • Assignee:
            brahmareddy Brahma Reddy Battula
            Reporter:
            brahmareddy Brahma Reddy Battula
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development