Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11590

Update sbin commands and documentation to use new --slaves option

    Details

      Description

      With HADOOP-11565 now committed, we need to remove usages of yarn-daemons.sh and hadoop-daemons.sh from the start and stop scripts, converting them to use the new --slaves option. Additionally, the documentation should be updated to reflect these new command options.

      1. HADOOP-11590-03.patch
        18 kB
        Allen Wittenauer
      2. HADOOP-11590-02.patch
        17 kB
        Allen Wittenauer
      3. HADOOP-11590-01.patch
        18 kB
        Allen Wittenauer
      4. HADOOP-11590-00.patch
        16 kB
        Allen Wittenauer

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/)
          HADOOP-11590. Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72)

          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
          • hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh
          • hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
          • hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2138 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2138/ ) HADOOP-11590 . Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/)
          HADOOP-11590. Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72)

          • hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
          • hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh
          • hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/190/ ) HADOOP-11590 . Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72) hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/)
          HADOOP-11590. Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72)

          • hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh
          • hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #180 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/180/ ) HADOOP-11590 . Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72) hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/)
          HADOOP-11590. Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72)

          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh
          • hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
          • hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh
          • hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2120 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2120/ ) HADOOP-11590 . Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72) hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/)
          HADOOP-11590. Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh
          • hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh
          • hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md
          • hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #922 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/922/ ) HADOOP-11590 . Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/)
          HADOOP-11590. Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh
          • hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
          • hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh
          • hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #191 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/191/ ) HADOOP-11590 . Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7780 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7780/)
          HADOOP-11590. Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh
          • hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh
          • hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md
          • hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7780 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7780/ ) HADOOP-11590 . Update sbin commands and documentation to use new --slaves option (aw) (aw: rev c945c20483d12e0ef97156ce6ebdb001e18d3c72) hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-secure-dns.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/start-dfs.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/bin/start-yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-secure-dns.sh hadoop-hdfs-project/hadoop-hdfs/src/main/bin/stop-dfs.sh hadoop-yarn-project/hadoop-yarn/bin/stop-yarn.sh hadoop-hdfs-project/hadoop-hdfs/src/site/markdown/HDFSHighAvailabilityWithQJM.md hadoop-common-project/hadoop-common/src/site/markdown/CommandsManual.md
          Hide
          aw Allen Wittenauer added a comment -

          I'm going to go ahead and commit this to trunk. Thanks Roman!

          Show
          aw Allen Wittenauer added a comment - I'm going to go ahead and commit this to trunk. Thanks Roman!
          Hide
          aw Allen Wittenauer added a comment -

          shouldn't we put a deprecation message in hadoop-daemons.sh and yarn-daemons.sh ?

          I forgot: we already did this in HADOOP-11565 .

          So I guess this means we're good to go.

          Show
          aw Allen Wittenauer added a comment - shouldn't we put a deprecation message in hadoop-daemons.sh and yarn-daemons.sh ? I forgot: we already did this in HADOOP-11565 . So I guess this means we're good to go.
          Hide
          aw Allen Wittenauer added a comment -

          $@ & $*

          This actually comes from shellcheck's sage advice:

           Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
          

          shouldn't we put a deprecation message in hadoop-daemons.sh and yarn-daemons.sh ?

          That's a good point.

          I'll rebase and fix that issue here in a sec.

          Show
          aw Allen Wittenauer added a comment - $@ & $* This actually comes from shellcheck's sage advice: Assigning an array to a string! Assign as array, or use * instead of @ to concatenate. shouldn't we put a deprecation message in hadoop-daemons.sh and yarn-daemons.sh ? That's a good point. I'll rebase and fix that issue here in a sec.
          Hide
          rvs Roman Shaposhnik added a comment -

          A few questions/nits:

          • why this change in start-dfs.sh:
             #Add other possible options
            -nameStartOpt="$nameStartOpt $@"
            +nameStartOpt="$nameStartOpt $*"
            
          • shouldn't we put a deprecation message in hadoop-daemons.sh and yarn-daemons.sh ?

          Other than that – looks good to me

          Show
          rvs Roman Shaposhnik added a comment - A few questions/nits: why this change in start-dfs.sh: #Add other possible options -nameStartOpt="$nameStartOpt $@" +nameStartOpt="$nameStartOpt $*" shouldn't we put a deprecation message in hadoop-daemons.sh and yarn-daemons.sh ? Other than that – looks good to me
          Hide
          hadoopqa Hadoop QA added a comment -



          +1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 2m 48s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings.
          +1 site 2m 52s Site still builds.
          0 shellcheck 2m 52s Shellcheck was not available.
              6m 4s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12728166/HADOOP-11590-03.patch
          Optional Tests site shellcheck
          git revision trunk / f83c55a
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6179/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 pre-patch 2m 48s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 release audit 0m 20s The applied patch does not increase the total number of release audit warnings. +1 site 2m 52s Site still builds. 0 shellcheck 2m 52s Shellcheck was not available.     6m 4s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12728166/HADOOP-11590-03.patch Optional Tests site shellcheck git revision trunk / f83c55a Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6179/console This message was automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          -03.

          • addresses comments

          For '-hostnames' and '-hosts', if not provided, then 'slaves' file will be used. This should be mentioned in doc.

          It's implied, but I'll make it more explicit.

          I doubt whether yarn configurations would be loaded while getting this configurations. Because hdfs getconf is a Hdfs tool and loads only Hdfs configurations using HdfsConfiguration.init();. have you verified this?

          I've been using this since it was added. Despite getconf being an hdfs command, it works for pretty much everything. It's sort of dumb that it is hidden in hdfs, but oh well.

          $ bin/hdfs getconf -confKey yarn.nodemanager.aux-services
          mapreduce_shuffle
          $ bin/hdfs getconf -confKey mapreduce.framework.name
          yarn
          $ bin/hdfs getconf -confKey hadoop.security.auth_to_local
          RULE:[1:$1@$0]s/([^@]+)@([^\.]+).COM/$2-$1/ 
          
          Show
          aw Allen Wittenauer added a comment - -03. addresses comments For '- hostnames' and ' -hosts', if not provided, then 'slaves' file will be used. This should be mentioned in doc. It's implied, but I'll make it more explicit. I doubt whether yarn configurations would be loaded while getting this configurations. Because hdfs getconf is a Hdfs tool and loads only Hdfs configurations using HdfsConfiguration.init();. have you verified this? I've been using this since it was added. Despite getconf being an hdfs command, it works for pretty much everything. It's sort of dumb that it is hidden in hdfs, but oh well. $ bin/hdfs getconf -confKey yarn.nodemanager.aux-services mapreduce_shuffle $ bin/hdfs getconf -confKey mapreduce.framework.name yarn $ bin/hdfs getconf -confKey hadoop.security.auth_to_local RULE:[1:$1@$0]s/([^@]+)@([^\.]+).COM/$2-$1/
          Hide
          vinayrpet Vinayakumar B added a comment -

          Thanks Allen Wittenauer for the patch.
          Some comments.

          1. For '--hostnames' and '--hosts', if not provided, then 'slaves' file will be used. This should be mentioned in doc.

          2. Executing the below line 2 times in case of Non-HA. which is not necessary.

              SECONDARY_NAMENODES=$("${HADOOP_HDFS_HOME}/bin/hdfs" getconf -secondarynamenodes 2>/dev/null)

          3. I doubt whether yarn configurations would be loaded while getting this configurations. Because hdfs getconf is a Hdfs tool and loads only Hdfs configurations using HdfsConfiguration.init();. have you verified this?

          +HARM=$("${HADOOP_HDFS_HOME}/bin/hdfs" getconf -confKey yarn.resourcemanager.ha.enabled 2>&-)
          Show
          vinayrpet Vinayakumar B added a comment - Thanks Allen Wittenauer for the patch. Some comments. 1. For '--hostnames' and '--hosts', if not provided, then 'slaves' file will be used. This should be mentioned in doc. 2. Executing the below line 2 times in case of Non-HA. which is not necessary. SECONDARY_NAMENODES=$( "${HADOOP_HDFS_HOME}/bin/hdfs" getconf -secondarynamenodes 2>/dev/ null ) 3. I doubt whether yarn configurations would be loaded while getting this configurations. Because hdfs getconf is a Hdfs tool and loads only Hdfs configurations using HdfsConfiguration.init(); . have you verified this? +HARM=$( "${HADOOP_HDFS_HOME}/bin/hdfs" getconf -confKey yarn.resourcemanager.ha.enabled 2>&-)
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12726963/HADOOP-11590-02.patch
          against trunk revision 997408e.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestDFSClientFailover

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6142//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6142//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726963/HADOOP-11590-02.patch against trunk revision 997408e. +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The following test timeouts occurred in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDFSClientFailover Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6142//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6142//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          Making this a blocker for 3.x since we shouldn't ship code that uses deprecations....

          Show
          aw Allen Wittenauer added a comment - Making this a blocker for 3.x since we shouldn't ship code that uses deprecations....
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12701772/HADOOP-11590-01.patch
          against trunk revision e9ac88a.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5803//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5803//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12701772/HADOOP-11590-01.patch against trunk revision e9ac88a. +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5803//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5803//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          -01:

          Show
          aw Allen Wittenauer added a comment - -01: Updated to include HDFS-5420
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12700952/HADOOP-11590-00.patch
          against trunk revision dce8b9c.

          +1 @author. The patch does not contain any @author tags.

          +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5787//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5787//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12700952/HADOOP-11590-00.patch against trunk revision dce8b9c. +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5787//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5787//console This message is automatically generated.
          Hide
          aw Allen Wittenauer added a comment -

          -00:

          • Fix up some of the docs
          • rewrite start/stop dfs/yarn
          • yarn now launches HA RMs
          • yarn now launches proxy servers
          Show
          aw Allen Wittenauer added a comment - -00: Fix up some of the docs rewrite start/stop dfs/yarn yarn now launches HA RMs yarn now launches proxy servers

            People

            • Assignee:
              aw Allen Wittenauer
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development