Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11544

Remove unused configuration keys for tracing

Details

    • Improvement
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • 2.7.0
    • 2.7.0
    • None
    • None
    • Reviewed

    Description

      CommonConfigurationKeys.HADOOP_TRACE_SAMPLER* are no longer used.

      Attachments

        1. HADOOP-11544.001.patch
          0.9 kB
          Masatake Iwasaki
        2. HADOOP-11544.002.patch
          2 kB
          Masatake Iwasaki

        Issue Links

          Activity

            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12696368/HADOOP-11544.001.patch
            against trunk revision 26dee14.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. There were no new javadoc warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

            org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl

            Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5574//testReport/
            Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5574//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696368/HADOOP-11544.001.patch against trunk revision 26dee14. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5574//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5574//console This message is automatically generated.
            aajisaka Akira Ajisaka added a comment -

            The patch looks good to me.
            One comment: "hadoop.htrace.sampler" looks noop, so could you remove the parameter from core-site.xml and update the document for tracing also?

            aajisaka Akira Ajisaka added a comment - The patch looks good to me. One comment: "hadoop.htrace.sampler" looks noop, so could you remove the parameter from core-site.xml and update the document for tracing also?

            Thanks for the comment ajisakaa. I removed the entry of "hadoop.htrace.sampler" from core-default.xml because the default (NeverSampler) is defined in org.apache.htrace.SamplerBuilder.

            I would like to left the description in Tracing.apt.vm because users still can use "hadoop.htrace.sampler" for setting trace sampler though the config key should be specified as TraceUtils.HTRACE_CONF_PREFIX + SamplerBuilder.SAMPLER_CONF_KEY rather than CommonConfigurationKeys.HADOOP_TRACE_SAMPLER in java code.

            iwasakims Masatake Iwasaki added a comment - Thanks for the comment ajisakaa . I removed the entry of "hadoop.htrace.sampler" from core-default.xml because the default (NeverSampler) is defined in org.apache.htrace.SamplerBuilder. I would like to left the description in Tracing.apt.vm because users still can use "hadoop.htrace.sampler" for setting trace sampler though the config key should be specified as TraceUtils.HTRACE_CONF_PREFIX + SamplerBuilder.SAMPLER_CONF_KEY rather than CommonConfigurationKeys.HADOOP_TRACE_SAMPLER in java code.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12696406/HADOOP-11544.002.patch
            against trunk revision 26dee14.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. There were no new javadoc warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common.

            Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5576//testReport/
            Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5576//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12696406/HADOOP-11544.002.patch against trunk revision 26dee14. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5576//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5576//console This message is automatically generated.
            aajisaka Akira Ajisaka added a comment -

            Thanks iwasakims for updating the patch. Make sense, +1.

            aajisaka Akira Ajisaka added a comment - Thanks iwasakims for updating the patch. Make sense, +1.
            aajisaka Akira Ajisaka added a comment -

            Committed this to trunk and branch-2. Thanks Masatake for the contribution!

            aajisaka Akira Ajisaka added a comment - Committed this to trunk and branch-2. Thanks Masatake for the contribution!
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-trunk-Commit #7000 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7000/)
            HADOOP-11544. Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea)

            • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7000 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7000/ ) HADOOP-11544 . Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #95 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/95/)
            HADOOP-11544. Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea)

            • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #95 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/95/ ) HADOOP-11544 . Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java hadoop-common-project/hadoop-common/CHANGES.txt
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk #2045 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2045/)
            HADOOP-11544. Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea)

            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2045 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2045/ ) HADOOP-11544 . Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            cmccabe Colin McCabe added a comment -

            Thanks, iwasakims!

            cmccabe Colin McCabe added a comment - Thanks, iwasakims !
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #95 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/95/)
            HADOOP-11544. Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea)

            • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            • hadoop-common-project/hadoop-common/CHANGES.txt
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #95 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/95/ ) HADOOP-11544 . Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/CHANGES.txt
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Yarn-trunk #829 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/829/)
            HADOOP-11544. Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea)

            • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #829 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/829/ ) HADOOP-11544 . Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Hdfs-trunk #2027 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2027/)
            HADOOP-11544. Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea)

            • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2027 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2027/ ) HADOOP-11544 . Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java hadoop-common-project/hadoop-common/CHANGES.txt
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #92 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/92/)
            HADOOP-11544. Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea)

            • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
            • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #92 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/92/ ) HADOOP-11544 . Remove unused configuration keys for tracing. Contributed by Masatake Iwasaki. (aajisaka: rev 42548f4dc2b2e8ace891b970c2c6712c02bb43ea) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/CommonConfigurationKeys.java hadoop-common-project/hadoop-common/CHANGES.txt

            People

              iwasakims Masatake Iwasaki
              iwasakims Masatake Iwasaki
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: