Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.6.0
    • Fix Version/s: 2.7.0
    • Component/s: fs/s3
    • Labels:
      None

      Description

      Currently in s3a, only the socket timeout is configurable, i.e. how long to wait before an existing connection is declared dead. The aws sdk has a separate timeout for establishing a connection. This patch introduces a config option in s3a to pass this on.

      1. HADOOP-11521.001.patch
        2 kB
        Thomas Demoor
      2. HADOOP-11521-002.patch
        3 kB
        Thomas Demoor

        Issue Links

          Activity

          Hide
          thodemoor Thomas Demoor added a comment -

          The socket time is poorly named fs.s3a.connection.timeout. In order to be backwards compatible, I named the connection timeout: s.s3a.connection.establish.timeout. Is this OK or should we rename the current connection.timeout to socket.timeout?

          Show
          thodemoor Thomas Demoor added a comment - The socket time is poorly named fs.s3a.connection.timeout. In order to be backwards compatible, I named the connection timeout: s.s3a.connection.establish.timeout. Is this OK or should we rename the current connection.timeout to socket.timeout?
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12695753/HADOOP-11521.001.patch
          against trunk revision 4cbaa74.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-aws.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5667//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5667//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12695753/HADOOP-11521.001.patch against trunk revision 4cbaa74. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-aws. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5667//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5667//console This message is automatically generated.
          Hide
          thodemoor Thomas Demoor added a comment -

          Added entries in site documentation and core-default

          Show
          thodemoor Thomas Demoor added a comment - Added entries in site documentation and core-default
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12699275/HADOOP-11521-002.patch
          against trunk revision f24a567.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5726//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5726//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12699275/HADOOP-11521-002.patch against trunk revision f24a567. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5726//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5726//console This message is automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          +1. All tests pass

          Results :
          
          Tests run: 209, Failures: 0, Errors: 0, Skipped: 6
          
          [INFO] ------------------------------------------------------------------------
          [INFO] BUILD SUCCESS
          [INFO] ------------------------------------------------------------------------
          [INFO] Total time: 45:52.677s
          [INFO] Finished at: Tue Feb 17 19:33:57 GMT 2015
          [INFO] Final Memory: 20M/317M
          [INFO] ------------------------------------------------------------------------
          
          Show
          stevel@apache.org Steve Loughran added a comment - +1. All tests pass Results : Tests run: 209, Failures: 0, Errors: 0, Skipped: 6 [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 45:52.677s [INFO] Finished at: Tue Feb 17 19:33:57 GMT 2015 [INFO] Final Memory: 20M/317M [INFO] ------------------------------------------------------------------------
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #7134 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7134/)
          HADOOP-11521. Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd)

          • hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7134 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7134/ ) HADOOP-11521 . Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd) hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #842 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/842/)
          HADOOP-11521. Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
          • hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #842 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/842/ ) HADOOP-11521 . Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #108 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/108/)
          HADOOP-11521. Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd)

          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md
          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #108 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/108/ ) HADOOP-11521 . Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd) hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #99 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/99/)
          HADOOP-11521. Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd)

          • hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md
          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #99 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/99/ ) HADOOP-11521 . Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd) hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #2040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2040/)
          HADOOP-11521. Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd)

          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md
          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2040 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2040/ ) HADOOP-11521 . Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd) hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #109 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/109/)
          HADOOP-11521. Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd)

          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          • hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md
          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #109 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/109/ ) HADOOP-11521 . Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd) hadoop-common-project/hadoop-common/src/main/resources/core-default.xml hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #2059 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2059/)
          HADOOP-11521. Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd)

          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java
          • hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md
          • hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2059 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2059/ ) HADOOP-11521 . Make connection timeout configurable in s3a. (Thomas Demoor via stevel) (stevel: rev 00b80958d862dbcc08d6f186c09963d3351ba0fd) hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-aws/src/site/markdown/tools/hadoop-aws/index.md hadoop-common-project/hadoop-common/src/main/resources/core-default.xml
          Hide
          liuml07 Mingliang Liu added a comment -

          fs.s3a.connection.establish.timeout is in millionsecond or second? The default value is 5000 or 50000?

          Would you kindly comment on HADOOP-12671? Thanks.

          Show
          liuml07 Mingliang Liu added a comment - fs.s3a.connection.establish.timeout is in millionsecond or second? The default value is 5000 or 50000? Would you kindly comment on HADOOP-12671 ? Thanks.
          Hide
          liuml07 Mingliang Liu added a comment -

          I mean millisecond or second. Sorry for the typo.

          Show
          liuml07 Mingliang Liu added a comment - I mean millisecond or second. Sorry for the typo.

            People

            • Assignee:
              thodemoor Thomas Demoor
              Reporter:
              thodemoor Thomas Demoor
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development