Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11512

Use getTrimmedStrings when reading serialization keys

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.6.0
    • 2.7.0
    • io
    • None
    • Reviewed

    Description

      In the file hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/serializer/SerializationFactory.java, we grab the IO_SERIALIZATIONS_KEY config as Configuration#getStrings(…) which does not trim the input. This could cause confusing user issues if someone manually overrides the key in the XML files/Configuration object without using the dynamic approach.

      The call should instead use Configuration#getTrimmedStrings(…), so the whitespace is trimmed before the class names are searched on the classpath.

      Attachments

        1. HADOOP-11512.branch-2.patch
          3 kB
          Harsh J
        2. HADOOP-11512.patch
          3 kB
          Harsh J
        3. HADOOP-11512.patch
          3 kB
          Ryan P
        4. HADOOP-11512.patch
          3 kB
          Ryan P
        5. HADOOP-11512.patch
          2 kB
          Ryan P
        6. HADOOP-11512.patch
          2 kB
          Ryan P

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Ryan P Ryan P
            qwertymaniac Harsh J
            Votes:
            2 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment