[HADOOP-11484] hadoop-mapreduce-client-nativetask fails to build on ARM AARCH64 due to x86 asm statements

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.0.0-alpha1
• Component/s: native

Environment

ARM aarch64 development board

• Assignee: Edward Nevill
• Reporter: Edward Nevill
• Created: 15/Jan/15 15:34
• Updated: 12/May/16 18:23
• Resolved: 21/Jan/15 19:32

Description

Hadoop fails to build on ARM aarch64 (or any non x86 platform) because of the following in

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/lib/primitives.h

/**
 * little-endian to big-endian or vice versa
 */
inline uint32_t bswap(uint32_t val) {
  __asm__("bswap %0" : "=r" (val) : "0" (val));
  return val;
}

inline uint64_t bswap64(uint64_t val) {
#ifdef __X64
  __asm__("bswapq %0" : "=r" (val) : "0" (val));
#else

  uint64_t lower = val & 0xffffffffU;
  uint32_t higher = (val >> 32) & 0xffffffffU;

  lower = bswap(lower);
  higher = bswap(higher);

  return (lower << 32) + higher;

#endif
  return val;
}

The following also fails in

hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask/src/main/native/src/util/Checksum.cc

static uint32_t cpuid(uint32_t eax_in) {
  uint32_t eax, ebx, ecx, edx;
#  if defined(__PIC__) && !defined(__LP64__)
// 32-bit PIC code uses the ebx register for the base offset --
// have to save and restore it on the stack
  asm("pushl %%ebx\n\t"
      "cpuid\n\t"
      "movl %%ebx, %[ebx]\n\t"
      "popl %%ebx" : "=a" (eax), [ebx] "=r"(ebx), "=c"(ecx), "=d"(edx) : "a" (eax_in) 
      : "cc");
#  else
  asm("cpuid" : "=a" (eax), "=b"(ebx), "=c"(ecx), "=d"(edx) : "a"(eax_in)
      : "cc");
#  endif

  return ecx;
}

Issue Links

• relates to: MAPREDUCE-6417 MapReduceClient's primitives.h is toxic and should be extirpated