Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11346

Rewrite sls/rumen to use new shell framework

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: scripts, tools
    • Labels:
      None
    1. HADOOP-11346.patch
      6 kB
      Allen Wittenauer
    2. HADOOP-11346-01.patch
      11 kB
      Allen Wittenauer
    3. HADOOP-11346-02.patch
      10 kB
      John Smith

      Issue Links

        Activity

        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2046 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2046/)
        HADOOP-11346. Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh
        • hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2046 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2046/ ) HADOOP-11346 . Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #96 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/96/)
        HADOOP-11346. Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca)

        • hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #96 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/96/ ) HADOOP-11346 . Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca) hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #92 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/92/)
        HADOOP-11346. Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh
        • hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #92 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/92/ ) HADOOP-11346 . Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #2027 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2027/)
        HADOOP-11346. Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca)

        • hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh
        • hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #2027 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2027/ ) HADOOP-11346 . Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca) hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #829 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/829/)
        HADOOP-11346. Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca)

        • hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #829 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/829/ ) HADOOP-11346 . Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca) hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #95 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/95/)
        HADOOP-11346. Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca)

        • hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
        • hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #95 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/95/ ) HADOOP-11346 . Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca) hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #7012 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7012/)
        HADOOP-11346. Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh
        • hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #7012 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7012/ ) HADOOP-11346 . Rewrite sls/rumen to use new shell framework (John Smith via aw) (aw: rev f990e9d229d3b83e2f2ce5b1921e2d3e7d318dca) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-tools/hadoop-sls/src/main/bin/slsrun.sh hadoop-tools/hadoop-sls/src/main/bin/rumen2sls.sh
        Hide
        aw Allen Wittenauer added a comment -

        +1 commit to trunk.

        Thanks!

        Show
        aw Allen Wittenauer added a comment - +1 commit to trunk. Thanks!
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12694814/HADOOP-11346-02.patch
        against trunk revision f56da3c.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        -1 findbugs. The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-sls.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5509//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5509//artifact/patchprocess/newPatchFindbugsWarningshadoop-sls.html
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5509//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12694814/HADOOP-11346-02.patch against trunk revision f56da3c. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. -1 findbugs . The patch appears to introduce 13 new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-sls. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5509//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5509//artifact/patchprocess/newPatchFindbugsWarningshadoop-sls.html Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5509//console This message is automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        It'd be great if you also cygwin'd the paths so that this has a better chance of working on Windows. See the code in hadoop-functions.sh finalize area.

        Show
        aw Allen Wittenauer added a comment - It'd be great if you also cygwin'd the paths so that this has a better chance of working on Windows. See the code in hadoop-functions.sh finalize area.
        Hide
        pocky John Smith added a comment -

        Updated to fix no more JAVA_HEAP_MAX

        Show
        pocky John Smith added a comment - Updated to fix no more JAVA_HEAP_MAX
        Hide
        aw Allen Wittenauer added a comment -

        Now that HADOOP-10950 has been committed, this patch needs to be updated to remove JAVA_HEAP_MAX.

        Show
        aw Allen Wittenauer added a comment - Now that HADOOP-10950 has been committed, this patch needs to be updated to remove JAVA_HEAP_MAX.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12684744/HADOOP-11346-01.patch
        against trunk revision 52bcefc.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed unit tests in hadoop-tools/hadoop-sls.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5144//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5144//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12684744/HADOOP-11346-01.patch against trunk revision 52bcefc. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-tools/hadoop-sls. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5144//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5144//console This message is automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        -01:

        • rumen2sls.sh converted
        • fix a shellcheck error in slsrun.sh
        Show
        aw Allen Wittenauer added a comment - -01: rumen2sls.sh converted fix a shellcheck error in slsrun.sh
        Hide
        aw Allen Wittenauer added a comment -

        -00:

        First pass. This only has slsrun.sh in it.

        Show
        aw Allen Wittenauer added a comment - -00: First pass. This only has slsrun.sh in it.

          People

          • Assignee:
            pocky John Smith
            Reporter:
            aw Allen Wittenauer
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development