[HADOOP-11283] Potentially unclosed SequenceFile.Writer in DistCpV1#setup()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.6.0
• Fix Version/s: 2.7.0
• Target Version/s: 2.7.0
• Hadoop Flags: Reviewed
• Assignee: Varun Saxena
• Reporter: Ted Yu
• Created: 08/Nov/14 00:00
• Updated: 10/Apr/15 20:04
• Resolved: 25/Dec/14 14:33

Description

    SequenceFile.Writer src_writer = SequenceFile.createWriter(jobfs, jobConf,
        srcfilelist, LongWritable.class, FilePair.class,
        SequenceFile.CompressionType.NONE);

    Path dstfilelist = new Path(jobDirectory, "_distcp_dst_files");
    SequenceFile.Writer dst_writer = SequenceFile.createWriter(jobfs, jobConf,
        dstfilelist, Text.class, Text.class,
        SequenceFile.CompressionType.NONE);

If creation of dst_writer throws exception, src_writer would be left unclosed since there is no finally clause doing that for the above code.