Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11208

Replace "daemon" with better name in script subcommands

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: scripts
    • Labels:
      None

      Description

      Per discussion in HDFS-7204, creating this jira.

      Thanks Allen Wittenauer for the work on HDFS-7204.

      1. HADOOP-11208.patch
        7 kB
        Allen Wittenauer

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #11 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/11/)
          HADOOP-11208. Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b)

          • hadoop-mapreduce-project/bin/mapred
          • hadoop-yarn-project/hadoop-yarn/bin/yarn
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #11 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/11/ ) HADOOP-11208 . Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b) hadoop-mapreduce-project/bin/mapred hadoop-yarn-project/hadoop-yarn/bin/yarn hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1963 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1963/)
          HADOOP-11208. Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b)

          • hadoop-mapreduce-project/bin/mapred
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-yarn-project/hadoop-yarn/bin/yarn
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1963 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1963/ ) HADOOP-11208 . Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b) hadoop-mapreduce-project/bin/mapred hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs hadoop-common-project/hadoop-common/CHANGES.txt hadoop-yarn-project/hadoop-yarn/bin/yarn
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk #1939 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1939/)
          HADOOP-11208. Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          • hadoop-mapreduce-project/bin/mapred
          • hadoop-yarn-project/hadoop-yarn/bin/yarn
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1939 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1939/ ) HADOOP-11208 . Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs hadoop-mapreduce-project/bin/mapred hadoop-yarn-project/hadoop-yarn/bin/yarn
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #11 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/11/)
          HADOOP-11208. Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b)

          • hadoop-yarn-project/hadoop-yarn/bin/yarn
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-mapreduce-project/bin/mapred
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #11 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/11/ ) HADOOP-11208 . Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b) hadoop-yarn-project/hadoop-yarn/bin/yarn hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs hadoop-common-project/hadoop-common/CHANGES.txt hadoop-mapreduce-project/bin/mapred
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #749 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/749/)
          HADOOP-11208. Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-mapreduce-project/bin/mapred
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          • hadoop-yarn-project/hadoop-yarn/bin/yarn
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #749 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/749/ ) HADOOP-11208 . Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-mapreduce-project/bin/mapred hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs hadoop-yarn-project/hadoop-yarn/bin/yarn
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #11 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/11/)
          HADOOP-11208. Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b)

          • hadoop-mapreduce-project/bin/mapred
          • hadoop-yarn-project/hadoop-yarn/bin/yarn
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #11 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/11/ ) HADOOP-11208 . Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b) hadoop-mapreduce-project/bin/mapred hadoop-yarn-project/hadoop-yarn/bin/yarn hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          Hide
          aw Allen Wittenauer added a comment -

          FYI, also updated https://wiki.apache.org/hadoop/UnixShellScriptProgrammingGuide to reflect these changes.

          Show
          aw Allen Wittenauer added a comment - FYI, also updated https://wiki.apache.org/hadoop/UnixShellScriptProgrammingGuide to reflect these changes.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6575 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6575/)
          HADOOP-11208. Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-mapreduce-project/bin/mapred
          • hadoop-yarn-project/hadoop-yarn/bin/yarn
          • hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6575 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6575/ ) HADOOP-11208 . Replace "daemon" with better name in script subcommands (aw) (aw: rev 72c141ba969aa9090528e4b79beb891fbfb03c1b) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-mapreduce-project/bin/mapred hadoop-yarn-project/hadoop-yarn/bin/yarn hadoop-hdfs-project/hadoop-hdfs/src/main/bin/hdfs
          Hide
          aw Allen Wittenauer added a comment -

          +1 self review since this is a minor, minor change. Committed to trunk.

          Show
          aw Allen Wittenauer added a comment - +1 self review since this is a minor, minor change. Committed to trunk.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12681197/HADOOP-11208.patch
          against trunk revision bcd402a.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestFileCreationClient

          The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs:

          org.apache.hadoop.hdfs.TestDatanodeBlockScanner

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5099//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5099//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12681197/HADOOP-11208.patch against trunk revision bcd402a. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestFileCreationClient The following test timeouts occurred in hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestDatanodeBlockScanner +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5099//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5099//console This message is automatically generated.
          Hide
          yzhangal Yongjun Zhang added a comment -

          Hi Allen, Thanks a lot for taking care of this jira. I looked through and your patch looks good to me.

          Show
          yzhangal Yongjun Zhang added a comment - Hi Allen, Thanks a lot for taking care of this jira. I looked through and your patch looks good to me.
          Hide
          aw Allen Wittenauer added a comment -

          Changes the local "daemon" variable to "supportdaemonization".

          Documentation change will be made on the wiki to the shell scripting guide after commit.

          Show
          aw Allen Wittenauer added a comment - Changes the local "daemon" variable to "supportdaemonization". Documentation change will be made on the wiki to the shell scripting guide after commit.

            People

            • Assignee:
              aw Allen Wittenauer
              Reporter:
              yzhangal Yongjun Zhang
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development