Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.8.0, 3.0.0-alpha1
    • Component/s: ipc
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      RemoteException has a number of undocumented behaviors

      • o.a.h.ipc.RemoteException has no javadocs on getClassName. Reading the source, the String returned is the classname of the wrapped remote exception.
      • RemoteException(String, String) is equivalent to calling RemoteException(String, String, null)
      • Constructors allow null for all arguments
      • Some of the test code doesn't check for correct error codes to correspond with the wrapped exception type
      • methods don't document when they might return null
      1. HADOOP-11103.1.patch
        8 kB
        Sean Busbey
      2. HADOOP-11103.2.patch
        12 kB
        Sean Busbey

        Activity

        Hide
        fwiffo Joey Echeverria added a comment -

        +1 (non-binding)

        Show
        fwiffo Joey Echeverria added a comment - +1 (non-binding)
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12669533/HADOOP-11103.1.patch
        against trunk revision f230248.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
        org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4751//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4751//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12669533/HADOOP-11103.1.patch against trunk revision f230248. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4751//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4751//console This message is automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12669533/HADOOP-11103.1.patch
        against trunk revision ed70fa1.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 2 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.server.namenode.TestFileTruncate

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5848//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5848//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12669533/HADOOP-11103.1.patch against trunk revision ed70fa1. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 2 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.server.namenode.TestFileTruncate Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5848//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5848//console This message is automatically generated.
        Hide
        busbey Sean Busbey added a comment -

        TestFileTruncate passes locally.

        Show
        busbey Sean Busbey added a comment - TestFileTruncate passes locally.
        Hide
        busbey Sean Busbey added a comment -

        updated patch to ensure it works on current trunk, added tests for statements in the javadocs about how unspecified error codes are handled and how unwrapping might fail.

        Show
        busbey Sean Busbey added a comment - updated patch to ensure it works on current trunk, added tests for statements in the javadocs about how unspecified error codes are handled and how unwrapping might fail.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12726640/HADOOP-11103.2.patch
        against trunk revision f967fd2.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified test files.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs:

        org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6131//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6131//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12726640/HADOOP-11103.2.patch against trunk revision f967fd2. +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 3 new or modified test files. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.hdfs.TestEncryptionZonesWithKMS Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/6131//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/6131//console This message is automatically generated.
        Hide
        vinayrpet Vinayakumar B added a comment -

        +1,
        Will commit shortly.

        Show
        vinayrpet Vinayakumar B added a comment - +1, Will commit shortly.
        Hide
        vinayrpet Vinayakumar B added a comment -

        Committed to trunk and branch-2
        Thanks Sean Busbey

        Show
        vinayrpet Vinayakumar B added a comment - Committed to trunk and branch-2 Thanks Sean Busbey
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #7859 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7859/)
        HADOOP-11103. Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #7859 (See https://builds.apache.org/job/Hadoop-trunk-Commit/7859/ ) HADOOP-11103 . Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #932 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/932/)
        HADOOP-11103. Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #932 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/932/ ) HADOOP-11103 . Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #201 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/201/)
        HADOOP-11103. Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk-Java8 #201 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/201/ ) HADOOP-11103 . Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #2130 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2130/)
        HADOOP-11103. Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #2130 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/2130/ ) HADOOP-11103 . Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/190/)
        HADOOP-11103. Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #190 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/190/ ) HADOOP-11103 . Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/200/)
        HADOOP-11103. Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71)

        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java
        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #200 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/200/ ) HADOOP-11103 . Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #2148 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2148/)
        HADOOP-11103. Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71)

        • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #2148 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2148/ ) HADOOP-11103 . Clean up RemoteException (Contributed by Sean Busbey) (vinayakumarb: rev d4a2830b63f0819979b592f4ea6ea3abd5885b71) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestHASafeMode.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RemoteException.java hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java

          People

          • Assignee:
            busbey Sean Busbey
            Reporter:
            busbey Sean Busbey
          • Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development