[HADOOP-11101] How about inputstream close statement from catch block to finally block in FileContext#copy() ?

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.1
• Fix Version/s: 2.6.0
• Assignee: skrho
• Reporter: skrho
• Created: 17/Sep/14 10:48
• Updated: 01/Dec/14 03:08
• Resolved: 25/Sep/14 07:27

Description

If IOException is happended, can be catched exception block..
But another excpetion is happended, can't be catched exception block.. also Stream object can't be closed..

        try {
          in = open(qSrc);
          EnumSet<CreateFlag> createFlag = overwrite ? EnumSet.of(
              CreateFlag.CREATE, CreateFlag.OVERWRITE) : 
                EnumSet.of(CreateFlag.CREATE);
          out = create(qDst, createFlag);
          IOUtils.copyBytes(in, out, conf, true);
        } catch (IOException e) {
          IOUtils.closeStream(out);
          IOUtils.closeStream(in);
          throw e;
        }