Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Won't Fix
    • Affects Version/s: 2.7.3
    • Fix Version/s: None
    • Component/s: fs/s3
    • Labels:
      None

      Description

      jets3t 0.9.2 contains a fix that caused failure of multi-part uploads with service-side encryption.
      http://jets3t.s3.amazonaws.com/RELEASE_NOTES.html

      (it also removes an exception thrown from the RestS3Service constructor which requires removing the try/catch around that code)

      1. HADOOP-11086.2.patch
        5 kB
        Sean Busbey
      2. HADOOP-11086-branch-2-003.patch
        5 kB
        Steve Loughran
      3. HADOOP-11086-v0.patch
        4 kB
        Matteo Bertozzi

        Issue Links

          Activity

          Hide
          stevel@apache.org Steve Loughran added a comment -

          I'm closing this as a WONTFIX. If there are visible regressions in testing, i don't know what will surface in the field.

          Please, if people want more current S3 integration: make the switch to s3a.

          Show
          stevel@apache.org Steve Loughran added a comment - I'm closing this as a WONTFIX. If there are visible regressions in testing, i don't know what will surface in the field. Please, if people want more current S3 integration: make the switch to s3a.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 7m 12s branch-2 passed
          +1 compile 6m 0s branch-2 passed with JDK v1.8.0_101
          +1 compile 6m 47s branch-2 passed with JDK v1.7.0_111
          +1 checkstyle 1m 23s branch-2 passed
          +1 mvnsite 1m 33s branch-2 passed
          +1 mvneclipse 1m 32s branch-2 passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 2m 15s branch-2 passed
          +1 javadoc 1m 18s branch-2 passed with JDK v1.8.0_101
          +1 javadoc 1m 32s branch-2 passed with JDK v1.7.0_111
          0 mvndep 0m 19s Maven dependency ordering for patch
          +1 mvninstall 1m 14s the patch passed
          +1 compile 5m 50s the patch passed with JDK v1.8.0_101
          +1 javac 5m 50s the patch passed
          +1 compile 6m 47s the patch passed with JDK v1.7.0_111
          +1 javac 6m 47s the patch passed
          -0 checkstyle 1m 30s root: The patch generated 34 new + 55 unchanged - 2 fixed = 89 total (was 57)
          +1 mvnsite 1m 45s the patch passed
          +1 mvneclipse 1m 2s the patch passed
          -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 xml 0m 2s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project
          +1 findbugs 3m 7s the patch passed
          +1 javadoc 1m 30s the patch passed with JDK v1.8.0_101
          +1 javadoc 1m 41s the patch passed with JDK v1.7.0_111
          +1 unit 0m 16s hadoop-project in the patch passed with JDK v1.7.0_111.
          +1 unit 9m 4s hadoop-common in the patch passed with JDK v1.7.0_111.
          +1 unit 0m 34s hadoop-aws in the patch passed with JDK v1.7.0_111.
          +1 asflicense 0m 38s The patch does not generate ASF License warnings.
          100m 11s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:b59b8b7
          JIRA Issue HADOOP-11086
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831320/HADOOP-11086-branch-2-003.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux 888bd9be2519 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 04f594d
          Default Java 1.7.0_111
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10642/artifact/patchprocess/diff-checkstyle-root.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10642/artifact/patchprocess/whitespace-eol.txt
          JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10642/testReport/
          modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: .
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10642/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 7m 12s branch-2 passed +1 compile 6m 0s branch-2 passed with JDK v1.8.0_101 +1 compile 6m 47s branch-2 passed with JDK v1.7.0_111 +1 checkstyle 1m 23s branch-2 passed +1 mvnsite 1m 33s branch-2 passed +1 mvneclipse 1m 32s branch-2 passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 2m 15s branch-2 passed +1 javadoc 1m 18s branch-2 passed with JDK v1.8.0_101 +1 javadoc 1m 32s branch-2 passed with JDK v1.7.0_111 0 mvndep 0m 19s Maven dependency ordering for patch +1 mvninstall 1m 14s the patch passed +1 compile 5m 50s the patch passed with JDK v1.8.0_101 +1 javac 5m 50s the patch passed +1 compile 6m 47s the patch passed with JDK v1.7.0_111 +1 javac 6m 47s the patch passed -0 checkstyle 1m 30s root: The patch generated 34 new + 55 unchanged - 2 fixed = 89 total (was 57) +1 mvnsite 1m 45s the patch passed +1 mvneclipse 1m 2s the patch passed -1 whitespace 0m 0s The patch has 47 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 xml 0m 2s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project +1 findbugs 3m 7s the patch passed +1 javadoc 1m 30s the patch passed with JDK v1.8.0_101 +1 javadoc 1m 41s the patch passed with JDK v1.7.0_111 +1 unit 0m 16s hadoop-project in the patch passed with JDK v1.7.0_111. +1 unit 9m 4s hadoop-common in the patch passed with JDK v1.7.0_111. +1 unit 0m 34s hadoop-aws in the patch passed with JDK v1.7.0_111. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 100m 11s Subsystem Report/Notes Docker Image:yetus/hadoop:b59b8b7 JIRA Issue HADOOP-11086 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831320/HADOOP-11086-branch-2-003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux 888bd9be2519 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28 20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 04f594d Default Java 1.7.0_111 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_101 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10642/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/10642/artifact/patchprocess/whitespace-eol.txt JDK v1.7.0_111 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10642/testReport/ modules C: hadoop-project hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws U: . Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10642/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Patch 003:

          • moves to 0.9.4
          • moves jet3t dependency unde hadoop-aws, which you need on the classpath for s3n/s3a anyway.
          • Tested? S3 US-east.

          This patch does not work; s3:// tests are failing with auth problems

          I'm not going to put any time into look at this, because it's clearly more than a simple patch & test run, at least to understand the failures. I've put in 1h already and am declaring defeat & unenthusiasm for debugging a problem which only appears to be surfacing on s3, but not s3n or s3a (hence: not clock problems)

          testSeekZeroByteFile(org.apache.hadoop.fs.contract.s3.ITestS3ContractSeek)  Time elapsed: 0.452 sec  <<< ERROR!
          org.apache.hadoop.fs.s3.S3Exception: org.jets3t.service.S3ServiceException: Service Error Message. -- ResponseCode: 403, ResponseStatus: Forbidden, XML Error Message: <?xml version="1.0" encoding="UTF-8"?><Error><Code>SignatureDoesNotMatch</Code><Message>The request signature we calculated does not match the signature you provided. Check your key and signing method.</Message><AWSAccessKeyId>AKIAIYZ5JQOW3N5H6NPA</AWSAccessKeyId><StringToSign>GETMon, 03 Oct 2016 12:29:34 GMT/hwdev-steve-useast/</StringToSign><SignatureProvided>AYzprUagWZ6w12dI9jzmWPucFKU=</SignatureProvided><StringToSignBytes>47 45 54 0a 0a 0a 4d 6f 6e 2c 20 30 33 20 4f 63 74 20 32 30 31 36 20 31 32 3a 32 39 3a 33 34 20 47 4d 54 0a 2f 68 77 64 65 76 2d 73 74 65 76 65 2d 6e 65 77 2f</StringToSignBytes><RequestId>075F76464E06D512</RequestId><HostId>bfBm6fT3i+3q8jThLDMXY877oIBjyyW6iJ4mDRj0gSE4wJYXOf2M2dgRSpwJpJRPiEhHsypF2ho=</HostId></Error>
          	at org.apache.hadoop.fs.s3.Jets3tFileSystemStore.get(Jets3tFileSystemStore.java:169)
          	at org.apache.hadoop.fs.s3.Jets3tFileSystemStore.retrieveINode(Jets3tFileSystemStore.java:215)
          	at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:498)
          	at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:398)
          	at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163)
          	at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
          	at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
          	at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:335)
          	at com.sun.proxy.$Proxy12.retrieveINode(Unknown Source)
          	at org.apache.hadoop.fs.s3.S3FileSystem.mkdir(S3FileSystem.java:202)
          	at org.apache.hadoop.fs.s3.S3FileSystem.mkdirs(S3FileSystem.java:189)
          	at org.apache.hadoop.fs.FileSystem.mkdirs(FileSystem.java:2005)
          	at org.apache.hadoop.fs.contract.AbstractFSContractTestBase.mkdirs(AbstractFSContractTestBase.java:338)
          	at org.apache.hadoop.fs.contract.AbstractFSContractTestBase.setup(AbstractFSContractTestBase.java:193)
          	at org.apache.hadoop.fs.contract.AbstractContractSeekTest.setup(AbstractContractSeekTest.java:56)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:498)
          	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
          	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
          	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
          	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
          	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
          Caused by: org.jets3t.service.S3ServiceException: Service Error Message.
          	at org.jets3t.service.S3Service.getObject(S3Service.java:1470)
          	at org.apache.hadoop.fs.s3.Jets3tFileSystemStore.get(Jets3tFileSystemStore.java:157)
          	at org.apache.hadoop.fs.s3.Jets3tFileSystemStore.retrieveINode(Jets3tFileSystemStore.java:215)
          	at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:498)
          	at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:398)
          	at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163)
          	at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155)
          	at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95)
          	at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:335)
          	at com.sun.proxy.$Proxy12.retrieveINode(Unknown Source)
          	at org.apache.hadoop.fs.s3.S3FileSystem.mkdir(S3FileSystem.java:202)
          	at org.apache.hadoop.fs.s3.S3FileSystem.mkdirs(S3FileSystem.java:189)
          	at org.apache.hadoop.fs.FileSystem.mkdirs(FileSystem.java:2005)
          	at org.apache.hadoop.fs.contract.AbstractFSContractTestBase.mkdirs(AbstractFSContractTestBase.java:338)
          	at org.apache.hadoop.fs.contract.AbstractFSContractTestBase.setup(AbstractFSContractTestBase.java:193)
          	at org.apache.hadoop.fs.contract.AbstractContractSeekTest.setup(AbstractContractSeekTest.java:56)
          	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
          	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
          	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          	at java.lang.reflect.Method.invoke(Method.java:498)
          	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
          	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
          	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
          	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
          	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
          	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
          	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
          
          Show
          stevel@apache.org Steve Loughran added a comment - Patch 003: moves to 0.9.4 moves jet3t dependency unde hadoop-aws, which you need on the classpath for s3n/s3a anyway. Tested? S3 US-east. This patch does not work; s3:// tests are failing with auth problems I'm not going to put any time into look at this, because it's clearly more than a simple patch & test run, at least to understand the failures. I've put in 1h already and am declaring defeat & unenthusiasm for debugging a problem which only appears to be surfacing on s3, but not s3n or s3a (hence: not clock problems) testSeekZeroByteFile(org.apache.hadoop.fs.contract.s3.ITestS3ContractSeek) Time elapsed: 0.452 sec <<< ERROR! org.apache.hadoop.fs.s3.S3Exception: org.jets3t.service.S3ServiceException: Service Error Message. -- ResponseCode: 403, ResponseStatus: Forbidden, XML Error Message: <?xml version= "1.0" encoding= "UTF-8" ?><Error><Code>SignatureDoesNotMatch</Code><Message>The request signature we calculated does not match the signature you provided. Check your key and signing method.</Message><AWSAccessKeyId>AKIAIYZ5JQOW3N5H6NPA</AWSAccessKeyId><StringToSign>GETMon, 03 Oct 2016 12:29:34 GMT/hwdev-steve-useast/</StringToSign><SignatureProvided>AYzprUagWZ6w12dI9jzmWPucFKU=</SignatureProvided><StringToSignBytes>47 45 54 0a 0a 0a 4d 6f 6e 2c 20 30 33 20 4f 63 74 20 32 30 31 36 20 31 32 3a 32 39 3a 33 34 20 47 4d 54 0a 2f 68 77 64 65 76 2d 73 74 65 76 65 2d 6e 65 77 2f</StringToSignBytes><RequestId>075F76464E06D512</RequestId><HostId>bfBm6fT3i+3q8jThLDMXY877oIBjyyW6iJ4mDRj0gSE4wJYXOf2M2dgRSpwJpJRPiEhHsypF2ho=</HostId></Error> at org.apache.hadoop.fs.s3.Jets3tFileSystemStore.get(Jets3tFileSystemStore.java:169) at org.apache.hadoop.fs.s3.Jets3tFileSystemStore.retrieveINode(Jets3tFileSystemStore.java:215) at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:398) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95) at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:335) at com.sun.proxy.$Proxy12.retrieveINode(Unknown Source) at org.apache.hadoop.fs.s3.S3FileSystem.mkdir(S3FileSystem.java:202) at org.apache.hadoop.fs.s3.S3FileSystem.mkdirs(S3FileSystem.java:189) at org.apache.hadoop.fs.FileSystem.mkdirs(FileSystem.java:2005) at org.apache.hadoop.fs.contract.AbstractFSContractTestBase.mkdirs(AbstractFSContractTestBase.java:338) at org.apache.hadoop.fs.contract.AbstractFSContractTestBase.setup(AbstractFSContractTestBase.java:193) at org.apache.hadoop.fs.contract.AbstractContractSeekTest.setup(AbstractContractSeekTest.java:56) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74) Caused by: org.jets3t.service.S3ServiceException: Service Error Message. at org.jets3t.service.S3Service.getObject(S3Service.java:1470) at org.apache.hadoop.fs.s3.Jets3tFileSystemStore.get(Jets3tFileSystemStore.java:157) at org.apache.hadoop.fs.s3.Jets3tFileSystemStore.retrieveINode(Jets3tFileSystemStore.java:215) at sun.reflect.GeneratedMethodAccessor10.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:398) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeMethod(RetryInvocationHandler.java:163) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invoke(RetryInvocationHandler.java:155) at org.apache.hadoop.io.retry.RetryInvocationHandler$Call.invokeOnce(RetryInvocationHandler.java:95) at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:335) at com.sun.proxy.$Proxy12.retrieveINode(Unknown Source) at org.apache.hadoop.fs.s3.S3FileSystem.mkdir(S3FileSystem.java:202) at org.apache.hadoop.fs.s3.S3FileSystem.mkdirs(S3FileSystem.java:189) at org.apache.hadoop.fs.FileSystem.mkdirs(FileSystem.java:2005) at org.apache.hadoop.fs.contract.AbstractFSContractTestBase.mkdirs(AbstractFSContractTestBase.java:338) at org.apache.hadoop.fs.contract.AbstractFSContractTestBase.setup(AbstractFSContractTestBase.java:193) at org.apache.hadoop.fs.contract.AbstractContractSeekTest.setup(AbstractContractSeekTest.java:56) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55) at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Tried setting version to 0.9.4, it being later. Maven is rejecting a convergency problem (nice!), though ot's between mockserver-netty and bouncycastle.

          1. I think we might want to have this patch move the jets3t JAR out of hadoop-common and under hadoop-aws
          2. don't know what to do about versions here; I'd vote for the 1.52 version of bouncycastle in the shipping code. Are we shipping bouncycastle today?
            [INFO] --- maven-enforcer-plugin:1.4.1:enforce (depcheck) @ hadoop-hdfs-client ---
            [WARNING] 
            Dependency convergence error for org.bouncycastle:bcprov-jdk15on:1.52 paths to dependency are:
            +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT
              +-org.apache.hadoop:hadoop-common:2.9.0-SNAPSHOT
                +-net.java.dev.jets3t:jets3t:0.9.4
                  +-org.bouncycastle:bcprov-jdk15on:1.52
            and
            +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT
              +-org.mock-server:mockserver-netty:3.9.2
                +-org.mock-server:mockserver-core:3.9.2
                  +-org.bouncycastle:bcprov-jdk15on:1.51
            and
            +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT
              +-org.mock-server:mockserver-netty:3.9.2
                +-org.bouncycastle:bcprov-jdk15on:1.51
            
            [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
            Failed while enforcing releasability the error(s) are [
            Dependency convergence error for org.bouncycastle:bcprov-jdk15on:1.52 paths to dependency are:
            +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT
              +-org.apache.hadoop:hadoop-common:2.9.0-SNAPSHOT
                +-net.java.dev.jets3t:jets3t:0.9.4
                  +-org.bouncycastle:bcprov-jdk15on:1.52
            and
            +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT
              +-org.mock-server:mockserver-netty:3.9.2
                +-org.mock-server:mockserver-core:3.9.2
                  +-org.bouncycastle:bcprov-jdk15on:1.51
            and
            +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT
              +-org.mock-server:mockserver-netty:3.9.2
                +-org.bouncycastle:bcprov-jdk15on:1.51
            ]
            
          Show
          stevel@apache.org Steve Loughran added a comment - Tried setting version to 0.9.4, it being later. Maven is rejecting a convergency problem (nice!), though ot's between mockserver-netty and bouncycastle. I think we might want to have this patch move the jets3t JAR out of hadoop-common and under hadoop-aws don't know what to do about versions here; I'd vote for the 1.52 version of bouncycastle in the shipping code. Are we shipping bouncycastle today? [INFO] --- maven-enforcer-plugin:1.4.1:enforce (depcheck) @ hadoop-hdfs-client --- [WARNING] Dependency convergence error for org.bouncycastle:bcprov-jdk15on:1.52 paths to dependency are: +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT +-org.apache.hadoop:hadoop-common:2.9.0-SNAPSHOT +-net.java.dev.jets3t:jets3t:0.9.4 +-org.bouncycastle:bcprov-jdk15on:1.52 and +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT +-org.mock-server:mockserver-netty:3.9.2 +-org.mock-server:mockserver-core:3.9.2 +-org.bouncycastle:bcprov-jdk15on:1.51 and +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT +-org.mock-server:mockserver-netty:3.9.2 +-org.bouncycastle:bcprov-jdk15on:1.51 [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message: Failed while enforcing releasability the error(s) are [ Dependency convergence error for org.bouncycastle:bcprov-jdk15on:1.52 paths to dependency are: +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT +-org.apache.hadoop:hadoop-common:2.9.0-SNAPSHOT +-net.java.dev.jets3t:jets3t:0.9.4 +-org.bouncycastle:bcprov-jdk15on:1.52 and +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT +-org.mock-server:mockserver-netty:3.9.2 +-org.mock-server:mockserver-core:3.9.2 +-org.bouncycastle:bcprov-jdk15on:1.51 and +-org.apache.hadoop:hadoop-hdfs-client:2.9.0-SNAPSHOT +-org.mock-server:mockserver-netty:3.9.2 +-org.bouncycastle:bcprov-jdk15on:1.51 ]
          Hide
          stevel@apache.org Steve Loughran added a comment -

          I will see if I can look at this, bumping up the version. If it passes the tests I will get it in

          Show
          stevel@apache.org Steve Loughran added a comment - I will see if I can look at this, bumping up the version. If it passes the tests I will get it in
          Hide
          busbey Sean Busbey added a comment -

          The odds that I'll find the time to test updating this in time for 2.8 are very low. If I'm wrong I'll reassign to myself, but for now it's best if someone else looks after this.

          Show
          busbey Sean Busbey added a comment - The odds that I'll find the time to test updating this in time for 2.8 are very low. If I'm wrong I'll reassign to myself, but for now it's best if someone else looks after this.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 8s HADOOP-11086 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HADOOP-11086
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12731600/HADOOP-11086.2.patch
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10396/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 8s HADOOP-11086 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HADOOP-11086 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12731600/HADOOP-11086.2.patch Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10396/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          0.9.4 is now shipping, if you want to carefully test a patch which moves branch-2.8+ up to it

          Show
          stevel@apache.org Steve Loughran added a comment - 0.9.4 is now shipping, if you want to carefully test a patch which moves branch-2.8+ up to it
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 15m 17s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          -1 javac 7m 50s The applied patch generated 1 additional warning messages.
          +1 javadoc 9m 42s There were no new javadoc warning messages.
          +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 20s The applied patch generated 34 new checkstyle issues (total was 57, now 89).
          +1 whitespace 0m 0s The patch has no lines that end in whitespace.
          +1 install 1m 21s mvn install still works.
          +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse.
          +1 findbugs 0m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings.
          +1 tools/hadoop tests 0m 15s Tests passed in hadoop-aws.
              36m 32s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731600/HADOOP-11086.2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 176131f
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7302/artifact/patchprocess/diffJavacWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7302/artifact/patchprocess/diffcheckstylehadoop-aws.txt
          hadoop-aws test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7302/artifact/patchprocess/testrun_hadoop-aws.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7302/testReport/
          Java 1.7.0_55
          uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7302/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 15m 17s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac 7m 50s The applied patch generated 1 additional warning messages. +1 javadoc 9m 42s There were no new javadoc warning messages. +1 release audit 0m 23s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 20s The applied patch generated 34 new checkstyle issues (total was 57, now 89). +1 whitespace 0m 0s The patch has no lines that end in whitespace. +1 install 1m 21s mvn install still works. +1 eclipse:eclipse 0m 36s The patch built with eclipse:eclipse. +1 findbugs 0m 45s The patch does not introduce any new Findbugs (version 3.0.0) warnings. +1 tools/hadoop tests 0m 15s Tests passed in hadoop-aws.     36m 32s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731600/HADOOP-11086.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 176131f javac https://builds.apache.org/job/PreCommit-HADOOP-Build/7302/artifact/patchprocess/diffJavacWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/7302/artifact/patchprocess/diffcheckstylehadoop-aws.txt hadoop-aws test log https://builds.apache.org/job/PreCommit-HADOOP-Build/7302/artifact/patchprocess/testrun_hadoop-aws.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/7302/testReport/ Java 1.7.0_55 uname Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/7302/console This message was automatically generated.
          Hide
          stevel@apache.org Steve Loughran added a comment -

          Looking at this patch, why has the exception catch/unwrap/rethrow stuff been removed? Has the signature of the constructor changed?

          Show
          stevel@apache.org Steve Loughran added a comment - Looking at this patch, why has the exception catch/unwrap/rethrow stuff been removed? Has the signature of the constructor changed?
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 14m 38s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          -1 javac 7m 40s The applied patch generated 122 additional warning messages.
          +1 javadoc 9m 40s There were no new javadoc warning messages.
          +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 0m 18s The applied patch generated 34 new checkstyle issues (total was 57, now 89).
          -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 38s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          +1 findbugs 0m 37s The patch does not introduce any new Findbugs (version 2.0.3) warnings.
          +1 tools/hadoop tests 0m 14s Tests passed in hadoop-aws.
              35m 45s  



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12731600/HADOOP-11086.2.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 30099a3
          javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/artifact/patchprocess/diffJavacWarnings.txt
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/artifact/patchprocess/diffcheckstylehadoop-aws.txt
          whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/artifact/patchprocess/whitespace.txt
          hadoop-aws test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/artifact/patchprocess/testrun_hadoop-aws.txt
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/testReport/
          Java 1.7.0_55
          uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 14m 38s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. -1 tests included 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac 7m 40s The applied patch generated 122 additional warning messages. +1 javadoc 9m 40s There were no new javadoc warning messages. +1 release audit 0m 22s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 0m 18s The applied patch generated 34 new checkstyle issues (total was 57, now 89). -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 38s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. +1 findbugs 0m 37s The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 tools/hadoop tests 0m 14s Tests passed in hadoop-aws.     35m 45s   Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12731600/HADOOP-11086.2.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 30099a3 javac https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/artifact/patchprocess/diffJavacWarnings.txt checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/artifact/patchprocess/diffcheckstylehadoop-aws.txt whitespace https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/artifact/patchprocess/whitespace.txt hadoop-aws test log https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/artifact/patchprocess/testrun_hadoop-aws.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/testReport/ Java 1.7.0_55 uname Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/6561/console This message was automatically generated.
          Hide
          busbey Sean Busbey added a comment -

          updated patch for current trunk. excludes javax.mail and javax.annotations.

          The javax.mail dependency (and likely others) was because the S3 functionality is mushed up with some other stuff. (see Jets3t issue #195)

          Show
          busbey Sean Busbey added a comment - updated patch for current trunk. excludes javax.mail and javax.annotations. The javax.mail dependency (and likely others) was because the S3 functionality is mushed up with some other stuff. (see Jets3t issue #195 )
          Hide
          stevel@apache.org Steve Loughran added a comment -

          note that jets3t is inconsistent itself, with both transitive 1.1 and 1.1.1 dependencies

          1. why does it need javax.mail?
          2. if the activation dependeny is excluded from under jets3t then everything else will stay as is —for now—. This will isolate the jets3t patch from having impact across the entire codebase
          Show
          stevel@apache.org Steve Loughran added a comment - note that jets3t is inconsistent itself, with both transitive 1.1 and 1.1.1 dependencies why does it need javax.mail? if the activation dependeny is excluded from under jets3t then everything else will stay as is —for now—. This will isolate the jets3t patch from having impact across the entire codebase
          Hide
          stevel@apache.org Steve Loughran added a comment -

          aws failure is dependency convergence; jets3t uses v 1.1.1 of javax.activation

          
          

          [INFO] — maven-enforcer-plugin:1.3.1:enforce (depcheck) @ hadoop-aws —
          [WARNING]
          Dependency convergence error for javax.activation:activation:1.1 paths to dependency are:
          +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT
          +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT
          +-com.sun.jersey:jersey-json:1.9
          +-com.sun.xml.bind:jaxb-impl:2.2.3-1
          +-javax.xml.bind:jaxb-api:2.2.2
          +-javax.activation:activation:1.1
          and
          +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT
          +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT
          +-net.java.dev.jets3t:jets3t:0.9.2
          +-javax.activation:activation:1.1.1
          and
          +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT
          +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT
          +-net.java.dev.jets3t:jets3t:0.9.2
          +-javax.mail:mail:1.4.7
          +-javax.activation:activation:1.1

          [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message:
          Failed while enforcing releasability the error(s) are [
          Dependency convergence error for javax.activation:activation:1.1 paths to dependency are:
          +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT
          +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT
          +-com.sun.jersey:jersey-json:1.9
          +-com.sun.xml.bind:jaxb-impl:2.2.3-1
          +-javax.xml.bind:jaxb-api:2.2.2
          +-javax.activation:activation:1.1
          and
          +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT
          +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT
          +-net.java.dev.jets3t:jets3t:0.9.2
          +-javax.activation:activation:1.1.1
          and
          +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT
          +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT
          +-net.java.dev.jets3t:jets3t:0.9.2
          +-javax.mail:mail:1.4.7
          +-javax.activation:activation:1.1
          {code]

          Show
          stevel@apache.org Steve Loughran added a comment - aws failure is dependency convergence; jets3t uses v 1.1.1 of javax.activation [INFO] — maven-enforcer-plugin:1.3.1:enforce (depcheck) @ hadoop-aws — [WARNING] Dependency convergence error for javax.activation:activation:1.1 paths to dependency are: +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT +-com.sun.jersey:jersey-json:1.9 +-com.sun.xml.bind:jaxb-impl:2.2.3-1 +-javax.xml.bind:jaxb-api:2.2.2 +-javax.activation:activation:1.1 and +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT +-net.java.dev.jets3t:jets3t:0.9.2 +-javax.activation:activation:1.1.1 and +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT +-net.java.dev.jets3t:jets3t:0.9.2 +-javax.mail:mail:1.4.7 +-javax.activation:activation:1.1 [WARNING] Rule 0: org.apache.maven.plugins.enforcer.DependencyConvergence failed with message: Failed while enforcing releasability the error(s) are [ Dependency convergence error for javax.activation:activation:1.1 paths to dependency are: +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT +-com.sun.jersey:jersey-json:1.9 +-com.sun.xml.bind:jaxb-impl:2.2.3-1 +-javax.xml.bind:jaxb-api:2.2.2 +-javax.activation:activation:1.1 and +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT +-net.java.dev.jets3t:jets3t:0.9.2 +-javax.activation:activation:1.1.1 and +-org.apache.hadoop:hadoop-aws:3.0.0-SNAPSHOT +-org.apache.hadoop:hadoop-common:3.0.0-SNAPSHOT +-net.java.dev.jets3t:jets3t:0.9.2 +-javax.mail:mail:1.4.7 +-javax.activation:activation:1.1 {code]
          Hide
          stevel@apache.org Steve Loughran added a comment -

          javac warning is spurious

          73a74
          > [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/KeyStoreTestUtil.java:[55,28] [deprecation] X509V1CertificateGenerator in org.bouncycastle.x509 has been deprecated
          
          Show
          stevel@apache.org Steve Loughran added a comment - javac warning is spurious 73a74 > [WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/ssl/KeyStoreTestUtil.java:[55,28] [deprecation] X509V1CertificateGenerator in org.bouncycastle.x509 has been deprecated
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12668147/HADOOP-11086-v0.patch
          against trunk revision 6f9fe76.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          -1 javac. The applied patch generated 1188 javac compiler warnings (more than the trunk's current 1187 warnings).

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The test build failed in hadoop-tools/hadoop-aws

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5501//testReport/
          Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5501//artifact/patchprocess/diffJavacWarnings.txt
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5501//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12668147/HADOOP-11086-v0.patch against trunk revision 6f9fe76. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac . The applied patch generated 1188 javac compiler warnings (more than the trunk's current 1187 warnings). +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The test build failed in hadoop-tools/hadoop-aws Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/5501//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/5501//artifact/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/5501//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12668147/HADOOP-11086-v0.patch
          against trunk revision 581176c.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The test build failed in hadoop-tools/hadoop-aws

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4700//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4700//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12668147/HADOOP-11086-v0.patch against trunk revision 581176c. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The test build failed in hadoop-tools/hadoop-aws +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4700//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4700//console This message is automatically generated.

            People

            • Assignee:
              Unassigned
              Reporter:
              mbertozzi Matteo Bertozzi
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development