Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Incompatible change
    • Release Note:
      This changes the output of the 'hadoop version' command to generically say 'Source code repository' rather than specify which type of repo.

      Description

      In VersionInfo.java, It is assumed that code is managed by SVN as:

      System.out.println("Subversion " + getUrl() + " -r " + getRevision());

      It can be changed to:

      System.out.println("Source code repository: " + getUrl() + " -r " + getRevision());

      1. HADOOP-11041.1.patch
        1.0 kB
        Tsuyoshi Ozawa

        Activity

        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Good catch, Guo! Attached a patch to fix the problem.

        Show
        ozawa Tsuyoshi Ozawa added a comment - Good catch, Guo! Attached a patch to fix the problem.
        Hide
        ajisakaa Akira Ajisaka added a comment -

        LGTM, +1 (non-binding).

        Show
        ajisakaa Akira Ajisaka added a comment - LGTM, +1 (non-binding).
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Thanks for your review, Akira. Aaron T. Myers, I've seen you've changed VersionInfo.java before. Could you review a patch, please?

        Show
        ozawa Tsuyoshi Ozawa added a comment - Thanks for your review, Akira. Aaron T. Myers , I've seen you've changed VersionInfo.java before. Could you review a patch, please?
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12665700/HADOOP-11041.1.patch
        against trunk revision 258c7d0.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

        org.apache.hadoop.ha.TestZKFailoverControllerStress

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4617//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4617//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12665700/HADOOP-11041.1.patch against trunk revision 258c7d0. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverControllerStress +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4617//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4617//console This message is automatically generated.
        Hide
        aw Allen Wittenauer added a comment -

        This impacts the output of the 'hadoop version', etc command, which is very likely parsed by other stuff. So I don't think this is safe to change in branch-2.

        Show
        aw Allen Wittenauer added a comment - This impacts the output of the 'hadoop version', etc command, which is very likely parsed by other stuff. So I don't think this is safe to change in branch-2.
        Hide
        aw Allen Wittenauer added a comment -

        +1 committing this to trunk.

        Thanks!

        Show
        aw Allen Wittenauer added a comment - +1 committing this to trunk. Thanks!
        Hide
        ozawa Tsuyoshi Ozawa added a comment -

        Thanks you, Allen!

        Show
        ozawa Tsuyoshi Ozawa added a comment - Thanks you, Allen!
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Yarn-trunk #669 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/669/)
        HADOOP-11041. VersionInfo specifies subversion (Tsuyoshi OZAWA via aw) (aw: rev e06d2e3c9811d14101ee3d27e101c2cfe54c823c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #669 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/669/ ) HADOOP-11041 . VersionInfo specifies subversion (Tsuyoshi OZAWA via aw) (aw: rev e06d2e3c9811d14101ee3d27e101c2cfe54c823c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Hdfs-trunk #1860 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1860/)
        HADOOP-11041. VersionInfo specifies subversion (Tsuyoshi OZAWA via aw) (aw: rev e06d2e3c9811d14101ee3d27e101c2cfe54c823c)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        • hadoop-common-project/hadoop-common/CHANGES.txt
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1860 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1860/ ) HADOOP-11041 . VersionInfo specifies subversion (Tsuyoshi OZAWA via aw) (aw: rev e06d2e3c9811d14101ee3d27e101c2cfe54c823c) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java hadoop-common-project/hadoop-common/CHANGES.txt
        Hide
        hudson Hudson added a comment -

        FAILURE: Integrated in Hadoop-Mapreduce-trunk #1885 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1885/)
        HADOOP-11041. VersionInfo specifies subversion (Tsuyoshi OZAWA via aw) (aw: rev e06d2e3c9811d14101ee3d27e101c2cfe54c823c)

        • hadoop-common-project/hadoop-common/CHANGES.txt
        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java
        Show
        hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1885 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1885/ ) HADOOP-11041 . VersionInfo specifies subversion (Tsuyoshi OZAWA via aw) (aw: rev e06d2e3c9811d14101ee3d27e101c2cfe54c823c) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/util/VersionInfo.java

          People

          • Assignee:
            ozawa Tsuyoshi Ozawa
            Reporter:
            rguo Guo Ruijing
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development