Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11025

hadoop-daemons.sh should just call hdfs directly

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: scripts
    • Labels:
      None

      Description

      There is little-to-no reason for it to call hadoop-daemon.sh anymore.

      1. HADOOP-11025.1.patch
        1 kB
        Masatake Iwasaki
      2. HADOOP-11025.2.patch
        2 kB
        Masatake Iwasaki

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/4/)
          HADOOP-11025. hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288)

          • hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/4/ ) HADOOP-11025 . hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288) hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1956 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1956/)
          HADOOP-11025. hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288)

          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh
          • hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1956 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1956/ ) HADOOP-11025 . hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288) hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh hadoop-common-project/hadoop-common/CHANGES.txt
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/4/)
          HADOOP-11025. hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288)

          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh
          • hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/4/ ) HADOOP-11025 . hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288) hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1932 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1932/)
          HADOOP-11025. hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288)

          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1932 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1932/ ) HADOOP-11025 . hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288) hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-Yarn-trunk #742 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/742/)
          HADOOP-11025. hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288)

          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #742 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/742/ ) HADOOP-11025 . hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288) hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/4/)
          HADOOP-11025. hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288)

          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #4 (See https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/4/ ) HADOOP-11025 . hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288) hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #6525 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6525/)
          HADOOP-11025. hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288)

          • hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh
          • hadoop-common-project/hadoop-common/CHANGES.txt
          • hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #6525 (See https://builds.apache.org/job/Hadoop-trunk-Commit/6525/ ) HADOOP-11025 . hadoop-daemons.sh should just call hdfs directly (Masatake Iwasaki via aw) (aw: rev 306f0c9cea2d35f3f9ebf25ad6af99723e4c7288) hadoop-common-project/hadoop-common/src/main/bin/hadoop-daemons.sh hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-common/src/main/conf/hadoop-env.sh
          Hide
          aw Allen Wittenauer added a comment -

          Committed to trunk.

          Show
          aw Allen Wittenauer added a comment - Committed to trunk.
          Hide
          aw Allen Wittenauer added a comment -

          +1 will commit to trunk.

          Thanks!!

          Show
          aw Allen Wittenauer added a comment - +1 will commit to trunk. Thanks!!
          Hide
          iwasakims Masatake Iwasaki added a comment -

          The patch get hadoop-daemon.sh not to be called from anywhere in bundled scripts and make it only for backward compatibility. Though this might make hadoop-daemon.sh easier to be left behind on future update, I think it is better to make it clear what hadoop-daemon*s*.sh is doing.

          Show
          iwasakims Masatake Iwasaki added a comment - The patch get hadoop-daemon.sh not to be called from anywhere in bundled scripts and make it only for backward compatibility. Though this might make hadoop-daemon.sh easier to be left behind on future update, I think it is better to make it clear what hadoop-daemon*s*.sh is doing.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          I updated the patch to fix comment referring hadoop-daemon.sh.

          Show
          iwasakims Masatake Iwasaki added a comment - I updated the patch to fix comment referring hadoop-daemon.sh.
          Hide
          iwasakims Masatake Iwasaki added a comment -

          attaching patch.

          Show
          iwasakims Masatake Iwasaki added a comment - attaching patch.

            People

            • Assignee:
              iwasakims Masatake Iwasaki
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development