Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-11002

shell escapes are incompatible with previous releases

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: scripts
    • Labels:

      Description

      Post-HADOOP-9902, the following in xyz_OPTS doesn't work without being escaped:

      -XX:HeapDumpPath=./java_pid_<pid>.hprof
      

      This is a bit of surprising behavior to the users. The breakage is directly result of the code that fixes spaces in directories. Since it is much more likely to hit weird metacharacters in shell than have directories with spaces, that part of HADOOP-9902 needs to get replaced.

      1. HADOOP-11002.patch
        4 kB
        Allen Wittenauer

        Issue Links

          Activity

          Hide
          aw Allen Wittenauer added a comment -

          Thanks! I'll commit this as soon as git opens up!

          Show
          aw Allen Wittenauer added a comment - Thanks! I'll commit this as soon as git opens up!
          Hide
          cmccabe Colin P. McCabe added a comment -

          The reasoning here looks sound. If spaces-in-directories don't work for branch-2, we don't need to support them here. And the eval obviously is problematic.

          +1

          Show
          cmccabe Colin P. McCabe added a comment - The reasoning here looks sound. If spaces-in-directories don't work for branch-2, we don't need to support them here. And the eval obviously is problematic. +1
          Hide
          aw Allen Wittenauer added a comment -

          (It's worth pointing out that directories with spaces are completely broken in branch-2. HADOOP-9902 made quite a few things work, but without fixing this issue, not enough to be usable.)

          Show
          aw Allen Wittenauer added a comment - (It's worth pointing out that directories with spaces are completely broken in branch-2. HADOOP-9902 made quite a few things work, but without fixing this issue, not enough to be usable.)
          Hide
          aw Allen Wittenauer added a comment -

          This removes support for spaces.

          Show
          aw Allen Wittenauer added a comment - This removes support for spaces.
          Hide
          aw Allen Wittenauer added a comment -

          After playing with this for most of today, I've come to the conclusion that we're going to have to drop support for directories with spaces. There's simply no, 100% reliable way to make them work with a global var like HADOOP_OPTS without doing some really bizarre tricks that break other things. Support for metacharacters like < is significantly more important.

          Show
          aw Allen Wittenauer added a comment - After playing with this for most of today, I've come to the conclusion that we're going to have to drop support for directories with spaces. There's simply no, 100% reliable way to make them work with a global var like HADOOP_OPTS without doing some really bizarre tricks that break other things. Support for metacharacters like < is significantly more important.

            People

            • Assignee:
              aw Allen Wittenauer
              Reporter:
              aw Allen Wittenauer
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development