Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10990

Add missed NFSv3 request and response classes

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 2.2.0
    • 2.6.0
    • nfs
    • None
    • Reviewed

    Description

      Two RPC calls were missed in original NFS implementation: LINK and MKNOD. This JIRA is to track the effort of adding the missed RPC calls.

      Attachments

        1. HADOOP-10990.002.patch
          11 kB
          Brandon Li
        2. HADOOP-10990.001.patch
          10 kB
          Brandon Li

        Issue Links

          Activity

            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12663500/HADOOP-10990.001.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. There were no new javadoc warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

            -1 release audit. The applied patch generated 3 release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-nfs.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4529//testReport/
            Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4529//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
            Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4529//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12663500/HADOOP-10990.001.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. -1 release audit . The applied patch generated 3 release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4529//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4529//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4529//console This message is automatically generated.
            wheat9 Haohui Mai added a comment -

            +1. The release warnings are unrelated:

             !????? /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/EncryptionZoneWithId.java
             !????? /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java
             !????? /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionFaultInjector.java
            Lines that start with ????? in the release audit report indicate files that do not have an Apache license header.
            
            wheat9 Haohui Mai added a comment - +1. The release warnings are unrelated: !????? /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/EncryptionZoneWithId.java !????? /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionZoneManager.java !????? /home/jenkins/jenkins-slave/workspace/PreCommit-HADOOP-Build/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/EncryptionFaultInjector.java Lines that start with ????? in the release audit report indicate files that do not have an Apache license header.
            wheat9 Haohui Mai added a comment -

            Since In HDFS-6892 you're moving away from RequestWithHandle towards Nfs3Request, is it possible to change the patch to follow the same convention as well?

            wheat9 Haohui Mai added a comment - Since In HDFS-6892 you're moving away from RequestWithHandle towards Nfs3Request , is it possible to change the patch to follow the same convention as well?
            brandonli Brandon Li added a comment -

            Sure. I will re-base the patch after HDFS-6892 is committed. Thanks!

            brandonli Brandon Li added a comment - Sure. I will re-base the patch after HDFS-6892 is committed. Thanks!
            brandonli Brandon Li added a comment -

            Uploaded a new patch to address Haohui's comment.

            brandonli Brandon Li added a comment - Uploaded a new patch to address Haohui's comment.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12664731/HADOOP-10990.002.patch
            against trunk revision .

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            -1 javac. The patch appears to cause the build to fail.

            Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4557//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12664731/HADOOP-10990.002.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4557//console This message is automatically generated.
            brandonli Brandon Li added a comment -

            Looks like jenkins svn is not synced with git yet. Will wait for a while and resubmit the patch.

            brandonli Brandon Li added a comment - Looks like jenkins svn is not synced with git yet. Will wait for a while and resubmit the patch.
            hadoopqa Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12664731/HADOOP-10990.002.patch
            against trunk revision e1109fb.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 javadoc. There were no new javadoc warning messages.

            +1 eclipse:eclipse. The patch built with eclipse:eclipse.

            +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            +1 core tests. The patch passed unit tests in hadoop-common-project/hadoop-nfs.

            +1 contrib tests. The patch passed contrib unit tests.

            Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4630//testReport/
            Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4630//console

            This message is automatically generated.

            hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12664731/HADOOP-10990.002.patch against trunk revision e1109fb. +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. +1 core tests . The patch passed unit tests in hadoop-common-project/hadoop-nfs. +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4630//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4630//console This message is automatically generated.
            wheat9 Haohui Mai added a comment -

            +1

            wheat9 Haohui Mai added a comment - +1
            brandonli Brandon Li added a comment -

            Thank you, wheat9. I've committed the patch.

            brandonli Brandon Li added a comment - Thank you, wheat9 . I've committed the patch.

            Looks like this commit caused a merge commit. We should try and avoid them - https://wiki.apache.org/hadoop/HowToCommitWithGit has guidelines that can help avoid.

            kkambatl Karthik Kambatla (Inactive) added a comment - Looks like this commit caused a merge commit. We should try and avoid them - https://wiki.apache.org/hadoop/HowToCommitWithGit has guidelines that can help avoid.
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Yarn-trunk #669 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/669/)
            HADOOP-10990. Add missed NFSv3 request and response classes. Contributed by Brandon Li (brandonli: rev bad5f38d47f5e93c21641931ac92595c71b05bd7)

            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/MKNOD3Response.java
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/LINK3Request.java
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/Nfs3FileAttributes.java
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/LINK3Response.java
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/MKNOD3Request.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Yarn-trunk #669 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/669/ ) HADOOP-10990 . Add missed NFSv3 request and response classes. Contributed by Brandon Li (brandonli: rev bad5f38d47f5e93c21641931ac92595c71b05bd7) hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/MKNOD3Response.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/LINK3Request.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/Nfs3FileAttributes.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/LINK3Response.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/MKNOD3Request.java hadoop-common-project/hadoop-common/CHANGES.txt
            hudson Hudson added a comment -

            SUCCESS: Integrated in Hadoop-Hdfs-trunk #1860 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1860/)
            HADOOP-10990. Add missed NFSv3 request and response classes. Contributed by Brandon Li (brandonli: rev bad5f38d47f5e93c21641931ac92595c71b05bd7)

            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/LINK3Response.java
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/Nfs3FileAttributes.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/LINK3Request.java
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/MKNOD3Response.java
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/MKNOD3Request.java
            hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-Hdfs-trunk #1860 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1860/ ) HADOOP-10990 . Add missed NFSv3 request and response classes. Contributed by Brandon Li (brandonli: rev bad5f38d47f5e93c21641931ac92595c71b05bd7) hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/LINK3Response.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/Nfs3FileAttributes.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/LINK3Request.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/MKNOD3Response.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/MKNOD3Request.java
            hudson Hudson added a comment -

            FAILURE: Integrated in Hadoop-Mapreduce-trunk #1885 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1885/)
            HADOOP-10990. Add missed NFSv3 request and response classes. Contributed by Brandon Li (brandonli: rev bad5f38d47f5e93c21641931ac92595c71b05bd7)

            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/Nfs3FileAttributes.java
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/LINK3Request.java
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/MKNOD3Response.java
            • hadoop-common-project/hadoop-common/CHANGES.txt
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/LINK3Response.java
            • hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/MKNOD3Request.java
            hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1885 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1885/ ) HADOOP-10990 . Add missed NFSv3 request and response classes. Contributed by Brandon Li (brandonli: rev bad5f38d47f5e93c21641931ac92595c71b05bd7) hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/Nfs3FileAttributes.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/LINK3Request.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/MKNOD3Response.java hadoop-common-project/hadoop-common/CHANGES.txt hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/response/LINK3Response.java hadoop-common-project/hadoop-nfs/src/main/java/org/apache/hadoop/nfs/nfs3/request/MKNOD3Request.java
            brandonli Brandon Li added a comment -

            Sorry, kasha. I will be more careful next time.

            brandonli Brandon Li added a comment - Sorry, kasha . I will be more careful next time.

            No issues, we are all adjusting to git. Sorry for being the policeman here.

            kkambatl Karthik Kambatla (Inactive) added a comment - No issues, we are all adjusting to git. Sorry for being the policeman here.
            brandonli Brandon Li added a comment -

            Good cop is always needed.

            brandonli Brandon Li added a comment - Good cop is always needed.

            People

              brandonli Brandon Li
              brandonli Brandon Li
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: