Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-10980

TestActiveStandbyElector fails occasionally in trunk

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha1
    • Fix Version/s: 2.8.0, 2.7.4, 3.0.0-alpha1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      From https://builds.apache.org/job/Hadoop-Common-trunk/1211/consoleFull :

      Running org.apache.hadoop.ha.TestActiveStandbyElector
      Tests run: 23, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.7 sec <<< FAILURE! - in org.apache.hadoop.ha.TestActiveStandbyElector
      testWithoutZKServer(org.apache.hadoop.ha.TestActiveStandbyElector)  Time elapsed: 0.051 sec  <<< FAILURE!
      java.lang.AssertionError: Did not throw zookeeper connection loss exceptions!
      	at org.junit.Assert.fail(Assert.java:88)
      	at org.apache.hadoop.ha.TestActiveStandbyElector.testWithoutZKServer(TestActiveStandbyElector.java:722)
      
      1. HADOOP-10980.001.patch
        1.0 kB
        Eric Badger
      2. HADOOP-10980.002.patch
        4 kB
        Eric Badger
      3. HADOOP-10980.003.patch
        4 kB
        Eric Badger

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Hadoop-trunk-Commit #10208 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10208/)
        HADOOP-10980. TestActiveStandbyElector fails occasionally in trunk. (jlowe: rev c82745432a962c817a8a7db92bb830fb6af01e33)

        • hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
        • hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #10208 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10208/ ) HADOOP-10980 . TestActiveStandbyElector fails occasionally in trunk. (jlowe: rev c82745432a962c817a8a7db92bb830fb6af01e33) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ha/TestActiveStandbyElector.java
        Hide
        jlowe Jason Lowe added a comment -

        Thanks to Eric Badger for the contribution and to Steve Loughran for diagnosing the original issue! I committed this to trunk, branch-2, branch-2.8, and branch-2.7.

        Show
        jlowe Jason Lowe added a comment - Thanks to Eric Badger for the contribution and to Steve Loughran for diagnosing the original issue! I committed this to trunk, branch-2, branch-2.8, and branch-2.7.
        Hide
        jlowe Jason Lowe added a comment -

        but I don't see how that is possible since it is explicitly set within the function. Please let me know if I'm missing something.

        The intent of overriding that method is to mock out both the ZK client and the connection to the ZK server. If we just mocked out the ZK client itself then the logic in ActiveStandbyElector that uses the ZK client to connect to the server would either fail outright (as you intentionally do for this one, specific test) or the mock needs to be much more sophisticated to fool the connection code. Overriding the method that does both the client create and server connect is simpler for the vast majority of the tests that want to focus on mocking out functionality relevant when connected to the ZK server rather.

        +1 lgtm. I'll fix the indent nit flagged by checkstyle during the commit.

        Show
        jlowe Jason Lowe added a comment - but I don't see how that is possible since it is explicitly set within the function. Please let me know if I'm missing something. The intent of overriding that method is to mock out both the ZK client and the connection to the ZK server. If we just mocked out the ZK client itself then the logic in ActiveStandbyElector that uses the ZK client to connect to the server would either fail outright (as you intentionally do for this one, specific test) or the mock needs to be much more sophisticated to fool the connection code. Overriding the method that does both the client create and server connect is simpler for the vast majority of the tests that want to focus on mocking out functionality relevant when connected to the ZK server rather. +1 lgtm. I'll fix the indent nit flagged by checkstyle during the commit.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 8s trunk passed
        +1 compile 7m 22s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 59s trunk passed
        +1 mvneclipse 0m 13s trunk passed
        +1 findbugs 1m 26s trunk passed
        +1 javadoc 0m 50s trunk passed
        +1 mvninstall 0m 53s the patch passed
        +1 compile 9m 5s the patch passed
        +1 javac 9m 5s the patch passed
        -0 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39)
        +1 mvnsite 1m 7s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 57s the patch passed
        +1 javadoc 0m 52s the patch passed
        +1 unit 9m 34s hadoop-common in the patch passed.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        44m 44s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821838/HADOOP-10980.003.patch
        JIRA Issue HADOOP-10980
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux dc66f2de119d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d848184
        Default Java 1.8.0_101
        findbugs v3.0.0
        checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10165/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10165/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10165/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 8s trunk passed +1 compile 7m 22s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 26s trunk passed +1 javadoc 0m 50s trunk passed +1 mvninstall 0m 53s the patch passed +1 compile 9m 5s the patch passed +1 javac 9m 5s the patch passed -0 checkstyle 0m 28s hadoop-common-project/hadoop-common: The patch generated 1 new + 39 unchanged - 0 fixed = 40 total (was 39) +1 mvnsite 1m 7s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 57s the patch passed +1 javadoc 0m 52s the patch passed +1 unit 9m 34s hadoop-common in the patch passed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 44m 44s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821838/HADOOP-10980.003.patch JIRA Issue HADOOP-10980 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dc66f2de119d 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d848184 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10165/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-common.txt Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10165/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10165/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ebadger Eric Badger added a comment -

        Was accidentally working on branch-2.7. Here's the trunk patch. It's the same as the previous patch, just rebased to trunk.

        Show
        ebadger Eric Badger added a comment - Was accidentally working on branch-2.7. Here's the trunk patch. It's the same as the previous patch, just rebased to trunk.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 5s HADOOP-10980 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821705/HADOOP-10980.002.patch
        JIRA Issue HADOOP-10980
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10157/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HADOOP-10980 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12821705/HADOOP-10980.002.patch JIRA Issue HADOOP-10980 Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10157/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ebadger Eric Badger added a comment -

        Attaching a patch that mocks up the ZooKeeper instance for the test, so that there will always be a connection timeout. I had to make a new protected method to gain access to the ZooKeeper instance. The getNewZooKeeper() method claims that it was made 'protected' so that a mocked ZooKeeper instance could be passed in, but I don't see how that is possible since it is explicitly set within the function. Please let me know if I'm missing something.

        Jason Lowe, does this change look correct?

        Show
        ebadger Eric Badger added a comment - Attaching a patch that mocks up the ZooKeeper instance for the test, so that there will always be a connection timeout. I had to make a new protected method to gain access to the ZooKeeper instance. The getNewZooKeeper() method claims that it was made 'protected' so that a mocked ZooKeeper instance could be passed in, but I don't see how that is possible since it is explicitly set within the function. Please let me know if I'm missing something. Jason Lowe , does this change look correct?
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 6m 37s trunk passed
        +1 compile 6m 46s trunk passed
        +1 checkstyle 0m 23s trunk passed
        +1 mvnsite 0m 53s trunk passed
        +1 mvneclipse 0m 12s trunk passed
        +1 findbugs 1m 17s trunk passed
        +1 javadoc 0m 44s trunk passed
        +1 mvninstall 0m 36s the patch passed
        +1 compile 6m 47s the patch passed
        +1 javac 6m 47s the patch passed
        +1 checkstyle 0m 23s the patch passed
        +1 mvnsite 0m 54s the patch passed
        +1 mvneclipse 0m 14s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 27s the patch passed
        +1 javadoc 0m 47s the patch passed
        +1 unit 8m 54s hadoop-common in the patch passed.
        +1 asflicense 0m 21s The patch does not generate ASF License warnings.
        38m 56s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:9560f25
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803298/HADOOP-10980.001.patch
        JIRA Issue HADOOP-10980
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux f0287f594554 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5e5b879
        Default Java 1.8.0_101
        findbugs v3.0.0
        Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10153/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10153/console
        Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 6m 37s trunk passed +1 compile 6m 46s trunk passed +1 checkstyle 0m 23s trunk passed +1 mvnsite 0m 53s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 1m 17s trunk passed +1 javadoc 0m 44s trunk passed +1 mvninstall 0m 36s the patch passed +1 compile 6m 47s the patch passed +1 javac 6m 47s the patch passed +1 checkstyle 0m 23s the patch passed +1 mvnsite 0m 54s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 27s the patch passed +1 javadoc 0m 47s the patch passed +1 unit 8m 54s hadoop-common in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 38m 56s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803298/HADOOP-10980.001.patch JIRA Issue HADOOP-10980 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f0287f594554 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5e5b879 Default Java 1.8.0_101 findbugs v3.0.0 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10153/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10153/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ebadger Eric Badger added a comment -

        Thanks for reviewing, Jason. In hindsight, I agree that using port 22 isn't a good way to get around accidentally connecting to Zookeeper. As you said, I'll mock up a zkClient and upload a new patch. Thanks!

        Show
        ebadger Eric Badger added a comment - Thanks for reviewing, Jason. In hindsight, I agree that using port 22 isn't a good way to get around accidentally connecting to Zookeeper. As you said, I'll mock up a zkClient and upload a new patch. Thanks!
        Hide
        jlowe Jason Lowe added a comment -

        Thanks for the patch, Eric!

        My main concern of using port 22 is that we're essentially testing a use-case that should never occur in practice. We're testing what the ZK client will do when we try to connect it to sshd, but that's not something we expect users will ever do. If the purpose of this test is to make sure that a ZK exception is not accidentally swallowed by the ActiveStandbyElector logic then we can mock the zkClient in the elector to throw a ZK exception when we try to connect. Then we're guaranteed to get the base ZK exception we're looking for without relying on ports being unused which is difficult to enforce in practice.

        Show
        jlowe Jason Lowe added a comment - Thanks for the patch, Eric! My main concern of using port 22 is that we're essentially testing a use-case that should never occur in practice. We're testing what the ZK client will do when we try to connect it to sshd, but that's not something we expect users will ever do. If the purpose of this test is to make sure that a ZK exception is not accidentally swallowed by the ActiveStandbyElector logic then we can mock the zkClient in the elector to throw a ZK exception when we try to connect. Then we're guaranteed to get the base ZK exception we're looking for without relying on ports being unused which is difficult to enforce in practice.
        Hide
        hadoopqa Hadoop QA added a comment -
        +1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
        +1 mvninstall 7m 1s trunk passed
        +1 compile 5m 58s trunk passed with JDK v1.8.0_91
        +1 compile 6m 52s trunk passed with JDK v1.7.0_95
        +1 checkstyle 0m 24s trunk passed
        +1 mvnsite 1m 2s trunk passed
        +1 mvneclipse 0m 14s trunk passed
        +1 findbugs 1m 37s trunk passed
        +1 javadoc 0m 52s trunk passed with JDK v1.8.0_91
        +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95
        +1 mvninstall 0m 41s the patch passed
        +1 compile 5m 56s the patch passed with JDK v1.8.0_91
        +1 javac 5m 56s the patch passed
        +1 compile 6m 46s the patch passed with JDK v1.7.0_95
        +1 javac 6m 46s the patch passed
        +1 checkstyle 0m 24s the patch passed
        +1 mvnsite 0m 58s the patch passed
        +1 mvneclipse 0m 13s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 50s the patch passed
        +1 javadoc 0m 53s the patch passed with JDK v1.8.0_91
        +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95
        +1 unit 7m 34s hadoop-common in the patch passed with JDK v1.8.0_91.
        +1 unit 7m 47s hadoop-common in the patch passed with JDK v1.7.0_95.
        +1 asflicense 0m 23s The patch does not generate ASF License warnings.
        61m 1s



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:cf2ee45
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803298/HADOOP-10980.001.patch
        JIRA Issue HADOOP-10980
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 92484a38f867 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 025219b
        Default Java 1.7.0_95
        Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
        findbugs v3.0.0
        JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9360/testReport/
        modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
        Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9360/console
        Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 1s trunk passed +1 compile 5m 58s trunk passed with JDK v1.8.0_91 +1 compile 6m 52s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 24s trunk passed +1 mvnsite 1m 2s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 37s trunk passed +1 javadoc 0m 52s trunk passed with JDK v1.8.0_91 +1 javadoc 1m 6s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 41s the patch passed +1 compile 5m 56s the patch passed with JDK v1.8.0_91 +1 javac 5m 56s the patch passed +1 compile 6m 46s the patch passed with JDK v1.7.0_95 +1 javac 6m 46s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 58s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 50s the patch passed +1 javadoc 0m 53s the patch passed with JDK v1.8.0_91 +1 javadoc 1m 6s the patch passed with JDK v1.7.0_95 +1 unit 7m 34s hadoop-common in the patch passed with JDK v1.8.0_91. +1 unit 7m 47s hadoop-common in the patch passed with JDK v1.7.0_95. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 61m 1s Subsystem Report/Notes Docker Image:yetus/hadoop:cf2ee45 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12803298/HADOOP-10980.001.patch JIRA Issue HADOOP-10980 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 92484a38f867 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 025219b Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_91 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/9360/testReport/ modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/9360/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ebadger Eric Badger added a comment -

        Attaching patch to change the default port, so that we do not connect to a zookeeper instance that is running by coincidence.

        Show
        ebadger Eric Badger added a comment - Attaching patch to change the default port, so that we do not connect to a zookeeper instance that is running by coincidence.
        Hide
        ebadger Eric Badger added a comment -

        This test failed for me locally when I was running a separate zookeeper instance. If we specify a port number, as Steve Loughran suggested, the test passes. For example, changing the port to 22, since that will likely only ever be used for SSH.

        Show
        ebadger Eric Badger added a comment - This test failed for me locally when I was running a separate zookeeper instance. If we specify a port number, as Steve Loughran suggested, the test passes. For example, changing the port to 22, since that will likely only ever be used for SSH.
        Hide
        yuzhihong@gmail.com Ted Yu added a comment -

        Hadoop-Common-trunk has been green for a while.

        Show
        yuzhihong@gmail.com Ted Yu added a comment - Hadoop-Common-trunk has been green for a while.
        Hide
        stevel@apache.org Steve Loughran added a comment -

        This may be some concurrency condition: if there is a ZK service on 2181, the test is going to connect to it, rather than fail.

        How about we change the port to something unlikely to be open, and very unlikely to be ZK if it is?

        Show
        stevel@apache.org Steve Loughran added a comment - This may be some concurrency condition: if there is a ZK service on 2181, the test is going to connect to it, rather than fail. How about we change the port to something unlikely to be open, and very unlikely to be ZK if it is?

          People

          • Assignee:
            ebadger Eric Badger
            Reporter:
            yuzhihong@gmail.com Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development