[HADOOP-10953] NetworkTopology#add calls NetworkTopology#toString without holding the netlock

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.7.0
• Component/s: net
• Target Version/s: 2.7.0
• Assignee: Liang Xie
• Reporter: Liang Xie
• Created: 11/Aug/14 09:37
• Updated: 12/May/16 18:24
• Resolved: 10/Feb/15 21:34

Description

Found this issue while reading the related code. In NetworkTopology.toString() method, there is no thread safety guarantee directly, it's called by add/remove, and inside add/remove, most of this.toString() calls are protected by rwlock, except a couple of error handling codes, one possible fix is that moving them into lock as well, due to not heavy operations, so no obvious downgration should be observed per my current knowledge.

Issue Links

• relates to: HADOOP-12173 NetworkTopology#add calls NetworkTopology#toString always