Hadoop Common
  1. Hadoop Common
  2. HADOOP-10896

Update compatibility doc to capture visibility of un-annotated classes/ methods

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 2.5.0
    • Component/s: documentation
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      From discussion on email thread, we should add something to the effect of

      "Classes without annotations are to considered @Private. Class members without specific annotations inherit the annotations of the class."

      1. hadoop-10896.patch
        1 kB
        Karthik Kambatla

        Activity

        Hide
        Karthik Kambatla (Inactive) added a comment -

        Patch that adds a policy for classes/members not annotated.

        Show
        Karthik Kambatla (Inactive) added a comment - Patch that adds a policy for classes/members not annotated.
        Hide
        Andrew Wang added a comment -

        +1 thanks karthik

        Show
        Andrew Wang added a comment - +1 thanks karthik
        Hide
        Karthik Kambatla (Inactive) added a comment -

        Thanks Andrew. Will commit this later today if no one objects.

        Show
        Karthik Kambatla (Inactive) added a comment - Thanks Andrew. Will commit this later today if no one objects.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12657874/hadoop-10896.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +0 tests included. The patch appears to be a documentation patch that doesn't require tests.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

        org.apache.hadoop.ha.TestZKFailoverControllerStress
        org.apache.hadoop.ipc.TestIPC

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4366//testReport/
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4366//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12657874/hadoop-10896.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +0 tests included . The patch appears to be a documentation patch that doesn't require tests. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ha.TestZKFailoverControllerStress org.apache.hadoop.ipc.TestIPC +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4366//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4366//console This message is automatically generated.
        Hide
        Karthik Kambatla (Inactive) added a comment -

        Just committed to trunk, branch-2 and branch-2.5.

        Show
        Karthik Kambatla (Inactive) added a comment - Just committed to trunk, branch-2 and branch-2.5.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-trunk-Commit #5972 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5972/)
        HADOOP-10896. Update compatibility doc to capture visibility of un-annotated classes/ methods. (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1613543)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/Compatibility.apt.vm
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #5972 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5972/ ) HADOOP-10896 . Update compatibility doc to capture visibility of un-annotated classes/ methods. (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1613543 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/Compatibility.apt.vm
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Yarn-trunk #624 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/624/)
        HADOOP-10896. Update compatibility doc to capture visibility of un-annotated classes/ methods. (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1613543)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/Compatibility.apt.vm
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #624 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/624/ ) HADOOP-10896 . Update compatibility doc to capture visibility of un-annotated classes/ methods. (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1613543 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/Compatibility.apt.vm
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hadoop-Hdfs-trunk #1816 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1816/)
        HADOOP-10896. Update compatibility doc to capture visibility of un-annotated classes/ methods. (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1613543)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/Compatibility.apt.vm
        Show
        Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1816 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1816/ ) HADOOP-10896 . Update compatibility doc to capture visibility of un-annotated classes/ methods. (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1613543 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/Compatibility.apt.vm
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1843 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1843/)
        HADOOP-10896. Update compatibility doc to capture visibility of un-annotated classes/ methods. (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1613543)

        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
        • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/Compatibility.apt.vm
        Show
        Hudson added a comment - SUCCESS: Integrated in Hadoop-Mapreduce-trunk #1843 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1843/ ) HADOOP-10896 . Update compatibility doc to capture visibility of un-annotated classes/ methods. (kasha) (kasha: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1613543 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/site/apt/Compatibility.apt.vm

          People

          • Assignee:
            Karthik Kambatla
            Reporter:
            Karthik Kambatla
          • Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development