Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.4.1
    • Fix Version/s: 3.0.0-alpha1
    • Component/s: security
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      While JavaKeyStoreProvider is thread safe, UserProvider is not thread safe.

        Issue Links

          Activity

          Hide
          benoyantony Benoy Antony added a comment -

          Synchronized mutators and accessors in UserProvider. Added javadoc comment in CredentialProvider to inform about thread safety requirement.

          Since there is no change in functionality, no tests are added.

          Show
          benoyantony Benoy Antony added a comment - Synchronized mutators and accessors in UserProvider . Added javadoc comment in CredentialProvider to inform about thread safety requirement. Since there is no change in functionality, no tests are added.
          Hide
          lmccay Larry McCay added a comment -

          +1

          Show
          lmccay Larry McCay added a comment - +1
          Hide
          benoyantony Benoy Antony added a comment -

          Thanks Larry McCay for the review. Vinayakumar B, could you also please review this ?

          Show
          benoyantony Benoy Antony added a comment - Thanks Larry McCay for the review. Vinayakumar B , could you also please review this ?
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          For the consistency, +1. I will commit the patch shortly. Could you mark affect versions and target versions?

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - For the consistency, +1. I will commit the patch shortly. Could you mark affect versions and target versions?
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Thanks a lot, Benoy for the patch. I have committed this to trunk.
          Thanks a lot, Larry for the review!

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Thanks a lot, Benoy for the patch. I have committed this to trunk. Thanks a lot, Larry for the review!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Hadoop-trunk-Commit #5883 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5883/)
          HADOOP-10831. UserProvider is not thread safe. (Benoy Antony via umamahesh) (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1610789)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialProvider.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/UserProvider.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Hadoop-trunk-Commit #5883 (See https://builds.apache.org/job/Hadoop-trunk-Commit/5883/ ) HADOOP-10831 . UserProvider is not thread safe. (Benoy Antony via umamahesh) (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1610789 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialProvider.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/UserProvider.java
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12655810/HADOOP-10831.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 javadoc. There were no new javadoc warning messages.

          +1 eclipse:eclipse. The patch built with eclipse:eclipse.

          +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-common:

          org.apache.hadoop.ipc.TestIPC
          org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem
          org.apache.hadoop.fs.TestSymlinkLocalFSFileContext

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4277//testReport/
          Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4277//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12655810/HADOOP-10831.patch against trunk revision . +1 @author . The patch does not contain any @author tags. -1 tests included . The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javac . The applied patch does not increase the total number of javac compiler warnings. +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ipc.TestIPC org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem org.apache.hadoop.fs.TestSymlinkLocalFSFileContext +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4277//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4277//console This message is automatically generated.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Yarn-trunk #614 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/614/)
          HADOOP-10831. UserProvider is not thread safe. (Benoy Antony via umamahesh) (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1610789)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialProvider.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/UserProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Yarn-trunk #614 (See https://builds.apache.org/job/Hadoop-Yarn-trunk/614/ ) HADOOP-10831 . UserProvider is not thread safe. (Benoy Antony via umamahesh) (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1610789 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialProvider.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/UserProvider.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Mapreduce-trunk #1833 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1833/)
          HADOOP-10831. UserProvider is not thread safe. (Benoy Antony via umamahesh) (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1610789)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialProvider.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/UserProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Mapreduce-trunk #1833 (See https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1833/ ) HADOOP-10831 . UserProvider is not thread safe. (Benoy Antony via umamahesh) (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1610789 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialProvider.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/UserProvider.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-Hdfs-trunk #1806 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1806/)
          HADOOP-10831. UserProvider is not thread safe. (Benoy Antony via umamahesh) (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1610789)

          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialProvider.java
          • /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/UserProvider.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-Hdfs-trunk #1806 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/1806/ ) HADOOP-10831 . UserProvider is not thread safe. (Benoy Antony via umamahesh) (umamahesh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1610789 ) /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/CredentialProvider.java /hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/UserProvider.java

            People

            • Assignee:
              benoyantony Benoy Antony
              Reporter:
              benoyantony Benoy Antony
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development