Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: security
    • Labels:
      None
    1. HADOOP-10800.patch
      71 kB
      Alejandro Abdelnur
    2. HADOOP-10800.patch
      73 kB
      Alejandro Abdelnur
    3. COMBO.patch
      183 kB
      Alejandro Abdelnur

      Issue Links

        Activity

        Hide
        Alejandro Abdelnur added a comment -

        Andrew Wang, doing a rename would require merging HADOOP-10799 and this JIRA into one making the patch bigger. the changes/improvements cannot be decoupled as i had to remove HttpFS specific stuff. I've tried squashing the 2 patches in GIT to see if it would detect the rename, but it did not.

        I've preserved in this JIRA all delegation token tests logic untouched (changes are imports/constants) as way of ensuring i'm not breaking things. Also note that WebHdfsFileSystem client is untouched and it does itself delegation token stuff which is also tested in HttpFS.

        Show
        Alejandro Abdelnur added a comment - Andrew Wang , doing a rename would require merging HADOOP-10799 and this JIRA into one making the patch bigger. the changes/improvements cannot be decoupled as i had to remove HttpFS specific stuff. I've tried squashing the 2 patches in GIT to see if it would detect the rename, but it did not. I've preserved in this JIRA all delegation token tests logic untouched (changes are imports/constants) as way of ensuring i'm not breaking things. Also note that WebHdfsFileSystem client is untouched and it does itself delegation token stuff which is also tested in HttpFS.
        Hide
        Andrew Wang added a comment -

        I took a quick look at this and HADOOP-10799. It looks like some of the new stuff in 10799 is based on existing HttpFS code, and then 10800 strips out the existing HttpFS code to instead use the new common functionality.

        Is it possible to do these rename-type changes in the same patch? This way we can preserve SVN history. For easier review, it'd also be nice to restrict the first patch to just renames and minor required changes, then additional patches can clean it up.

        Show
        Andrew Wang added a comment - I took a quick look at this and HADOOP-10799 . It looks like some of the new stuff in 10799 is based on existing HttpFS code, and then 10800 strips out the existing HttpFS code to instead use the new common functionality. Is it possible to do these rename-type changes in the same patch? This way we can preserve SVN history. For easier review, it'd also be nice to restrict the first patch to just renames and minor required changes, then additional patches can clean it up.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12656450/HADOOP-10800.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 4 new or modified test files.

        -1 javac. The patch appears to cause the build to fail.

        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4311//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12656450/HADOOP-10800.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 4 new or modified test files. -1 javac . The patch appears to cause the build to fail. Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4311//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        This is belongs to a string of patches built on top of each other:

        Show
        Alejandro Abdelnur added a comment - This is belongs to a string of patches built on top of each other: HADOOP-10817 proxyuser logic supporting custom prefix properties HADOOP-10799 HTTP delegation token built in client/server authentication classes HADOOP-10800 HttpFS using HADOOP-10799 and removing custom code HADOOP-10835 HTTP proxyuser logic built in client/server authentication classes HADOOP-10836 HttpFS using HADOOP-10835 and removing custom code HADOOP-10770 KMS delegation support using HADOOP-10799 HADOOP-10698 KMS proxyuser support using HADOOP-10835
        Hide
        Alejandro Abdelnur added a comment -

        the javac warnings are from HADOOP-10799 (just uploaded patch there to fix), the testcases are unrelated.

        Show
        Alejandro Abdelnur added a comment - the javac warnings are from HADOOP-10799 (just uploaded patch there to fix), the testcases are unrelated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12655307/COMBO.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 8 new or modified test files.

        -1 javac. The applied patch generated 1264 javac compiler warnings (more than the trunk's current 1260 warnings).

        +1 javadoc. There were no new javadoc warning messages.

        +1 eclipse:eclipse. The patch built with eclipse:eclipse.

        +1 findbugs. The patch does not introduce any new Findbugs (version 2.0.3) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these unit tests in hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-httpfs:

        org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl
        org.apache.hadoop.fs.TestSymlinkLocalFSFileContext
        org.apache.hadoop.ipc.TestIPC
        org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4251//testReport/
        Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4251//artifact/trunk/patchprocess/diffJavacWarnings.txt
        Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4251//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall . Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12655307/COMBO.patch against trunk revision . +1 @author . The patch does not contain any @author tags. +1 tests included . The patch appears to include 8 new or modified test files. -1 javac . The applied patch generated 1264 javac compiler warnings (more than the trunk's current 1260 warnings). +1 javadoc . There were no new javadoc warning messages. +1 eclipse:eclipse . The patch built with eclipse:eclipse. +1 findbugs . The patch does not introduce any new Findbugs (version 2.0.3) warnings. +1 release audit . The applied patch does not increase the total number of release audit warnings. -1 core tests . The patch failed these unit tests in hadoop-common-project/hadoop-auth hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-httpfs: org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl org.apache.hadoop.fs.TestSymlinkLocalFSFileContext org.apache.hadoop.ipc.TestIPC org.apache.hadoop.fs.TestSymlinkLocalFSFileSystem +1 contrib tests . The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4251//testReport/ Javac warnings: https://builds.apache.org/job/PreCommit-HADOOP-Build/4251//artifact/trunk/patchprocess/diffJavacWarnings.txt Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4251//console This message is automatically generated.
        Hide
        Alejandro Abdelnur added a comment -

        combo patch (including HADOOP-10799) for test-patch to run.

        Show
        Alejandro Abdelnur added a comment - combo patch (including HADOOP-10799 ) for test-patch to run.
        Hide
        Alejandro Abdelnur added a comment -

        rebase on top of latest HADOOP-10799.

        Show
        Alejandro Abdelnur added a comment - rebase on top of latest HADOOP-10799 .
        Hide
        Alejandro Abdelnur added a comment -

        patch requires HADOOP-10799

        Show
        Alejandro Abdelnur added a comment - patch requires HADOOP-10799

          People

          • Assignee:
            Alejandro Abdelnur
            Reporter:
            Alejandro Abdelnur
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development